You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by staslev <gi...@git.apache.org> on 2017/01/01 15:14:15 UTC
[GitHub] beam pull request #1723: [BEAM-1223] Introduced Sum,Min,Max#ofLongs()/ofDoub...
GitHub user staslev opened a pull request:
https://github.com/apache/beam/pull/1723
[BEAM-1223] Introduced Sum,Min,Max#ofLongs()/ofDoubles()/ofIntegers()\u2026
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
R: @lukecwik
About half way into this I was questioning the benefit-cost ratio, but since consistency is what this PR is all about I figured bailing out would not be appropriate.
Let me know how it looks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/staslev/incubator-beam BEAM-1223-Add-static-factory-methods-for-CombineFn-classes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1723.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1723
----
commit 70f8db4021b7c9e49a280edb740667ae67224ef7
Author: Stas Levin <st...@gmail.com>
Date: 2017-01-01T11:58:32Z
[BEAM-1223] Introduced Sum,Min,Max#ofLongs()/ofDoubles()/ofIntegers() and eliminated the direction instantiation of the corresponding classes.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #1723: [BEAM-1223] Introduced Sum,Min,Max#ofLongs()/ofDoub...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/1723
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---