[GitHub] [helix] jiajunwang commented on issue #1617: The static map of GenericHelixController could be overwritten if create multiple controllers for the same cluster in one JVM

[GitBox <gi...@apache.org>]

jiajunwang commented on issue #1617:
URL: https://github.com/apache/helix/issues/1617#issuecomment-765793744


   > Would adding a isLeader() check prevent this scenario here?
   > 
   > https://github.com/apache/helix/blob/361e18da4152c0146daa9d9dc7929f1f2bdcd9dc/helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java#L656
   
   Possible but not necessarily the best solution. The leadership could be changed at any time. However, there is no existing way to modify the record in the map after the controller instance is created.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org