You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2021/07/06 08:55:23 UTC
[GitHub] [james-project] chibenwa opened a new pull request #531: Various small performance enhancements when sending messages via JMAP
chibenwa opened a new pull request #531:
URL: https://github.com/apache/james-project/pull/531
## Before
```
================================================================================
---- Global Information --------------------------------------------------------
> request count 29532 (OK=29532 KO=0 )
> min response time 6 (OK=6 KO=- )
> max response time 5137 (OK=5137 KO=- )
> mean response time 344 (OK=344 KO=- )
> std deviation 325 (OK=325 KO=- )
> response time 50th percentile 241 (OK=241 KO=- )
> response time 75th percentile 370 (OK=370 KO=- )
> response time 95th percentile 848 (OK=848 KO=- )
> response time 99th percentile 1777 (OK=1777 KO=- )
> mean requests/sec 40.678 (OK=40.678 KO=- )
---- Response Time Distribution ------------------------------------------------
> t < 800 ms 27913 ( 95%)
> 800 ms < t < 1200 ms 748 ( 3%)
> t > 1200 ms 871 ( 3%)
> failed 0 ( 0%)
================================================================================
```
## After
```
================================================================================
---- Global Information --------------------------------------------------------
> request count 29790 (OK=29790 KO=0 )
> min response time 8 (OK=8 KO=- )
> max response time 5403 (OK=5403 KO=- )
> mean response time 316 (OK=316 KO=- )
> std deviation 256 (OK=256 KO=- )
> response time 50th percentile 248 (OK=248 KO=- )
> response time 75th percentile 327 (OK=327 KO=- )
> response time 95th percentile 691 (OK=691 KO=- )
> response time 99th percentile 1363 (OK=1363 KO=- )
> mean requests/sec 40.977 (OK=40.977 KO=- )
---- Response Time Distribution ------------------------------------------------
> t < 800 ms 28893 ( 97%)
> 800 ms < t < 1200 ms 460 ( 2%)
> t > 1200 ms 437 ( 1%)
> failed 0 ( 0%)
================================================================================
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #531: Various small performance enhancements when sending messages via JMAP
Posted by GitBox <gi...@apache.org>.
chibenwa merged pull request #531:
URL: https://github.com/apache/james-project/pull/531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on pull request #531: Various small performance enhancements when sending messages via JMAP
Posted by GitBox <gi...@apache.org>.
Arsnael commented on pull request #531:
URL: https://github.com/apache/james-project/pull/531#issuecomment-876256696
Can you squash that fixup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] Arsnael commented on a change in pull request #531: Various small performance enhancements when sending messages via JMAP
Posted by GitBox <gi...@apache.org>.
Arsnael commented on a change in pull request #531:
URL: https://github.com/apache/james-project/pull/531#discussion_r665001000
##########
File path: core/src/main/java/org/apache/james/core/Username.java
##########
@@ -40,14 +37,16 @@ public static Username of(String username) {
Preconditions.checkArgument(username.length() <= MAXIMUM_MAIL_ADDRESS_LENGTH,
"username length should not be longer than %s characters", MAXIMUM_MAIL_ADDRESS_LENGTH);
- List<String> parts = ImmutableList.copyOf(Splitter.on('@').split(username));
- switch (parts.size()) {
- case 1:
- return fromLocalPartWithoutDomain(username);
- case 2:
- return fromLocalPartWithDomain(parts.get(0), parts.get(1));
+ int atPosition = username.indexOf('@');
+ if (atPosition < 0) {
+ return fromLocalPartWithoutDomain(username);
}
- throw new IllegalArgumentException("The username should not contain multiple domain delimiter. Value: " + username);
+ String userPart = username.substring(0, atPosition);
+ String domainPart = username.substring(atPosition + 1);
+ if (domainPart.indexOf('@') > 0) {
Review comment:
`>=` ? If you have an extra `@` at the index 0 you miss it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org