[GitHub] [skywalking-banyandb] lujiajing1126 commented on a diff in pull request #257: [OAP Integration] Register missing TopN registry service

["lujiajing1126 (via GitHub)" <gi...@apache.org>]

lujiajing1126 commented on code in PR #257:
URL: https://github.com/apache/skywalking-banyandb/pull/257#discussion_r1136506714


##########
banyand/measure/measure_write.go:
##########
@@ -131,9 +131,12 @@ func (s *measure) write(shardID common.ShardID, entity []byte, entityValues tsdb
 	}
 	s.indexWriter.Write(m)
 	if s.processorManager != nil {
-		s.processorManager.onMeasureWrite(&measurev1.WriteRequest{
-			Metadata:  s.GetMetadata(),
-			DataPoint: value,
+		s.processorManager.onMeasureWrite(&measurev1.InternalWriteRequest{
+			Request: &measurev1.WriteRequest{
+				Metadata:  s.GetMetadata(),
+				DataPoint: value,
+			},
+			EntityValues: entityValues[1:],

Review Comment:
   > Why do you remove the first value? This value is from the measure's specification. The first is not a reserved entity.
   
   https://github.com/apache/skywalking-banyandb/blob/e68249a385a720d075eab52b496d7c4b4679ba41/pkg/partition/entity.go#L58-L59
   
   The first entity is just the source measure name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org