You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "satishd (via GitHub)" <gi...@apache.org> on 2023/02/13 08:20:42 UTC

[GitHub] [kafka] satishd commented on a diff in pull request #13234: KAFKA-14706 Move/rewrite ShutdownableThread to server-common module.

satishd commented on code in PR #13234:
URL: https://github.com/apache/kafka/pull/13234#discussion_r1104124125


##########
examples/src/main/java/kafka/examples/Consumer.java:
##########
@@ -83,13 +83,4 @@ public void doWork() {
         }
     }
 
-    @Override
-    public String name() {

Review Comment:
   +1  "examples" module should not be dependant on internal server side components, filed https://issues.apache.org/jira/browse/KAFKA-14708



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org