You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/12/19 03:50:17 UTC
Review Request 29234: Transformed the allocation in allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29234/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-2030
https://issues.apache.org/jira/browse/MESOS-2030
Repository: mesos-git
Description
-------
Transformed the allocation in allocator after launch a task.
Diffs
-----
src/master/master.cpp a03469c795c924ddf5fbfeee495a17f59f4465f9
Diff: https://reviews.apache.org/r/29234/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 29234: Transformed the allocation in allocator.
Posted by Ben Mahler <be...@gmail.com>.
> On Dec. 19, 2014, 2:53 a.m., Ben Mahler wrote:
> > Mind adding a TODO on the LOG(INFO) in HierarchicalAllocatorProcess::transformAllocation? As it stands, we'll be logging no-op transformations which might be excessive.
>
> Jie Yu wrote:
> Done.
How about this for a commit message: "Updated the master to transform allocations."
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29234/#review65584
-----------------------------------------------------------
On Dec. 19, 2014, 2:50 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29234/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 2:50 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2030
> https://issues.apache.org/jira/browse/MESOS-2030
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Transformed the allocation in allocator after launch a task.
>
>
> Diffs
> -----
>
> src/master/master.cpp a03469c795c924ddf5fbfeee495a17f59f4465f9
>
> Diff: https://reviews.apache.org/r/29234/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 29234: Transformed the allocation in allocator.
Posted by Jie Yu <yu...@gmail.com>.
> On Dec. 19, 2014, 2:53 a.m., Ben Mahler wrote:
> > Mind adding a TODO on the LOG(INFO) in HierarchicalAllocatorProcess::transformAllocation? As it stands, we'll be logging no-op transformations which might be excessive.
Done.
> On Dec. 19, 2014, 2:53 a.m., Ben Mahler wrote:
> > src/master/master.cpp, line 94
> > <https://reviews.apache.org/r/29234/diff/1/?file=797057#file797057line94>
> >
> > #include for this?
Done.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29234/#review65584
-----------------------------------------------------------
On Dec. 19, 2014, 2:50 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29234/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 2:50 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2030
> https://issues.apache.org/jira/browse/MESOS-2030
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Transformed the allocation in allocator after launch a task.
>
>
> Diffs
> -----
>
> src/master/master.cpp a03469c795c924ddf5fbfeee495a17f59f4465f9
>
> Diff: https://reviews.apache.org/r/29234/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 29234: Transformed the allocation in allocator.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29234/#review65584
-----------------------------------------------------------
Ship it!
Mind adding a TODO on the LOG(INFO) in HierarchicalAllocatorProcess::transformAllocation? As it stands, we'll be logging no-op transformations which might be excessive.
src/master/master.cpp
<https://reviews.apache.org/r/29234/#comment108832>
#include for this?
- Ben Mahler
On Dec. 19, 2014, 2:50 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29234/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 2:50 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2030
> https://issues.apache.org/jira/browse/MESOS-2030
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Transformed the allocation in allocator after launch a task.
>
>
> Diffs
> -----
>
> src/master/master.cpp a03469c795c924ddf5fbfeee495a17f59f4465f9
>
> Diff: https://reviews.apache.org/r/29234/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 29234: Transformed the allocation in allocator.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29234/#review65595
-----------------------------------------------------------
Bad patch!
Reviews applied: [29234]
Failed command: ./support/apply-review.sh -n -r 29234
Error:
2014-12-19 03:41:53 URL:https://reviews.apache.org/r/29234/diff/raw/ [2435/2435] -> "29234.patch" [1]
error: patch failed: src/master/master.cpp:91
error: src/master/master.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Dec. 19, 2014, 2:50 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29234/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 2:50 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2030
> https://issues.apache.org/jira/browse/MESOS-2030
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Transformed the allocation in allocator after launch a task.
>
>
> Diffs
> -----
>
> src/master/master.cpp a03469c795c924ddf5fbfeee495a17f59f4465f9
>
> Diff: https://reviews.apache.org/r/29234/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>