You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@whirr.apache.org by John Conwell <jo...@iamjohn.me> on 2011/08/31 18:15:57 UTC
question about the service stop scripts, beforeDestroy and
afterDestroy methods.
When the user calls 'whirr destroy-cluster' or 'whirr destroy-instance' from
the cmd line, does whirr execute the stop scirpt for the services defined in
the config file? Looking through the code, I never saw anything referencing
the stop scripts. Also, is this when the
ClusterActionHandlerSupport.beforeDestroy and afterDestroy methods get
called?
--
Thanks,
John C
Re: question about the service stop scripts, beforeDestroy and
afterDestroy methods.
Posted by Andrei Savu <sa...@gmail.com>.
You should probably check the Chef patch:
https://issues.apache.org/jira/browse/WHIRR-49
I'm not sure it's fully functional yet but it should allow you to
reuse many chef recipes for setting up services (e.g. tomcat).
-- Andrei
On Wed, Aug 31, 2011 at 10:22 AM, John Conwell <jo...@iamjohn.me> wrote:
> I've got so many ideas for Whirr...I need to get involved in the project.
> Also busy writing services for Tomcat, ActiveMQ
>
> On Wed, Aug 31, 2011 at 10:14 AM, Andrei Savu <sa...@gmail.com> wrote:
>>
>> It should be easy to make Whirr trigger the after/beforeDestroy
>> events. Feel free to provide a patch :)
>>
>> Cheers,
>>
>> -- Andrei Savu
>>
>> On Wed, Aug 31, 2011 at 10:11 AM, John Conwell <jo...@iamjohn.me> wrote:
>> > I wrote a Solr service for Whirr a few months ago against 0.4.0 and am
>> > updating it to 0.6.0 (I need to see about getting this committed). In
>> > looking at the new internal Whirr API changes from 0.4.0 to 0.5.0 I
>> > noticed
>> > the new start and stop scripts. And that got me thinking about writing
>> > custom teardown logic.
>> > For example, when I destroy a cluster, it would be nice if the before /
>> > afterDestroy methods were called, and allowed the service to put
>> > together a
>> > script that gracefully stops the service (finish processing any
>> > current requests, but refuse new requests), or backup of any state I
>> > wanted
>> > to store (maybe to S3 or EBS).
>> >
>> > I was hoping that this is how it was working in 0.6.0.
>> > By the way...still love whirr!
>> > On Wed, Aug 31, 2011 at 10:02 AM, Andrei Savu <sa...@gmail.com>
>> > wrote:
>> >>
>> >> On Wed, Aug 31, 2011 at 9:15 AM, John Conwell <jo...@iamjohn.me> wrote:
>> >> > When the user calls 'whirr destroy-cluster' or 'whirr
>> >> > destroy-instance'
>> >> > from
>> >> > the cmd line, does whirr execute the stop scirpt for the services
>> >> > defined in
>> >> > the config file?
>> >>
>> >> No. We've added the stop scripts for future use (e.g. add / remove
>> >> node functionality).
>> >>
>> >> > Also, is this when the ClusterActionHandlerSupport.beforeDestroy
>> >> > and afterDestroy methods get called?
>> >>
>> >> before / afterDestroy are actually never called right now. IMO this is
>> >> a bug we need to fix. How are you planning to use this event?
>> >
>> >
>> >
>> > --
>> >
>> > Thanks,
>> > John C
>> >
>
>
>
> --
>
> Thanks,
> John C
>
Re: question about the service stop scripts, beforeDestroy and
afterDestroy methods.
Posted by John Conwell <jo...@iamjohn.me>.
I've got so many ideas for Whirr...I need to get involved in the project.
Also busy writing services for Tomcat, ActiveMQ
On Wed, Aug 31, 2011 at 10:14 AM, Andrei Savu <sa...@gmail.com> wrote:
> It should be easy to make Whirr trigger the after/beforeDestroy
> events. Feel free to provide a patch :)
>
> Cheers,
>
> -- Andrei Savu
>
> On Wed, Aug 31, 2011 at 10:11 AM, John Conwell <jo...@iamjohn.me> wrote:
> > I wrote a Solr service for Whirr a few months ago against 0.4.0 and am
> > updating it to 0.6.0 (I need to see about getting this committed). In
> > looking at the new internal Whirr API changes from 0.4.0 to 0.5.0 I
> noticed
> > the new start and stop scripts. And that got me thinking about writing
> > custom teardown logic.
> > For example, when I destroy a cluster, it would be nice if the before /
> > afterDestroy methods were called, and allowed the service to put together
> a
> > script that gracefully stops the service (finish processing any
> > current requests, but refuse new requests), or backup of any state I
> wanted
> > to store (maybe to S3 or EBS).
> >
> > I was hoping that this is how it was working in 0.6.0.
> > By the way...still love whirr!
> > On Wed, Aug 31, 2011 at 10:02 AM, Andrei Savu <sa...@gmail.com>
> wrote:
> >>
> >> On Wed, Aug 31, 2011 at 9:15 AM, John Conwell <jo...@iamjohn.me> wrote:
> >> > When the user calls 'whirr destroy-cluster' or 'whirr
> destroy-instance'
> >> > from
> >> > the cmd line, does whirr execute the stop scirpt for the services
> >> > defined in
> >> > the config file?
> >>
> >> No. We've added the stop scripts for future use (e.g. add / remove
> >> node functionality).
> >>
> >> > Also, is this when the ClusterActionHandlerSupport.beforeDestroy
> >> > and afterDestroy methods get called?
> >>
> >> before / afterDestroy are actually never called right now. IMO this is
> >> a bug we need to fix. How are you planning to use this event?
> >
> >
> >
> > --
> >
> > Thanks,
> > John C
> >
>
--
Thanks,
John C
Re: question about the service stop scripts, beforeDestroy and
afterDestroy methods.
Posted by Andrei Savu <sa...@gmail.com>.
It should be easy to make Whirr trigger the after/beforeDestroy
events. Feel free to provide a patch :)
Cheers,
-- Andrei Savu
On Wed, Aug 31, 2011 at 10:11 AM, John Conwell <jo...@iamjohn.me> wrote:
> I wrote a Solr service for Whirr a few months ago against 0.4.0 and am
> updating it to 0.6.0 (I need to see about getting this committed). In
> looking at the new internal Whirr API changes from 0.4.0 to 0.5.0 I noticed
> the new start and stop scripts. And that got me thinking about writing
> custom teardown logic.
> For example, when I destroy a cluster, it would be nice if the before /
> afterDestroy methods were called, and allowed the service to put together a
> script that gracefully stops the service (finish processing any
> current requests, but refuse new requests), or backup of any state I wanted
> to store (maybe to S3 or EBS).
>
> I was hoping that this is how it was working in 0.6.0.
> By the way...still love whirr!
> On Wed, Aug 31, 2011 at 10:02 AM, Andrei Savu <sa...@gmail.com> wrote:
>>
>> On Wed, Aug 31, 2011 at 9:15 AM, John Conwell <jo...@iamjohn.me> wrote:
>> > When the user calls 'whirr destroy-cluster' or 'whirr destroy-instance'
>> > from
>> > the cmd line, does whirr execute the stop scirpt for the services
>> > defined in
>> > the config file?
>>
>> No. We've added the stop scripts for future use (e.g. add / remove
>> node functionality).
>>
>> > Also, is this when the ClusterActionHandlerSupport.beforeDestroy
>> > and afterDestroy methods get called?
>>
>> before / afterDestroy are actually never called right now. IMO this is
>> a bug we need to fix. How are you planning to use this event?
>
>
>
> --
>
> Thanks,
> John C
>
Re: question about the service stop scripts, beforeDestroy and
afterDestroy methods.
Posted by John Conwell <jo...@iamjohn.me>.
I wrote a Solr service for Whirr a few months ago against 0.4.0 and am
updating it to 0.6.0 (I need to see about getting this committed). In
looking at the new internal Whirr API changes from 0.4.0 to 0.5.0 I noticed
the new start and stop scripts. And that got me thinking about writing
custom teardown logic.
For example, when I destroy a cluster, it would be nice if the before /
afterDestroy methods were called, and allowed the service to put together a
script that gracefully stops the service (finish processing any
current requests, but refuse new requests), or backup of any state I wanted
to store (maybe to S3 or EBS).
I was hoping that this is how it was working in 0.6.0.
By the way...still love whirr!
On Wed, Aug 31, 2011 at 10:02 AM, Andrei Savu <sa...@gmail.com> wrote:
> On Wed, Aug 31, 2011 at 9:15 AM, John Conwell <jo...@iamjohn.me> wrote:
> > When the user calls 'whirr destroy-cluster' or 'whirr destroy-instance'
> from
> > the cmd line, does whirr execute the stop scirpt for the services defined
> in
> > the config file?
>
> No. We've added the stop scripts for future use (e.g. add / remove
> node functionality).
>
> > Also, is this when the ClusterActionHandlerSupport.beforeDestroy
> > and afterDestroy methods get called?
>
> before / afterDestroy are actually never called right now. IMO this is
> a bug we need to fix. How are you planning to use this event?
>
--
Thanks,
John C
Re: question about the service stop scripts, beforeDestroy and
afterDestroy methods.
Posted by Andrei Savu <sa...@gmail.com>.
On Wed, Aug 31, 2011 at 9:15 AM, John Conwell <jo...@iamjohn.me> wrote:
> When the user calls 'whirr destroy-cluster' or 'whirr destroy-instance' from
> the cmd line, does whirr execute the stop scirpt for the services defined in
> the config file?
No. We've added the stop scripts for future use (e.g. add / remove
node functionality).
> Also, is this when the ClusterActionHandlerSupport.beforeDestroy
> and afterDestroy methods get called?
before / afterDestroy are actually never called right now. IMO this is
a bug we need to fix. How are you planning to use this event?