You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/13 03:34:28 UTC
[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #261: Initial
checkin nuttx github action CI workflow
liuguo09 opened a new pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261
Github action CI workflow steps as below:
1. Checkout nuttx repo with pull request
3. Do git commands to get commits in PR and then do checkpatch.sh
2. Checkout apps repo
4. Checkout testing repo since cibuild.sh must be used later
4. Install build essential tools
5. Call testing/cibuild.sh to do check build
Signed-off-by: liuhaitao <li...@xiaomi.com>
Not intended to be merged right now. Still need align to check testlist update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on issue #261: Initial checkin
nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595625436
> @liuguo09 also if you have your Dockerfile somewhere I would be happy to submit a PR against it to improve it a bit. There is some low hanging fruit that would reduce the size by quite a bit.
I have just made PR here the Dockerfile.
https://github.com/apache/incubator-nuttx-testing/pull/13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on issue #261: Initial checkin
nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-586092802
Not yet, it just enabled and tested in my own fork. There are still some work (parallel build flock fix and check testlist update) to do before this PR merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #261: Initial
checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595078153
@maht and @yamt , please take a look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on issue #261: Initial checkin
nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595551685
@liuguo09 also if you have your Dockerfile somewhere I would be happy to submit a PR against it to improve it a bit. There is some low hanging fruit that would reduce the size by quite a bit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #261: Initial
checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request
#261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388966235
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ check:
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-nuttx-apps
+ path: apps
+ fetch-depth: 0
+
+ - name: Check Pull Request
+ run: |
+ cd nuttx
+ git log --oneline -5
+ ranges=`git log -1 --merges --pretty=format:%P | awk -F" " '{ print $1 ".." $2 }'`
+ commits=`git log --reverse --format=format:%H $ranges`
+ echo "./tools/checkpatch.sh -g $commits"
+ ./tools/checkpatch.sh -g $commits
+
+ build:
+ needs: check
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ strategy:
+ matrix:
+ boards: [sim, mips-riscv-x86, arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15]
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Fetch nuttx tags
+ run: |
+ cd nuttx
+ git fetch --tags
Review comment:
I have checked that the instructions in the https://github.com/actions/checkout#fetch-all-tags run two steps too.
So it doesn't make much sense to use same as it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #261: Initial
checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595245087
> > What is the limit on jobs? Are we there yet?
>
> For github action free version, there are 20 jobs upper limit. And now used 17 jobs here. Each job runs in an 2-cores cpu container. More limits about github action, refer to:
> https://help.github.com/en/actions/getting-started-with-github-actions/about-github-actions#usage-limits
We reserve 3 VM interntionally for two purposes:
1.Build the remainning config(total 78)
2.Test Windows(native, cygwin, msys) and macOS build environment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on issue #261: Initial checkin
nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595063705
@btashton please help to review. Now use docker container and matrix jobs for parallel builds.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request
#261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388123102
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ check:
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-nuttx-apps
+ path: apps
+ fetch-depth: 0
+
+ - name: Check Pull Request
+ run: |
+ cd nuttx
+ git log --oneline -5
+ ranges=`git log -1 --merges --pretty=format:%P | awk -F" " '{ print $1 ".." $2 }'`
+ commits=`git log --reverse --format=format:%H $ranges`
+ echo "./tools/checkpatch.sh -g $commits"
+ ./tools/checkpatch.sh -g $commits
+
+ build:
+ needs: check
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ strategy:
+ matrix:
+ boards: [sim, mips-riscv-x86, arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15]
Review comment:
Ok, I'll reorder them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on issue #261: Initial checkin
nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-586612971
Also breakings out the action code means that it can almost all live in the testing repo with just a tiny stub here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on a change in pull request
#261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388970119
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ check:
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-nuttx-apps
+ path: apps
+ fetch-depth: 0
+
+ - name: Check Pull Request
+ run: |
+ cd nuttx
+ git log --oneline -5
+ ranges=`git log -1 --merges --pretty=format:%P | awk -F" " '{ print $1 ".." $2 }'`
+ commits=`git log --reverse --format=format:%H $ranges`
+ echo "./tools/checkpatch.sh -g $commits"
+ ./tools/checkpatch.sh -g $commits
+
+ build:
+ needs: check
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ strategy:
+ matrix:
+ boards: [sim, mips-riscv-x86, arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15]
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Fetch nuttx tags
+ run: |
+ cd nuttx
+ git fetch --tags
Review comment:
I guess the cost is low for the two steps, but other examples there like submodules show two run lines which I think makes sense to just get everything done. But these are really later optimizations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #261: Initial checkin
nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595138729
@liuguo09 - Nice!
What % of board configs are being built (n of N)?
What is the total build time?
What is the limit on jobs? Are we there yet?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on issue #261: Initial checkin
nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
btashton commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-586612755
Yeah this needs some work. The build job should be abstracted so you can give it a target. Then a build job is defined for each target. That way we can run against all of the configurations including non Linux configs and do them in parallel.
This is normally done by breaking the core of this into it's own action that you then refer to. That can be in this repo or in another.
Also reinstalling dependencies every job is expensive. We should create a container with everything already setup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request
#261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388140963
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ check:
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-nuttx-apps
+ path: apps
+ fetch-depth: 0
+
+ - name: Check Pull Request
+ run: |
+ cd nuttx
+ git log --oneline -5
+ ranges=`git log -1 --merges --pretty=format:%P | awk -F" " '{ print $1 ".." $2 }'`
+ commits=`git log --reverse --format=format:%H $ranges`
+ echo "./tools/checkpatch.sh -g $commits"
+ ./tools/checkpatch.sh -g $commits
+
+ build:
+ needs: check
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ strategy:
+ matrix:
+ boards: [sim, mips-riscv-x86, arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15]
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on a change in pull request
#261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388968701
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
Review comment:
I think it captures the merge situation which is what I'm worried about.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on a change in pull request
#261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388666475
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
Review comment:
Should we not also run on the `push` event? Also I think this restricts to pull requests off master which might not be what we want if there is a long running feature branch. I think is can just be this.
`on: [push, pull_request]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] davids5 commented on issue #261: Initial checkin
nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595129348
> @davids5, @maht and @yamt , please take a look
Where can we see it running?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on a change in pull request
#261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388672456
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
Review comment:
I see that it by default includes synchronize so probably fine to leave it, but I would drop the branch. Maybe we still want to keep the push but limited to branch master so there is always a build on master
something like this:
```
on:
pull_request
push:
branches: [master]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on issue #261: Initial checkin
nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-587240650
That's right. I'll update with an Apache license header. And consider to use github action docker contianer to preinstall build tools. In addtion, as build job for multi targets, I'll also reconstruct testing code to handle it. It may take some time to test and verify. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on issue #261: Initial checkin
nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595212019
> @liuguo09 - Nice!
>
> What % of board configs are being built (n of N)?
Now support the following arch: arm/sim/mips/risc-v/x86
arm 455/478
sim 30/34
mips 11/11
risc-v 7/9
x86 2/2
And haven't enabled the following archs build since lack of toolchains. If available, we could update the docker container to preinstall their toolchains and update testlist to build them.
avr 0/11
hc 0/2
misoc 0/2
or1k 0/1
renesas 0/10
x86_64 0/1 // link issue need resolved
xtensa 0/3
z16 0/2
z80 0/17
> What is the total build time?
There are two stages in PR check build.
The first stage is the PR nxstyle check, it takes nearly 2 minutes(mainly pull docker container).
And the second stage is matrix jobs build which depend on the first stage success. Now each job builds about 30 configs in parallel which take nearly 20+ minutes.
If both the two stages succeed, it would spend at most half an hour in whole from my testing.
> What is the limit on jobs? Are we there yet?
For github action free version, there are 20 jobs upper limit. And now used 17 jobs here. Each job runs in an 2-cores cpu container. More limits about github action, refer to:
https://help.github.com/en/actions/getting-started-with-github-actions/about-github-actions#usage-limits
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request
#261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388125715
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ check:
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-nuttx-apps
+ path: apps
+ fetch-depth: 0
+
+ - name: Check Pull Request
+ run: |
+ cd nuttx
+ git log --oneline -5
+ ranges=`git log -1 --merges --pretty=format:%P | awk -F" " '{ print $1 ".." $2 }'`
+ commits=`git log --reverse --format=format:%H $ranges`
+ echo "./tools/checkpatch.sh -g $commits"
+ ./tools/checkpatch.sh -g $commits
+
+ build:
+ needs: check
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ strategy:
+ matrix:
+ boards: [sim, mips-riscv-x86, arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15]
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Fetch nuttx tags
+ run: |
+ cd nuttx
+ git fetch --tags
Review comment:
Since tags is needed to generate the .version file, or it would build break at first : (
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388117632
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ check:
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-nuttx-apps
+ path: apps
+ fetch-depth: 0
+
+ - name: Check Pull Request
+ run: |
+ cd nuttx
+ git log --oneline -5
+ ranges=`git log -1 --merges --pretty=format:%P | awk -F" " '{ print $1 ".." $2 }'`
+ commits=`git log --reverse --format=format:%H $ranges`
+ echo "./tools/checkpatch.sh -g $commits"
+ ./tools/checkpatch.sh -g $commits
+
+ build:
+ needs: check
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ strategy:
+ matrix:
+ boards: [sim, mips-riscv-x86, arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15]
Review comment:
Order the list?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request
#261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388956981
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
Review comment:
Update on trigger pull request for all branches. As to push event, I think it may be not necessary since there is no committer push master directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on issue #261: Initial checkin
nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595569258
> This looks great overall. I am excited to get this in and then work on getting the mac and windows configurations going.
>
> Also I do not think it is required for this first step, but adding build artifacts to the builds would be awesome as well since one could just grab a elf and the debug symbols for a build and throw it on a board to do some other validation on hardware. https://help.github.com/en/actions/configuring-and-managing-workflows/persisting-workflow-data-using-artifacts
IMO, It's a good idea. The build artifacts stage could be added in future if agreed and it doesn't add much time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request
#261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388694067
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ check:
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-nuttx-apps
+ path: apps
+ fetch-depth: 0
+
+ - name: Check Pull Request
+ run: |
+ cd nuttx
+ git log --oneline -5
+ ranges=`git log -1 --merges --pretty=format:%P | awk -F" " '{ print $1 ".." $2 }'`
+ commits=`git log --reverse --format=format:%H $ranges`
+ echo "./tools/checkpatch.sh -g $commits"
+ ./tools/checkpatch.sh -g $commits
+
+ build:
+ needs: check
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ strategy:
+ matrix:
+ boards: [sim, mips-riscv-x86, arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15]
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Fetch nuttx tags
+ run: |
+ cd nuttx
+ git fetch --tags
Review comment:
> This can be done in the checkout step https://github.com/actions/checkout#fetch-all-tags
Since I'm using the _with_ option for checkout@v2 action, the _run_ step seems not work together. I'll double check it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request
#261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388980135
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
Review comment:
There is also the nightly build to make the full build although it's per day.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request
#261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388129531
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ check:
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-nuttx-apps
+ path: apps
+ fetch-depth: 0
+
+ - name: Check Pull Request
+ run: |
+ cd nuttx
+ git log --oneline -5
Review comment:
You are right. I'll update it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388117837
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ check:
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-nuttx-apps
+ path: apps
+ fetch-depth: 0
+
+ - name: Check Pull Request
+ run: |
+ cd nuttx
+ git log --oneline -5
Review comment:
Why always fetch the first 5 commit? should we count the real patch number in PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388217577
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ check:
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-nuttx-apps
+ path: apps
+ fetch-depth: 0
+
+ - name: Check Pull Request
+ run: |
+ cd nuttx
+ git log --oneline -5
+ ranges=`git log -1 --merges --pretty=format:%P | awk -F" " '{ print $1 ".." $2 }'`
+ commits=`git log --reverse --format=format:%H $ranges`
+ echo "./tools/checkpatch.sh -g $commits"
+ ./tools/checkpatch.sh -g $commits
+
+ build:
+ needs: check
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ strategy:
+ matrix:
+ boards: [sim, mips-riscv-x86, arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15]
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Fetch nuttx tags
+ run: |
+ cd nuttx
+ git fetch --tags
Review comment:
Ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #261:
Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595078153
@davids5, @maht and @yamt , please take a look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request
#261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388692212
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
Review comment:
> I see that it by default includes synchronize so probably fine to leave it, but I would drop the branch. Maybe we still want to keep the push but limited to branch master so there is always a build on master
> something like this:
>
> ```
> on:
> pull_request
> push:
> branches: [master]
> ```
Yes, besides master branch, pull request check for feature branch would also be useful.
Now I use the pull request git log "Merge new-commit-id into old-commit-id" to filter commits in the PR and then do checkpatch.sh. But for master push, it should not work and skip. Just see the github action _job steps.if_ could be used to judge it. I'll update it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #261: Initial
checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-586595380
Does this need an Apache license header? We need to find someone with knowledge on the team to merge this. I do not have the knowledge to do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] yamt commented on issue #261: Initial checkin
nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
yamt commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-585727072
is this workflow enabled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #261: Initial
checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-586596303
Perhaps someone like @btashton could review and merge this. I will add him as the reviewer and also the the matching PR in apps/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #261: Initial
checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595593159
Yes, we can select some images(sim, x86, x86-64, qemu for arm/riscv/xtens..) as build artifacts and run the testsuite on this images automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request
#261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388141022
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ check:
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-nuttx-apps
+ path: apps
+ fetch-depth: 0
+
+ - name: Check Pull Request
+ run: |
+ cd nuttx
+ git log --oneline -5
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request
#261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388680693
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
Review comment:
> @liuguo09 also if you have your Dockerfile somewhere I would be happy to submit a PR against it to improve it a bit. There is some low hanging fruit that would reduce the size by quite a bit.
Yes, that's great. I meant to add the Dockerfile into nuttx testing repo. I'll add it later. Then you could update it there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] btashton commented on a change in pull request
#261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388666947
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ check:
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-nuttx-apps
+ path: apps
+ fetch-depth: 0
+
+ - name: Check Pull Request
+ run: |
+ cd nuttx
+ git log --oneline -5
+ ranges=`git log -1 --merges --pretty=format:%P | awk -F" " '{ print $1 ".." $2 }'`
+ commits=`git log --reverse --format=format:%H $ranges`
+ echo "./tools/checkpatch.sh -g $commits"
+ ./tools/checkpatch.sh -g $commits
+
+ build:
+ needs: check
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ strategy:
+ matrix:
+ boards: [sim, mips-riscv-x86, arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15]
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Fetch nuttx tags
+ run: |
+ cd nuttx
+ git fetch --tags
Review comment:
This can be done in the checkout step https://github.com/actions/checkout#fetch-all-tags
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on issue #261: Initial checkin
nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on issue #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#issuecomment-595134843
> > @davids5, @maht and @yamt , please take a look
>
> Where can we see it running?
This is one PR check build in my own fork:
https://github.com/liuguo09/incubator-nuttx/pull/3/checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #261: Initial checkin nuttx github action CI workflow
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #261: Initial checkin nuttx github action CI workflow
URL: https://github.com/apache/incubator-nuttx/pull/261#discussion_r388118144
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,85 @@
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+name: PR Check CI
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ check:
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Checkout apps repo
+ uses: actions/checkout@v2
+ with:
+ repository: apache/incubator-nuttx-apps
+ path: apps
+ fetch-depth: 0
+
+ - name: Check Pull Request
+ run: |
+ cd nuttx
+ git log --oneline -5
+ ranges=`git log -1 --merges --pretty=format:%P | awk -F" " '{ print $1 ".." $2 }'`
+ commits=`git log --reverse --format=format:%H $ranges`
+ echo "./tools/checkpatch.sh -g $commits"
+ ./tools/checkpatch.sh -g $commits
+
+ build:
+ needs: check
+ runs-on: ubuntu-18.04
+ container: liuguo09/ubuntu-nuttx:18.04
+
+ strategy:
+ matrix:
+ boards: [sim, mips-riscv-x86, arm-01, arm-02, arm-03, arm-04, arm-05, arm-06, arm-07, arm-08, arm-09, arm-10, arm-11, arm-12, arm-13, arm-14, arm-15]
+
+ steps:
+ - name: Checkout nuttx repo
+ uses: actions/checkout@v2
+ with:
+ path: nuttx
+ fetch-depth: 0
+
+ - name: Fetch nuttx tags
+ run: |
+ cd nuttx
+ git fetch --tags
Review comment:
Why need fetch tag?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services