You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/08/05 10:42:53 UTC
Review Request 24301: Fixed Marvin Issue: Hypervisor value was hardcoded to
XenServer while deploying VM if not specified
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24301/
-----------------------------------------------------------
Review request for cloudstack and Santhosh Edukulla.
Repository: cloudstack-git
Description
-------
Hypervisor value was passed as XenServer by default. Changed this to None as this is not a compulsory parameter. But this caused failures when the parameter value was not passed to the function.
Diffs
-----
tools/marvin/marvin/lib/base.py eb05a18
Diff: https://reviews.apache.org/r/24301/diff/
Testing
-------
Yes.
@summary: Test to Assign and Remove Load Balancer Rule to an Instance ... === TestName: test_07_assign_remove_lbrule_toinstance | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 423.142s
OK
Thanks,
Gaurav Aradhye
Re: Review Request 24301: CLOUDSTACK-7247: Fixed Marvin Issue: Hypervisor
value was hardcoded to XenServer while deploying VM if not specified
Posted by Santhosh Edukulla <sa...@citrix.com>.
> On Aug. 5, 2014, 10:41 a.m., Santhosh Edukulla wrote:
> > Ship It!
dfa607f..2109418 master -> master
- Santhosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24301/#review49582
-----------------------------------------------------------
On Aug. 5, 2014, 10:02 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24301/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 10:02 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7247
> https://issues.apache.org/jira/browse/CLOUDSTACK-7247
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Hypervisor value was passed as XenServer by default. Changed this to None as this is not a compulsory parameter. But this caused failures when the parameter value was not passed to the function.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/lib/base.py eb05a18
>
> Diff: https://reviews.apache.org/r/24301/diff/
>
>
> Testing
> -------
>
> Yes.
>
> @summary: Test to Assign and Remove Load Balancer Rule to an Instance ... === TestName: test_07_assign_remove_lbrule_toinstance | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 423.142s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 24301: CLOUDSTACK-7247: Fixed Marvin Issue: Hypervisor
value was hardcoded to XenServer while deploying VM if not specified
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24301/#review49582
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On Aug. 5, 2014, 10:02 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24301/
> -----------------------------------------------------------
>
> (Updated Aug. 5, 2014, 10:02 a.m.)
>
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7247
> https://issues.apache.org/jira/browse/CLOUDSTACK-7247
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Hypervisor value was passed as XenServer by default. Changed this to None as this is not a compulsory parameter. But this caused failures when the parameter value was not passed to the function.
>
>
> Diffs
> -----
>
> tools/marvin/marvin/lib/base.py eb05a18
>
> Diff: https://reviews.apache.org/r/24301/diff/
>
>
> Testing
> -------
>
> Yes.
>
> @summary: Test to Assign and Remove Load Balancer Rule to an Instance ... === TestName: test_07_assign_remove_lbrule_toinstance | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 423.142s
>
> OK
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 24301: CLOUDSTACK-7247: Fixed Marvin Issue: Hypervisor
value was hardcoded to XenServer while deploying VM if not specified
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24301/
-----------------------------------------------------------
(Updated Aug. 5, 2014, 3:32 p.m.)
Review request for cloudstack and Santhosh Edukulla.
Summary (updated)
-----------------
CLOUDSTACK-7247: Fixed Marvin Issue: Hypervisor value was hardcoded to XenServer while deploying VM if not specified
Bugs: CLOUDSTACK-7247
https://issues.apache.org/jira/browse/CLOUDSTACK-7247
Repository: cloudstack-git
Description
-------
Hypervisor value was passed as XenServer by default. Changed this to None as this is not a compulsory parameter. But this caused failures when the parameter value was not passed to the function.
Diffs
-----
tools/marvin/marvin/lib/base.py eb05a18
Diff: https://reviews.apache.org/r/24301/diff/
Testing
-------
Yes.
@summary: Test to Assign and Remove Load Balancer Rule to an Instance ... === TestName: test_07_assign_remove_lbrule_toinstance | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 423.142s
OK
Thanks,
Gaurav Aradhye