You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/05/07 22:54:48 UTC
[GitHub] [hbase] ndimiduk opened a new pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
ndimiduk opened a new pull request #3243:
URL: https://github.com/apache/hbase/pull/3243
Adapt to the changes provided by apache/hbase-thirdparty#51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#issuecomment-834854538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#issuecomment-839150225
We might also introduce a new shaded jar that is jackson-core, jackson-databind, and jackson-jaxb-annotations. We would then make use of those symbols from the shaded-jackson-jaxrs-json-provider jar, as well as any mentions within hbase-core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#issuecomment-905930993
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 59s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 1s | master passed |
| +1 :green_heart: | compile | 3m 19s | master passed |
| +1 :green_heart: | shadedjars | 9m 8s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 4m 0s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 14s | root in the patch failed. |
| -1 :x: | compile | 0m 12s | root in the patch failed. |
| -0 :warning: | javac | 0m 12s | root in the patch failed. |
| -1 :x: | shadedjars | 0m 15s | patch has 11 errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 13s | root in the patch failed. |
| -0 :warning: | javadoc | 0m 11s | hbase-http in the patch failed. |
| -0 :warning: | javadoc | 0m 9s | hbase-it in the patch failed. |
| -0 :warning: | javadoc | 0m 10s | hbase-rest in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 15s | root in the patch failed. |
| | | 26m 20s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3243 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 4b232a854353 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 735bcf85e9 |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt |
| shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-it.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/testReport/ |
| Max. process+thread count | 126 (vs. ulimit of 30000) |
| modules | C: . hbase-http hbase-it hbase-rest U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#issuecomment-982768893
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 57s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 46s | master passed |
| +1 :green_heart: | compile | 3m 28s | master passed |
| +1 :green_heart: | shadedjars | 10m 54s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 4m 28s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 20s | root in the patch failed. |
| -1 :x: | compile | 0m 17s | root in the patch failed. |
| -0 :warning: | javac | 0m 17s | root in the patch failed. |
| -1 :x: | shadedjars | 0m 19s | patch has 11 errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 16s | root in the patch failed. |
| -0 :warning: | javadoc | 0m 13s | hbase-http in the patch failed. |
| -0 :warning: | javadoc | 0m 13s | hbase-it in the patch failed. |
| -0 :warning: | javadoc | 0m 13s | hbase-rest in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 18s | root in the patch failed. |
| | | 31m 31s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3243 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 0b37938b2b69 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / f1089970cf |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt |
| shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-http.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-it.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-rest.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/testReport/ |
| Max. process+thread count | 117 (vs. ulimit of 30000) |
| modules | C: . hbase-http hbase-it hbase-rest U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#issuecomment-834861687
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 21s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 42s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 51s | master passed |
| +1 :green_heart: | compile | 9m 16s | master passed |
| +1 :green_heart: | checkstyle | 2m 26s | master passed |
| +1 :green_heart: | spotbugs | 13m 4s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 14s | root in the patch failed. |
| -1 :x: | compile | 0m 17s | root in the patch failed. |
| -0 :warning: | javac | 0m 17s | root in the patch failed. |
| -0 :warning: | checkstyle | 0m 9s | The patch fails to run checkstyle in root |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 5s | The patch has no ill-formed XML file. |
| -1 :x: | hadoopcheck | 0m 13s | The patch causes 10 errors with Hadoop v3.1.2. |
| -1 :x: | hadoopcheck | 0m 24s | The patch causes 10 errors with Hadoop v3.2.1. |
| -1 :x: | hadoopcheck | 0m 36s | The patch causes 10 errors with Hadoop v3.3.0. |
| -1 :x: | spotbugs | 0m 17s | root in the patch failed. |
| -1 :x: | spotbugs | 0m 11s | hbase-http in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | hbase-it in the patch failed. |
| -1 :x: | spotbugs | 0m 9s | hbase-rest in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 38s | The patch does not generate ASF License warnings. |
| | | 36m 58s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3243 |
| Optional Tests | dupname asflicense javac hadoopcheck xml compile spotbugs hbaseanti checkstyle |
| uname | Linux 7be6dd91b6ab 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 6cfff27465 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/1/artifact/yetus-general-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/1/artifact/yetus-general-check/output/patch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/1/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/1/artifact/yetus-general-check/output/patch-javac-3.1.2.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/1/artifact/yetus-general-check/output/patch-javac-3.2.1.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/1/artifact/yetus-general-check/output/patch-javac-3.3.0.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/1/artifact/yetus-general-check/output/patch-spotbugs-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-http.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-it.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-rest.txt |
| Max. process+thread count | 126 (vs. ulimit of 30000) |
| modules | C: . hbase-http hbase-it hbase-rest U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/1/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#discussion_r629644198
##########
File path: hbase-rest/pom.xml
##########
@@ -160,7 +151,6 @@
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-protocol-shaded</artifactId>
- <type>jar</type>
Review comment:
Yes, this was redundant.
From [Maven Coordinates](http://maven.apache.org/pom.html#Maven_Coordinates),
> When no packaging is declared, Maven assumes the packaging is the default: jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#issuecomment-982738260
Rebased onto master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#issuecomment-982766004
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 35s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 27s | master passed |
| +1 :green_heart: | compile | 3m 41s | master passed |
| +1 :green_heart: | shadedjars | 9m 32s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 4m 38s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 18s | root in the patch failed. |
| -1 :x: | compile | 0m 16s | root in the patch failed. |
| -0 :warning: | javac | 0m 16s | root in the patch failed. |
| -1 :x: | shadedjars | 0m 18s | patch has 11 errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 15s | root in the patch failed. |
| -0 :warning: | javadoc | 0m 13s | hbase-http in the patch failed. |
| -0 :warning: | javadoc | 0m 12s | hbase-it in the patch failed. |
| -0 :warning: | javadoc | 0m 12s | hbase-rest in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 19s | root in the patch failed. |
| | | 28m 38s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3243 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux c1eca9cf9ba0 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / f1089970cf |
| Default Java | AdoptOpenJDK-11.0.10+9 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-root.txt |
| shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-http.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-it.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/testReport/ |
| Max. process+thread count | 129 (vs. ulimit of 30000) |
| modules | C: . hbase-http hbase-it hbase-rest U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] busbey commented on pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
busbey commented on pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#issuecomment-836730424
to save other folks a click, the failures in the CI bot are due to the SNAPSHOT dependency on hbase-thirdparty needed to test this out locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#issuecomment-1009517794
This is superseded by HBASE-26523.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#issuecomment-985798771
@Apache9 Looks like what you have on #3910 supersedes this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#issuecomment-840900154
I don't think there's a need to shade jackson here because it is only used by hbase-rest, which is not a module that should land in a downstreamer's classpath. Further, we're making use of jackson via transitive dependency on `jackson-jaxrs-json-provider`, a dependency which we do control (as opposed to getting from Hadoop). For these reasons, I see no need to shade jackson here.
I would be in support of a plan to deprecate `jackson-jaxrs-json-provider` and implement our own provided based on our chosen json serialization library, Gson.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#discussion_r629645403
##########
File path: hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java
##########
@@ -18,22 +17,19 @@
*/
package org.apache.hadoop.hbase.rest.model;
+import com.fasterxml.jackson.annotation.JsonInclude;
Review comment:
Nope, because I don't relocate Jackson, just the `jackson-jaxrs-json-provider` and things related specifically to jaxrs. The other PR uses an `includes` list, not excludes, and only relocates the package prefix `com.fasterxml.jackson.jaxrs`. Transitive dependencies of the two artifacts it relocates are preserved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] apurtell commented on a change in pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
apurtell commented on a change in pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#discussion_r629524850
##########
File path: hbase-rest/pom.xml
##########
@@ -160,7 +151,6 @@
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-protocol-shaded</artifactId>
- <type>jar</type>
Review comment:
This was just redundant, right?
##########
File path: hbase-rest/src/main/java/org/apache/hadoop/hbase/rest/model/ScannerModel.java
##########
@@ -18,22 +17,19 @@
*/
package org.apache.hadoop.hbase.rest.model;
+import com.fasterxml.jackson.annotation.JsonInclude;
Review comment:
Should be org.apache.hbase.thirdparty.com.fasterxml.jackson...
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/RowResourceBase.java
##########
@@ -18,22 +18,16 @@
package org.apache.hadoop.hbase.rest;
import static org.junit.Assert.assertEquals;
-
import com.fasterxml.jackson.databind.ObjectMapper;
Review comment:
We aren't shading jackson-databind? Shouldn't we, if we are shading other jackson packages? jackson.databind has been a source of several CVEs so is definitely something we want to control and keep an eye on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#issuecomment-905933955
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 55s | master passed |
| +1 :green_heart: | compile | 8m 24s | master passed |
| +1 :green_heart: | checkstyle | 2m 4s | master passed |
| +1 :green_heart: | spotbugs | 11m 29s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 14s | root in the patch failed. |
| -1 :x: | compile | 0m 17s | root in the patch failed. |
| -0 :warning: | javac | 0m 17s | root in the patch failed. |
| -0 :warning: | checkstyle | 0m 10s | The patch fails to run checkstyle in root |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML file. |
| -1 :x: | hadoopcheck | 0m 11s | The patch causes 10 errors with Hadoop v3.1.2. |
| -1 :x: | hadoopcheck | 0m 23s | The patch causes 10 errors with Hadoop v3.2.1. |
| -1 :x: | hadoopcheck | 0m 34s | The patch causes 10 errors with Hadoop v3.3.0. |
| -1 :x: | spotbugs | 0m 19s | root in the patch failed. |
| -1 :x: | spotbugs | 0m 11s | hbase-http in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | hbase-it in the patch failed. |
| -1 :x: | spotbugs | 0m 11s | hbase-rest in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 41s | The patch does not generate ASF License warnings. |
| | | 32m 27s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3243 |
| Optional Tests | dupname asflicense javac hadoopcheck xml compile spotbugs hbaseanti checkstyle |
| uname | Linux 9135bb94b76b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 735bcf85e9 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-general-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-general-check/output/patch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-general-check/output/patch-javac-3.1.2.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-general-check/output/patch-javac-3.2.1.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-general-check/output/patch-javac-3.3.0.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-general-check/output/patch-spotbugs-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-http.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-it.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-rest.txt |
| Max. process+thread count | 141 (vs. ulimit of 30000) |
| modules | C: . hbase-http hbase-it hbase-rest U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#issuecomment-990242364
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 27s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 26s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 8s | master passed |
| +1 :green_heart: | compile | 9m 0s | master passed |
| +1 :green_heart: | checkstyle | 2m 1s | master passed |
| +1 :green_heart: | spotbugs | 11m 57s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 35s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 52s | the patch passed |
| +1 :green_heart: | compile | 8m 52s | the patch passed |
| +1 :green_heart: | javac | 8m 52s | the patch passed |
| +1 :green_heart: | checkstyle | 2m 2s | root: The patch generated 0 new + 202 unchanged - 16 fixed = 202 total (was 218) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 6s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 21m 31s | Patch does not cause any errors with Hadoop 3.1.2 3.2.2 3.3.1. |
| -1 :x: | spotbugs | 10m 24s | root generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 56s | The patch does not generate ASF License warnings. |
| | | 87m 54s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:root |
| | Possible null pointer dereference in org.apache.hadoop.hbase.coprocessor.MetaTableMetrics$ExampleRegionObserverMeta.opMeterName(Object) due to return value of called method Dereferenced at MetaTableMetrics.java:org.apache.hadoop.hbase.coprocessor.MetaTableMetrics$ExampleRegionObserverMeta.opMeterName(Object) due to return value of called method Dereferenced at MetaTableMetrics.java:[line 230] |
| | Possible null pointer dereference in org.apache.hadoop.hbase.coprocessor.MetaTableMetrics$ExampleRegionObserverMeta.opWithClientMeterName(Object) due to return value of called method Dereferenced at MetaTableMetrics.java:org.apache.hadoop.hbase.coprocessor.MetaTableMetrics$ExampleRegionObserverMeta.opWithClientMeterName(Object) due to return value of called method Dereferenced at MetaTableMetrics.java:[line 210] |
| | Possible null pointer dereference in org.apache.hadoop.hbase.io.hfile.LruCachedBlockQueue.add(LruCachedBlock) due to return value of called method Method invoked at LruCachedBlockQueue.java:org.apache.hadoop.hbase.io.hfile.LruCachedBlockQueue.add(LruCachedBlock) due to return value of called method Method invoked at LruCachedBlockQueue.java:[line 73] |
| | Possible null pointer dereference in org.apache.hadoop.hbase.io.hfile.bucket.CachedEntryQueue.add(Map$Entry) due to return value of called method Dereferenced at CachedEntryQueue.java:org.apache.hadoop.hbase.io.hfile.bucket.CachedEntryQueue.add(Map$Entry) due to return value of called method Dereferenced at CachedEntryQueue.java:[line 79] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/5/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3243 |
| Optional Tests | dupname asflicense javac hadoopcheck xml compile spotbugs hbaseanti checkstyle |
| uname | Linux ae7da42e3ad4 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b5cf3cdc5c |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/5/artifact/yetus-general-check/output/new-spotbugs-root.html |
| Max. process+thread count | 141 (vs. ulimit of 30000) |
| modules | C: hbase-http hbase-it hbase-rest . U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/5/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk closed pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
ndimiduk closed pull request #3243:
URL: https://github.com/apache/hbase/pull/3243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#issuecomment-905932282
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 2m 11s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 26s | master passed |
| +1 :green_heart: | compile | 3m 16s | master passed |
| +1 :green_heart: | shadedjars | 10m 1s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 3m 48s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 18s | root in the patch failed. |
| -1 :x: | compile | 0m 13s | root in the patch failed. |
| -0 :warning: | javac | 0m 13s | root in the patch failed. |
| -1 :x: | shadedjars | 0m 22s | patch has 11 errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 14s | root in the patch failed. |
| -0 :warning: | javadoc | 0m 12s | hbase-http in the patch failed. |
| -0 :warning: | javadoc | 0m 10s | hbase-it in the patch failed. |
| -0 :warning: | javadoc | 0m 10s | hbase-rest in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 15s | root in the patch failed. |
| | | 29m 16s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3243 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux ba6a358db633 4.15.0-143-generic #147-Ubuntu SMP Wed Apr 14 16:10:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 735bcf85e9 |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-root.txt |
| shadedjars | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-root.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-http.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-it.txt |
| javadoc | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk8-hadoop3-check/output/patch-javadoc-hbase-rest.txt |
| unit | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/testReport/ |
| Max. process+thread count | 116 (vs. ulimit of 30000) |
| modules | C: . hbase-http hbase-it hbase-rest U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/2/console |
| versions | git=2.17.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#issuecomment-982778530
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 36s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 28s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 18s | master passed |
| +1 :green_heart: | compile | 11m 54s | master passed |
| +1 :green_heart: | checkstyle | 2m 56s | master passed |
| +1 :green_heart: | spotbugs | 14m 22s | master passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 14s | root in the patch failed. |
| -1 :x: | compile | 0m 17s | root in the patch failed. |
| -0 :warning: | javac | 0m 17s | root in the patch failed. |
| -0 :warning: | checkstyle | 0m 9s | The patch fails to run checkstyle in root |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 5s | The patch has no ill-formed XML file. |
| -1 :x: | hadoopcheck | 0m 12s | The patch causes 10 errors with Hadoop v3.1.2. |
| -1 :x: | hadoopcheck | 0m 23s | The patch causes 10 errors with Hadoop v3.2.2. |
| -1 :x: | hadoopcheck | 0m 34s | The patch causes 10 errors with Hadoop v3.3.1. |
| -1 :x: | spotbugs | 0m 17s | root in the patch failed. |
| -1 :x: | spotbugs | 0m 10s | hbase-http in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | hbase-it in the patch failed. |
| -1 :x: | spotbugs | 0m 10s | hbase-rest in the patch failed. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. |
| | | 42m 0s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/3243 |
| Optional Tests | dupname asflicense javac hadoopcheck xml compile spotbugs hbaseanti checkstyle |
| uname | Linux a119833c7cab 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / f1089970cf |
| Default Java | AdoptOpenJDK-1.8.0_282-b08 |
| mvninstall | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-general-check/output/patch-mvninstall-root.txt |
| compile | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-general-check/output/patch-compile-root.txt |
| javac | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-general-check/output/patch-compile-root.txt |
| checkstyle | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-general-check/output/patch-javac-3.1.2.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-general-check/output/patch-javac-3.2.2.txt |
| hadoopcheck | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-general-check/output/patch-javac-3.3.1.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-general-check/output/patch-spotbugs-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-general-check/output/patch-spotbugs-hbase-http.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-general-check/output/patch-spotbugs-hbase-it.txt |
| spotbugs | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/artifact/yetus-general-check/output/patch-spotbugs-hbase-rest.txt |
| Max. process+thread count | 126 (vs. ulimit of 30000) |
| modules | C: . hbase-http hbase-it hbase-rest U: . |
| Console output | https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3243/3/console |
| versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#issuecomment-839085013
@apurtell how would you like this change to proceed? Would you prefer that we also shade all of jackson within the `hbase-shaded-jackson-jaxrs-json-provider` module? For your reference,
`mvn dependency:tree` of the new module:
```
[INFO] +- org.apache.hbase.thirdparty:hbase-shaded-jackson-jaxrs-json-provider:jar:3.5.1-SNAPSHOT:compile
[INFO] | +- com.fasterxml.jackson.module:jackson-module-jaxb-annotations:jar:2.10.1:compile
[INFO] | +- jakarta.xml.bind:jakarta.xml.bind-api:jar:2.3.2:compile
[INFO] | \- jakarta.activation:jakarta.activation-api:jar:1.2.1:compile
```
Dependency list from the dependency-reduced-pom.xml
```
<dependencies>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>2.10.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>2.10.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.module</groupId>
<artifactId>jackson-module-jaxb-annotations</artifactId>
<version>2.10.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-annotations</artifactId>
<version>2.10.1</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>jakarta.xml.bind</groupId>
<artifactId>jakarta.xml.bind-api</artifactId>
<version>2.3.2</version>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>jakarta.activation</groupId>
<artifactId>jakarta.activation-api</artifactId>
<version>1.2.1</version>
<scope>compile</scope>
</dependency>
</dependencies>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #3243: HBASE-25864 Use shaded javax.ws.rs package classes
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #3243:
URL: https://github.com/apache/hbase/pull/3243#discussion_r629645829
##########
File path: hbase-rest/src/test/java/org/apache/hadoop/hbase/rest/RowResourceBase.java
##########
@@ -18,22 +18,16 @@
package org.apache.hadoop.hbase.rest;
import static org.junit.Assert.assertEquals;
-
import com.fasterxml.jackson.databind.ObjectMapper;
Review comment:
See above -- it seems we do not currently shade jackson-databind and the patch as posted does not do so either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org