You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/13 15:32:35 UTC

[GitHub] [arrow-datafusion] mingmwang commented on pull request #4193: Support normal expressions in equality join

mingmwang commented on PR #4193:
URL: https://github.com/apache/arrow-datafusion/pull/4193#issuecomment-1312757612

   What's the difference between `extract_join_keys() `and  `extract_possible_join_keys()`?
   Not sure whether the two methods can be combined or not.
   From my understanding, I think the extract process should be
   1. Convert the expr/predicate to CNF (I think we already had the utils)
   2. Split the CNF to Vec of expr/predicate (I think we already had the utils)
   3. For each expr in the split exprs, check if is a BinaryExpr with Operator::Eq and the left and right are coming from different input schemas.
   
   @alamb @jackwener 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org