You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/29 15:25:21 UTC
[GitHub] [camel-k] essobedo opened a new pull request, #3585: test: Add an E2E test for deploying an it using secret key filtering
essobedo opened a new pull request, #3585:
URL: https://github.com/apache/camel-k/pull/3585
fixes #3563
## Motivation
An E2E was missing in https://github.com/apache/camel-k/pull/3544 and had to be added in a different PR
## Modifications
* Define a secret with multi values
* Add a new ECE test based on https://camel.apache.org/camel-k/next/configuration/runtime-config.html#runtime-config-keys
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on pull request #3585: test: Add an E2E test for deploying an it using secret key filtering
Posted by GitBox <gi...@apache.org>.
tadayosi commented on PR #3585:
URL: https://github.com/apache/camel-k/pull/3585#issuecomment-1231314261
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi commented on a diff in pull request #3585: test: Add an E2E test for deploying an it using secret key filtering
Posted by GitBox <gi...@apache.org>.
tadayosi commented on code in PR #3585:
URL: https://github.com/apache/camel-k/pull/3585#discussion_r957987048
##########
e2e/global/common/config/config_test.go:
##########
@@ -167,6 +173,15 @@ func TestRunConfigExamples(t *testing.T) {
Eventually(AutogeneratedConfigmapsCount(ns), TestTimeoutShort).Should(Equal(0))
})
+ t.Run("Secret with filtered key", func(t *testing.T) {
+ Expect(KamelRunWithID(operatorID, ns, "./files/config-secret-key-route.groovy", "--config", "secret:my-sec-multi/my-secret-key-2").Execute()).To(Succeed())
+ Eventually(IntegrationPodPhase(ns, "config-secret-key-route"), TestTimeoutLong).Should(Equal(corev1.PodRunning))
+ Eventually(IntegrationConditionStatus(ns, "config-secret-key-route", v1.IntegrationConditionReady), TestTimeoutShort).Should(Equal(corev1.ConditionTrue))
+ Eventually(IntegrationLogs(ns, "config-secret-key-route"), TestTimeoutShort).ShouldNot(ContainSubstring(cmDataMulti["my-secret-key"]))
+ Eventually(IntegrationLogs(ns, "config-secret-key-route"), TestTimeoutShort).Should(ContainSubstring(cmDataMulti["my-secret-key-2"]))
Review Comment:
These should really use `secDataMulti` not `cmDataMulti`, that's why the test is failing. Please fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] essobedo commented on a diff in pull request #3585: test: Add an E2E test for deploying an it using secret key filtering
Posted by GitBox <gi...@apache.org>.
essobedo commented on code in PR #3585:
URL: https://github.com/apache/camel-k/pull/3585#discussion_r958037078
##########
e2e/global/common/config/config_test.go:
##########
@@ -167,6 +173,15 @@ func TestRunConfigExamples(t *testing.T) {
Eventually(AutogeneratedConfigmapsCount(ns), TestTimeoutShort).Should(Equal(0))
})
+ t.Run("Secret with filtered key", func(t *testing.T) {
+ Expect(KamelRunWithID(operatorID, ns, "./files/config-secret-key-route.groovy", "--config", "secret:my-sec-multi/my-secret-key-2").Execute()).To(Succeed())
+ Eventually(IntegrationPodPhase(ns, "config-secret-key-route"), TestTimeoutLong).Should(Equal(corev1.PodRunning))
+ Eventually(IntegrationConditionStatus(ns, "config-secret-key-route", v1.IntegrationConditionReady), TestTimeoutShort).Should(Equal(corev1.ConditionTrue))
+ Eventually(IntegrationLogs(ns, "config-secret-key-route"), TestTimeoutShort).ShouldNot(ContainSubstring(cmDataMulti["my-secret-key"]))
+ Eventually(IntegrationLogs(ns, "config-secret-key-route"), TestTimeoutShort).Should(ContainSubstring(cmDataMulti["my-secret-key-2"]))
Review Comment:
My bad, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] tadayosi merged pull request #3585: test: Add an E2E test for deploying an it using secret key filtering
Posted by GitBox <gi...@apache.org>.
tadayosi merged PR #3585:
URL: https://github.com/apache/camel-k/pull/3585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] essobedo commented on pull request #3585: test: Add an E2E test for deploying an it using secret key filtering
Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #3585:
URL: https://github.com/apache/camel-k/pull/3585#issuecomment-1231308077
The added test passes https://github.com/apache/camel-k/runs/8085498798?check_suite_focus=true#step:4:4527
The failing tests are known:
* FAIL: TestKameletBinding/test_error_handler/throw_error_test
* FAIL: TestBindingWithImage/run_with_initial_image
* FAIL: TestErrorHandlerTrait/Run_errored_integration_with_error_handler
* FAIL: TestNativeIntegrations/automatic_rollout_deployment_from_fast-jar_to_native_kit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org