You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/07/06 18:34:50 UTC
[kudu-CR] leader election-test: add some std::move calls during constructors
Hello Mike Percy, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10883
to review the following change.
Change subject: leader_election-test: add some std::move calls during constructors
......................................................................
leader_election-test: add some std::move calls during constructors
Forgot to do this in the commit that made these pass-by-value.
Change-Id: I654077c74695d984dc0c28102c005ec56318b7e5
---
M src/kudu/consensus/leader_election-test.cc
1 file changed, 8 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/10883/1
--
To view, visit http://gerrit.cloudera.org:8080/10883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I654077c74695d984dc0c28102c005ec56318b7e5
Gerrit-Change-Number: 10883
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] leader election-test: add some std::move calls during constructors
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10883 )
Change subject: leader_election-test: add some std::move calls during constructors
......................................................................
leader_election-test: add some std::move calls during constructors
Forgot to do this in the commit that made these pass-by-value.
Change-Id: I654077c74695d984dc0c28102c005ec56318b7e5
Reviewed-on: http://gerrit.cloudera.org:8080/10883
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/consensus/leader_election-test.cc
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I654077c74695d984dc0c28102c005ec56318b7e5
Gerrit-Change-Number: 10883
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] leader election-test: add some std::move calls during constructors
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10883 )
Change subject: leader_election-test: add some std::move calls during constructors
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10883
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I654077c74695d984dc0c28102c005ec56318b7e5
Gerrit-Change-Number: 10883
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 06 Jul 2018 18:43:01 +0000
Gerrit-HasComments: No