You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/06 11:52:57 UTC
[GitHub] [incubator-doris] xinghuayu007 commented on a change in pull request #4247: Unified the grammer style of create/drop bitmap and bloomfilter index
xinghuayu007 commented on a change in pull request #4247:
URL: https://github.com/apache/incubator-doris/pull/4247#discussion_r466357890
##########
File path: fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
##########
@@ -1438,9 +1758,20 @@ public void process(List<AlterClause> alterClauses, String clusterName, Database
// modify table properties
// do nothing, properties are already in propertyMap
} else if (alterClause instanceof CreateIndexClause) {
- processAddIndex((CreateIndexClause) alterClause, olapTable, newIndexes);
+ CreateIndexClause clause = (CreateIndexClause) alterClause;
+ processAddIndex(clause, olapTable, newIndexes);
+ if (clause.getIndexDef().getIndexType() == IndexDef.IndexType.BLOOMFILTER) {
+ createBfJob(db.getId(), olapTable, indexSchemaMap, propertyMap, newIndexes, false);
+ return;
+ }
} else if (alterClause instanceof DropIndexClause) {
- processDropIndex((DropIndexClause) alterClause, olapTable, newIndexes);
+ DropIndexClause clause = (DropIndexClause) alterClause;
+ if (getIndexTypeByName(clause, olapTable) == IndexDef.IndexType.BLOOMFILTER) {
+ createBfJob(db.getId(), olapTable, indexSchemaMap, propertyMap, newIndexes, true);
Review comment:
createBfJob is a new Function that responsible for bloomfilter index create/drop
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org