You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/10/22 21:57:54 UTC

[GitHub] [incubator-gobblin] jack-moseley commented on a change in pull request #3135: [GOBBLIN-1297] Register/unregister eventbus with dagManager on leadership change

jack-moseley commented on a change in pull request #3135:
URL: https://github.com/apache/incubator-gobblin/pull/3135#discussion_r510481739



##########
File path: gobblin-service/src/test/java/org/apache/gobblin/service/modules/core/GobblinServiceHATest.java
##########
@@ -546,6 +551,30 @@ public void testKillNode() throws Exception {
 
     Assert.assertTrue(assertSuccess, "New master should take over all old master jobs.");
 
+    // Check eventbus was registered with new leader
+    attempt = 0;
+    assertSuccess = false;
+    while (attempt < 10) {

Review comment:
       How would you use AssertWithBackoff for a method that is throwing an exception instead of returning true/false? I guess only way is to wrap it in another method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org