You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by ga...@apache.org on 2007/10/12 17:55:34 UTC
svn commit: r584194 - in /geronimo/server/trunk:
modules/geronimo-openejb/src/main/resources/META-INF/geronimo-dependency.xml
pom.xml
Author: gawor
Date: Fri Oct 12 08:55:29 2007
New Revision: 584194
URL: http://svn.apache.org/viewvc?rev=584194&view=rev
Log:
openejb now needs commons-dbcp dependency (GERONIMO-3531)
Modified:
geronimo/server/trunk/modules/geronimo-openejb/src/main/resources/META-INF/geronimo-dependency.xml
geronimo/server/trunk/pom.xml
Modified: geronimo/server/trunk/modules/geronimo-openejb/src/main/resources/META-INF/geronimo-dependency.xml
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/geronimo-openejb/src/main/resources/META-INF/geronimo-dependency.xml?rev=584194&r1=584193&r2=584194&view=diff
==============================================================================
--- geronimo/server/trunk/modules/geronimo-openejb/src/main/resources/META-INF/geronimo-dependency.xml (original)
+++ geronimo/server/trunk/modules/geronimo-openejb/src/main/resources/META-INF/geronimo-dependency.xml Fri Oct 12 08:55:29 2007
@@ -63,4 +63,8 @@
<groupId>asm</groupId>
<artifactId>asm-commons</artifactId>
</dependency>
+ <dependency>
+ <groupId>commons-dbcp</groupId>
+ <artifactId>commons-dbcp</artifactId>
+ </dependency>
</service>
Modified: geronimo/server/trunk/pom.xml
URL: http://svn.apache.org/viewvc/geronimo/server/trunk/pom.xml?rev=584194&r1=584193&r2=584194&view=diff
==============================================================================
--- geronimo/server/trunk/pom.xml (original)
+++ geronimo/server/trunk/pom.xml Fri Oct 12 08:55:29 2007
@@ -443,6 +443,12 @@
</dependency>
<dependency>
+ <groupId>commons-dbcp</groupId>
+ <artifactId>commons-dbcp</artifactId>
+ <version>1.3-SNAPSHOT</version>
+ </dependency>
+
+ <dependency>
<groupId>org.objectweb.howl</groupId>
<artifactId>howl</artifactId>
<version>1.0.1-1</version>
Re: svn commit: r584194 - in /geronimo/server/trunk: modules/geronimo-openejb/src/main/resources/META-INF/geronimo-dependency.xml pom.xml
Posted by Jarek Gawor <jg...@gmail.com>.
David,
I did investigate it. But maybe there is a better solution. Here's the
change in OpenEJB:
http://svn.apache.org/viewvc/openejb/trunk/openejb3/server/openejb-ejbd/src/main/java/org/apache/openejb/server/ejbd/JndiRequestHandler.java?r1=570629&r2=581127
Jarek
On 10/12/07, David Jencks <da...@yahoo.com> wrote:
> Could we investigate this more and remove the dependency? I really
> doubt we should need to pull this in.
>
> thanks
> david jencks
>
> On Oct 12, 2007, at 8:55 AM, gawor@apache.org wrote:
>
> > Author: gawor
> > Date: Fri Oct 12 08:55:29 2007
> > New Revision: 584194
> >
> > URL: http://svn.apache.org/viewvc?rev=584194&view=rev
> > Log:
> > openejb now needs commons-dbcp dependency (GERONIMO-3531)
> >
> > Modified:
> > geronimo/server/trunk/modules/geronimo-openejb/src/main/
> > resources/META-INF/geronimo-dependency.xml
> > geronimo/server/trunk/pom.xml
> >
> > Modified: geronimo/server/trunk/modules/geronimo-openejb/src/main/
> > resources/META-INF/geronimo-dependency.xml
> > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
> > geronimo-openejb/src/main/resources/META-INF/geronimo-
> > dependency.xml?rev=584194&r1=584193&r2=584194&view=diff
> > ======================================================================
> > ========
> > --- geronimo/server/trunk/modules/geronimo-openejb/src/main/
> > resources/META-INF/geronimo-dependency.xml (original)
> > +++ geronimo/server/trunk/modules/geronimo-openejb/src/main/
> > resources/META-INF/geronimo-dependency.xml Fri Oct 12 08:55:29 2007
> > @@ -63,4 +63,8 @@
> > <groupId>asm</groupId>
> > <artifactId>asm-commons</artifactId>
> > </dependency>
> > + <dependency>
> > + <groupId>commons-dbcp</groupId>
> > + <artifactId>commons-dbcp</artifactId>
> > + </dependency>
> > </service>
> >
> > Modified: geronimo/server/trunk/pom.xml
> > URL: http://svn.apache.org/viewvc/geronimo/server/trunk/pom.xml?
> > rev=584194&r1=584193&r2=584194&view=diff
> > ======================================================================
> > ========
> > --- geronimo/server/trunk/pom.xml (original)
> > +++ geronimo/server/trunk/pom.xml Fri Oct 12 08:55:29 2007
> > @@ -443,6 +443,12 @@
> > </dependency>
> >
> > <dependency>
> > + <groupId>commons-dbcp</groupId>
> > + <artifactId>commons-dbcp</artifactId>
> > + <version>1.3-SNAPSHOT</version>
> > + </dependency>
> > +
> > + <dependency>
> > <groupId>org.objectweb.howl</groupId>
> > <artifactId>howl</artifactId>
> > <version>1.0.1-1</version>
> >
> >
>
>
Re: svn commit: r584194 - in /geronimo/server/trunk: modules/geronimo-openejb/src/main/resources/META-INF/geronimo-dependency.xml pom.xml
Posted by David Jencks <da...@yahoo.com>.
Could we investigate this more and remove the dependency? I really
doubt we should need to pull this in.
thanks
david jencks
On Oct 12, 2007, at 8:55 AM, gawor@apache.org wrote:
> Author: gawor
> Date: Fri Oct 12 08:55:29 2007
> New Revision: 584194
>
> URL: http://svn.apache.org/viewvc?rev=584194&view=rev
> Log:
> openejb now needs commons-dbcp dependency (GERONIMO-3531)
>
> Modified:
> geronimo/server/trunk/modules/geronimo-openejb/src/main/
> resources/META-INF/geronimo-dependency.xml
> geronimo/server/trunk/pom.xml
>
> Modified: geronimo/server/trunk/modules/geronimo-openejb/src/main/
> resources/META-INF/geronimo-dependency.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/modules/
> geronimo-openejb/src/main/resources/META-INF/geronimo-
> dependency.xml?rev=584194&r1=584193&r2=584194&view=diff
> ======================================================================
> ========
> --- geronimo/server/trunk/modules/geronimo-openejb/src/main/
> resources/META-INF/geronimo-dependency.xml (original)
> +++ geronimo/server/trunk/modules/geronimo-openejb/src/main/
> resources/META-INF/geronimo-dependency.xml Fri Oct 12 08:55:29 2007
> @@ -63,4 +63,8 @@
> <groupId>asm</groupId>
> <artifactId>asm-commons</artifactId>
> </dependency>
> + <dependency>
> + <groupId>commons-dbcp</groupId>
> + <artifactId>commons-dbcp</artifactId>
> + </dependency>
> </service>
>
> Modified: geronimo/server/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/geronimo/server/trunk/pom.xml?
> rev=584194&r1=584193&r2=584194&view=diff
> ======================================================================
> ========
> --- geronimo/server/trunk/pom.xml (original)
> +++ geronimo/server/trunk/pom.xml Fri Oct 12 08:55:29 2007
> @@ -443,6 +443,12 @@
> </dependency>
>
> <dependency>
> + <groupId>commons-dbcp</groupId>
> + <artifactId>commons-dbcp</artifactId>
> + <version>1.3-SNAPSHOT</version>
> + </dependency>
> +
> + <dependency>
> <groupId>org.objectweb.howl</groupId>
> <artifactId>howl</artifactId>
> <version>1.0.1-1</version>
>
>