You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yao Xu (Code Review)" <ge...@cloudera.org> on 2019/07/11 08:23:31 UTC
[kudu-CR] KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
Yao Xu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13842
Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
......................................................................
KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
Fix the issue of out-of-bounds memory access caused by invalid read and write default values.
Change-Id: I434f2aac49402af4f29956ab20bba352dc719eeb
---
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
M src/kudu/master/catalog_manager.cc
M src/kudu/tserver/tablet_service.cc
5 files changed, 98 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/13842/1
--
To view, visit http://gerrit.cloudera.org:8080/13842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I434f2aac49402af4f29956ab20bba352dc719eeb
Gerrit-Change-Number: 13842
Gerrit-PatchSet: 1
Gerrit-Owner: Yao Xu <oc...@gmail.com>
[kudu-CR] KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13842 )
Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13842/2/src/kudu/common/wire_protocol.h
File src/kudu/common/wire_protocol.h:
http://gerrit.cloudera.org:8080/#/c/13842/2/src/kudu/common/wire_protocol.h@116
PS2, Line 116: boost::optional<ColumnSchema>
> > Don't think you need the boost::optional wrapping; just pass
Ah yeah I see. And it'd be pretty unnatural to support a default constructor (i.e. ColumnSchema would have to be way more mutable than it is right now).
--
To view, visit http://gerrit.cloudera.org:8080/13842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I434f2aac49402af4f29956ab20bba352dc719eeb
Gerrit-Change-Number: 13842
Gerrit-PatchSet: 2
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Comment-Date: Mon, 15 Jul 2019 21:51:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13842 )
Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
......................................................................
Patch Set 1:
Emmm, I’m not sure that I should add some invalid read/write default cases for AlterTable or Scan.
--
To view, visit http://gerrit.cloudera.org:8080/13842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I434f2aac49402af4f29956ab20bba352dc719eeb
Gerrit-Change-Number: 13842
Gerrit-PatchSet: 1
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Jul 2019 08:32:14 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13842
to look at the new patch set (#2).
Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
......................................................................
KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
Fix the issue of out-of-bounds memory access caused by invalid read and write default values.
Change-Id: I434f2aac49402af4f29956ab20bba352dc719eeb
---
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
M src/kudu/master/catalog_manager.cc
M src/kudu/tserver/tablet_service.cc
5 files changed, 98 insertions(+), 46 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/13842/2
--
To view, visit http://gerrit.cloudera.org:8080/13842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I434f2aac49402af4f29956ab20bba352dc719eeb
Gerrit-Change-Number: 13842
Gerrit-PatchSet: 2
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
[kudu-CR] KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
Posted by "Yao Xu (Code Review)" <ge...@cloudera.org>.
Yao Xu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13842 )
Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13842/2/src/kudu/common/wire_protocol.h
File src/kudu/common/wire_protocol.h:
http://gerrit.cloudera.org:8080/#/c/13842/2/src/kudu/common/wire_protocol.h@116
PS2, Line 116: boost::optional<ColumnSchema>
> Don't think you need the boost::optional wrapping; just pass
> ColumnSchema by pointer.
Emmm, ColumnSchema doesn't have the default constructor, so I think the optional wrapper is a good choice. :)
--
To view, visit http://gerrit.cloudera.org:8080/13842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I434f2aac49402af4f29956ab20bba352dc719eeb
Gerrit-Change-Number: 13842
Gerrit-PatchSet: 2
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Comment-Date: Sat, 13 Jul 2019 02:19:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13842 )
Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
......................................................................
KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
Fix the issue of out-of-bounds memory access caused by invalid read and write default values.
Change-Id: I434f2aac49402af4f29956ab20bba352dc719eeb
Reviewed-on: http://gerrit.cloudera.org:8080/13842
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
M src/kudu/master/catalog_manager.cc
M src/kudu/tserver/tablet_service.cc
5 files changed, 98 insertions(+), 46 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I434f2aac49402af4f29956ab20bba352dc719eeb
Gerrit-Change-Number: 13842
Gerrit-PatchSet: 3
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
[kudu-CR] KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13842 )
Change subject: KUDU-2622 Validate read and write default value sizes when deserializing ColumnSchemaPB
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13842/2/src/kudu/common/wire_protocol.h
File src/kudu/common/wire_protocol.h:
http://gerrit.cloudera.org:8080/#/c/13842/2/src/kudu/common/wire_protocol.h@116
PS2, Line 116: boost::optional<ColumnSchema>
Don't think you need the boost::optional wrapping; just pass ColumnSchema by pointer.
--
To view, visit http://gerrit.cloudera.org:8080/13842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I434f2aac49402af4f29956ab20bba352dc719eeb
Gerrit-Change-Number: 13842
Gerrit-PatchSet: 2
Gerrit-Owner: Yao Xu <oc...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yao Xu <oc...@gmail.com>
Gerrit-Comment-Date: Fri, 12 Jul 2019 21:16:05 +0000
Gerrit-HasComments: Yes