You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "B. Todd Burruss (JIRA)" <ji...@apache.org> on 2010/09/16 05:05:32 UTC

[jira] Created: (CASSANDRA-1509) CassandraServiceDataCleaner doesn't remove subdirectories properly

CassandraServiceDataCleaner doesn't remove subdirectories properly
------------------------------------------------------------------

                 Key: CASSANDRA-1509
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1509
             Project: Cassandra
          Issue Type: Bug
    Affects Versions: 0.7 beta 1
            Reporter: B. Todd Burruss


CassandraServiceDataCleaner.cleanDir assumes all files in the directory are normal files, not directories.  Suggested fix is to change FileUtils.delete(dirFile.listFiles()) to FileUtils.deleteRecursive(f) to remove recursively which will delete all data files.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-1509) CassandraServiceDataCleaner doesn't remove subdirectories properly

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12911009#action_12911009 ] 

Hudson commented on CASSANDRA-1509:
-----------------------------------

Integrated in Cassandra #539 (See [https://hudson.apache.org/hudson/job/Cassandra/539/])
    make contrib CassandraServiceDataCleaner recursive.  patch by B. Todd Burruss; reviewed by jbellis for CASSANDRA-1509


> CassandraServiceDataCleaner doesn't remove subdirectories properly
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-1509
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1509
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Contrib
>    Affects Versions: 0.6
>            Reporter: B. Todd Burruss
>            Assignee: B. Todd Burruss
>            Priority: Trivial
>             Fix For: 0.7 beta 2
>
>         Attachments: patch-delete-recursive.txt
>
>
> CassandraServiceDataCleaner.cleanDir assumes all files in the directory are normal files, not directories.  Suggested fix is to change FileUtils.delete(dirFile.listFiles()) to FileUtils.deleteRecursive(f) to remove recursively which will delete all data files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1509) CassandraServiceDataCleaner doesn't remove subdirectories properly

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-1509:
--------------------------------------

    Affects Version/s: 0.6
                           (was: 0.7 beta 1)
             Priority: Trivial  (was: Major)
          Component/s: Contrib
             Reviewer: jbellis  (was: gdusbabek)

> CassandraServiceDataCleaner doesn't remove subdirectories properly
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-1509
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1509
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Contrib
>    Affects Versions: 0.6
>            Reporter: B. Todd Burruss
>            Assignee: B. Todd Burruss
>            Priority: Trivial
>             Fix For: 0.7 beta 2
>
>         Attachments: patch-delete-recursive.txt
>
>
> CassandraServiceDataCleaner.cleanDir assumes all files in the directory are normal files, not directories.  Suggested fix is to change FileUtils.delete(dirFile.listFiles()) to FileUtils.deleteRecursive(f) to remove recursively which will delete all data files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1509) CassandraServiceDataCleaner doesn't remove subdirectories properly

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-1509:
--------------------------------------

    Fix Version/s: 0.7 beta 2
         Reviewer: gdusbabek

> CassandraServiceDataCleaner doesn't remove subdirectories properly
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-1509
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1509
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7 beta 1
>            Reporter: B. Todd Burruss
>             Fix For: 0.7 beta 2
>
>         Attachments: patch-delete-recursive.txt
>
>
> CassandraServiceDataCleaner.cleanDir assumes all files in the directory are normal files, not directories.  Suggested fix is to change FileUtils.delete(dirFile.listFiles()) to FileUtils.deleteRecursive(f) to remove recursively which will delete all data files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-1509) CassandraServiceDataCleaner doesn't remove subdirectories properly

Posted by "B. Todd Burruss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-1509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

B. Todd Burruss updated CASSANDRA-1509:
---------------------------------------

    Attachment: patch-delete-recursive.txt

patch to change to a recursive delete which will remove directories and all their files

> CassandraServiceDataCleaner doesn't remove subdirectories properly
> ------------------------------------------------------------------
>
>                 Key: CASSANDRA-1509
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1509
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.7 beta 1
>            Reporter: B. Todd Burruss
>         Attachments: patch-delete-recursive.txt
>
>
> CassandraServiceDataCleaner.cleanDir assumes all files in the directory are normal files, not directories.  Suggested fix is to change FileUtils.delete(dirFile.listFiles()) to FileUtils.deleteRecursive(f) to remove recursively which will delete all data files.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.