You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/20 22:27:01 UTC
[GitHub] [beam] damondouglas opened a new pull request, #21953: Implement PubsubSchemaTransformMessageToRowFactory
damondouglas opened a new pull request, #21953:
URL: https://github.com/apache/beam/pull/21953
This PR addresses #21412 by producing a [PubsubTransformToRow](https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubMessageToRow.java) from a [PubsubSchemaTransformReadConfiguration](https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubSchemaTransformReadConfiguration.java).
The design goals of `PubsubSchemaTransformMessageToRowFactory` in this PR are to replicate logic in the existing [PubsubSchemaIOProvider](https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubSchemaIOProvider.java) and provide readability on a future PR that commits a `PubsubSchemaTransformReadProvider`.
I would like to request the following to review this PR:
R: @pabloem
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- ~Update `CHANGES.md` with noteworthy changes.~
- ~If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).~
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #21953: Implement PubsubSchemaTransformMessageToRowFactory
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #21953:
URL: https://github.com/apache/beam/pull/21953#issuecomment-1165570815
Precommit fails due to checkStyle warnings in this commit
https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/5594/checkstyle/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21953: Implement PubsubSchemaTransformMessageToRowFactory
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21953:
URL: https://github.com/apache/beam/pull/21953#issuecomment-1160886575
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #21953: Implement PubsubSchemaTransformMessageToRowFactory
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #21953:
URL: https://github.com/apache/beam/pull/21953#issuecomment-1165012240
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21953: Implement PubsubSchemaTransformMessageToRowFactory
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21953:
URL: https://github.com/apache/beam/pull/21953#issuecomment-1160886571
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on pull request #21953: Implement PubsubSchemaTransformMessageToRowFactory
Posted by GitBox <gi...@apache.org>.
damondouglas commented on PR #21953:
URL: https://github.com/apache/beam/pull/21953#issuecomment-1162078151
@pabloem The PR is ready for your review. FYI the failing [org.apache.beam.sdk.io.gcp.bigquery.BigQueryServicesImplTest.testInsertWithinRowCountLimits](https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/23066/testReport/junit/org.apache.beam.sdk.io.gcp.bigquery/BigQueryServicesImplTest/testInsertWithinRowCountLimits/) has nothing to do with the code in this PR.
```
java.lang.RuntimeException: java.lang.IllegalArgumentException: no JSON input found
at org.apache.beam.sdk.io.gcp.bigquery.BigQueryServicesImpl$DatasetServiceImpl.insertAll(BigQueryServicesImpl.java:1189)
at org.apache.beam.sdk.io.gcp.bigquery.BigQueryServicesImplTest.testInsertWithinRowCountLimits(BigQueryServicesImplTest.java:898)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21953: Implement PubsubSchemaTransformMessageToRowFactory
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21953:
URL: https://github.com/apache/beam/pull/21953#issuecomment-1160886578
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #21953: Implement PubsubSchemaTransformMessageToRowFactory
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #21953:
URL: https://github.com/apache/beam/pull/21953#issuecomment-1160886576
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #21953: Implement PubsubSchemaTransformMessageToRowFactory
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #21953:
URL: https://github.com/apache/beam/pull/21953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org