[GitHub] [kafka] lbradstreet commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

[GitBox <gi...@apache.org>]

lbradstreet commented on a change in pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#discussion_r538522173



##########
File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java
##########
@@ -164,4 +206,28 @@ public void testAclsIterator() {
     public void testAuthorizer() {
         aclAuthorizer.authorize(context, actions);
     }
+
+    @Benchmark
+    public void testAuthorizeByResourceType() {
+        aclAuthorizer.authorizeByResourceType(context, AclOperation.WRITE, ResourceType.TOPIC);
+    }
+
+    @Benchmark
+    public void testUpdateCache() {
+        AclAuthorizer aclAuthorizer = new AclAuthorizer();
+        scala.collection.mutable.Set<AclEntry> entries = new scala.collection.mutable.HashSet<>();
+        for (int i = 0; i < resourceCount; i ++){

Review comment:
       nit, unnecessary whitespace in `i++`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org