[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4157: Collapse statistics in normal explain plan

[GitBox <gi...@apache.org>]

alamb commented on code in PR #4157:
URL: https://github.com/apache/arrow-datafusion/pull/4157#discussion_r1018410829


##########
datafusion/core/src/physical_plan/metrics/mod.rs:
##########
@@ -140,7 +140,7 @@ impl Metric {
     }
 
     /// Add a new label to this metric
-    pub fn with(mut self, label: Label) -> Self {
+    pub fn with_label(mut self, label: Label) -> Self {

Review Comment:
   Drive by cleanup to make the setter conform to standard `with_` naming



##########
datafusion/core/src/physical_plan/metrics/mod.rs:
##########
@@ -259,27 +259,23 @@ impl MetricsSet {
     }
 
     /// Returns returns a new derived `MetricsSet` where all metrics
-    /// that had the same name and partition=`Some(..)` have been
+    /// that had the same name have been
     /// aggregated together. The resulting `MetricsSet` has all
     /// metrics with `Partition=None`
-    pub fn aggregate_by_partition(&self) -> Self {
+    pub fn aggregate_by_name(&self) -> Self {

Review Comment:
   This is the core change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org