You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/10/03 17:49:02 UTC
[kudu-CR] Build cleanup in preperation for release
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11576
Change subject: Build cleanup in preperation for release
......................................................................
Build cleanup in preperation for release
This patch is a few small fixes in preparation for release:
- Updates the releasing docs to use Gradle
- Updates the hive and backup modules to skip the
javadoc task. They don’t have public javadoc to publish.
- Updates the backup module to ensure it’s not published.
- Fixes Gradle pom generation to included unshaded deps.
- Fixes the Gradle signing logic.
This work was validated by walking through the release steps
for both Maven and Gradle. I staged the artifacts from both
builds and compared them.
Change-Id: I50c3b9358896b264fd525de558b6be7ef77145e2
---
M RELEASING.adoc
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-backup/build.gradle
M java/kudu-backup/pom.xml
M java/kudu-hive/pom.xml
6 files changed, 47 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/11576/1
--
To view, visit http://gerrit.cloudera.org:8080/11576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50c3b9358896b264fd525de558b6be7ef77145e2
Gerrit-Change-Number: 11576
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] Build cleanup in preperation for release
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Attila Bukor, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11576
to look at the new patch set (#4).
Change subject: Build cleanup in preperation for release
......................................................................
Build cleanup in preperation for release
This patch is a few small fixes in preparation for release:
- Updates the releasing docs to use Gradle
- Updates the hive and backup modules to skip the
javadoc task. They don’t have public javadoc to publish.
- Updates the backup module to ensure it’s not published.
- Fixes Gradle pom generation to included unshaded deps.
- Fixes the Gradle signing logic.
This work was validated by walking through the release steps
for both Maven and Gradle. I staged the artifacts from both
builds and compared them.
Change-Id: I50c3b9358896b264fd525de558b6be7ef77145e2
---
M RELEASING.adoc
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-backup/build.gradle
M java/kudu-backup/pom.xml
M java/kudu-hive/pom.xml
6 files changed, 53 insertions(+), 35 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/11576/4
--
To view, visit http://gerrit.cloudera.org:8080/11576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I50c3b9358896b264fd525de558b6be7ef77145e2
Gerrit-Change-Number: 11576
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Build cleanup in preperation for release
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Attila Bukor, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11576
to look at the new patch set (#3).
Change subject: Build cleanup in preperation for release
......................................................................
Build cleanup in preperation for release
This patch is a few small fixes in preparation for release:
- Updates the releasing docs to use Gradle
- Updates the hive and backup modules to skip the
javadoc task. They don’t have public javadoc to publish.
- Updates the backup module to ensure it’s not published.
- Fixes Gradle pom generation to included unshaded deps.
- Fixes the Gradle signing logic.
This work was validated by walking through the release steps
for both Maven and Gradle. I staged the artifacts from both
builds and compared them.
Change-Id: I50c3b9358896b264fd525de558b6be7ef77145e2
---
M RELEASING.adoc
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-backup/build.gradle
M java/kudu-backup/pom.xml
M java/kudu-hive/pom.xml
6 files changed, 46 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/11576/3
--
To view, visit http://gerrit.cloudera.org:8080/11576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I50c3b9358896b264fd525de558b6be7ef77145e2
Gerrit-Change-Number: 11576
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Build cleanup in preperation for release
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11576 )
Change subject: Build cleanup in preperation for release
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50c3b9358896b264fd525de558b6be7ef77145e2
Gerrit-Change-Number: 11576
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 03 Oct 2018 20:20:04 +0000
Gerrit-HasComments: No
[kudu-CR] Build cleanup in preperation for release
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11576 )
Change subject: Build cleanup in preperation for release
......................................................................
Build cleanup in preperation for release
This patch is a few small fixes in preparation for release:
- Updates the releasing docs to use Gradle
- Updates the hive and backup modules to skip the
javadoc task. They don’t have public javadoc to publish.
- Updates the backup module to ensure it’s not published.
- Fixes Gradle pom generation to included unshaded deps.
- Fixes the Gradle signing logic.
This work was validated by walking through the release steps
for both Maven and Gradle. I staged the artifacts from both
builds and compared them.
Change-Id: I50c3b9358896b264fd525de558b6be7ef77145e2
Reviewed-on: http://gerrit.cloudera.org:8080/11576
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M RELEASING.adoc
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-backup/build.gradle
M java/kudu-backup/pom.xml
M java/kudu-hive/pom.xml
6 files changed, 53 insertions(+), 35 deletions(-)
Approvals:
Adar Dembo: Looks good to me, but someone else must approve
Kudu Jenkins: Verified
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I50c3b9358896b264fd525de558b6be7ef77145e2
Gerrit-Change-Number: 11576
Gerrit-PatchSet: 5
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Build cleanup in preperation for release
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11576 )
Change subject: Build cleanup in preperation for release
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/11576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50c3b9358896b264fd525de558b6be7ef77145e2
Gerrit-Change-Number: 11576
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 03 Oct 2018 19:52:47 +0000
Gerrit-HasComments: No
[kudu-CR] Build cleanup in preperation for release
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11576 )
Change subject: Build cleanup in preperation for release
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11576/3/RELEASING.adoc
File RELEASING.adoc:
http://gerrit.cloudera.org:8080/#/c/11576/3/RELEASING.adoc@161
PS3, Line 161: gradle clean uploadArchives -PmavenUsername="<APACHE-LDAP-USERNAME>" -PmavenPassword="<APACHE-LDAP-PASSWORD>"
> I know the original instructions also used the clean target, but is it real
The assemble task doesn't run tests so no form of skip tests is needed.
I think the clean is just to ensure there is no chance for any bad/corrupt state. Given this is generating a permanent release, the couple of minutes of extra time is likely worth the safety.
--
To view, visit http://gerrit.cloudera.org:8080/11576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50c3b9358896b264fd525de558b6be7ef77145e2
Gerrit-Change-Number: 11576
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 03 Oct 2018 20:03:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] Build cleanup in preperation for release
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11576
to look at the new patch set (#2).
Change subject: Build cleanup in preperation for release
......................................................................
Build cleanup in preperation for release
This patch is a few small fixes in preparation for release:
- Updates the releasing docs to use Gradle
- Updates the hive and backup modules to skip the
javadoc task. They don’t have public javadoc to publish.
- Updates the backup module to ensure it’s not published.
- Fixes Gradle pom generation to included unshaded deps.
- Fixes the Gradle signing logic.
This work was validated by walking through the release steps
for both Maven and Gradle. I staged the artifacts from both
builds and compared them.
Change-Id: I50c3b9358896b264fd525de558b6be7ef77145e2
---
M RELEASING.adoc
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-backup/build.gradle
M java/kudu-backup/pom.xml
M java/kudu-hive/pom.xml
6 files changed, 47 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/11576/2
--
To view, visit http://gerrit.cloudera.org:8080/11576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I50c3b9358896b264fd525de558b6be7ef77145e2
Gerrit-Change-Number: 11576
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Build cleanup in preperation for release
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11576 )
Change subject: Build cleanup in preperation for release
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11576/3/RELEASING.adoc
File RELEASING.adoc:
http://gerrit.cloudera.org:8080/#/c/11576/3/RELEASING.adoc@a141
PS3, Line 141:
:
:
> Is this a feature Kudu release managers were using? Is there an equivalent
I am not sure if it was being used, there is no equivalent in Gradle. However, you don't need to store your password, you can provide it on the command line (albeit unmasked).
http://gerrit.cloudera.org:8080/#/c/11576/3/java/gradle/shadow.gradle
File java/gradle/shadow.gradle:
http://gerrit.cloudera.org:8080/#/c/11576/3/java/gradle/shadow.gradle@85
PS3, Line 85: 300
> What's the significance of this priority value?
There is effectively no significance in our usage. I will change to using
constants so it's not a magic number.
http://gerrit.cloudera.org:8080/#/c/11576/3/java/kudu-backup/pom.xml
File java/kudu-backup/pom.xml:
http://gerrit.cloudera.org:8080/#/c/11576/3/java/kudu-backup/pom.xml@272
PS3, Line 272: <!-- This big ol' block of nonsense tells the m2e Eclipse plugin what
: to do with maven plugins that don't have m2e "extensions" available.
:
: It doesn't affect the Maven build at all. -->
> This should be rescoped to the org.eclipse.m2e plugin section.
Done
--
To view, visit http://gerrit.cloudera.org:8080/11576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50c3b9358896b264fd525de558b6be7ef77145e2
Gerrit-Change-Number: 11576
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 03 Oct 2018 19:46:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] Build cleanup in preperation for release
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11576 )
Change subject: Build cleanup in preperation for release
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/11576/3/RELEASING.adoc
File RELEASING.adoc:
http://gerrit.cloudera.org:8080/#/c/11576/3/RELEASING.adoc@a141
PS3, Line 141:
:
:
Is this a feature Kudu release managers were using? Is there an equivalent in Gradle?
http://gerrit.cloudera.org:8080/#/c/11576/3/java/gradle/shadow.gradle
File java/gradle/shadow.gradle:
http://gerrit.cloudera.org:8080/#/c/11576/3/java/gradle/shadow.gradle@85
PS3, Line 85: 300
What's the significance of this priority value?
http://gerrit.cloudera.org:8080/#/c/11576/3/java/kudu-backup/pom.xml
File java/kudu-backup/pom.xml:
http://gerrit.cloudera.org:8080/#/c/11576/3/java/kudu-backup/pom.xml@272
PS3, Line 272: <!-- This big ol' block of nonsense tells the m2e Eclipse plugin what
: to do with maven plugins that don't have m2e "extensions" available.
:
: It doesn't affect the Maven build at all. -->
This should be rescoped to the org.eclipse.m2e plugin section.
--
To view, visit http://gerrit.cloudera.org:8080/11576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50c3b9358896b264fd525de558b6be7ef77145e2
Gerrit-Change-Number: 11576
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 03 Oct 2018 18:44:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] Build cleanup in preperation for release
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11576 )
Change subject: Build cleanup in preperation for release
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11576/3/RELEASING.adoc
File RELEASING.adoc:
http://gerrit.cloudera.org:8080/#/c/11576/3/RELEASING.adoc@161
PS3, Line 161: gradle clean uploadArchives -PmavenUsername="<APACHE-LDAP-USERNAME>" -PmavenPassword="<APACHE-LDAP-PASSWORD>"
I know the original instructions also used the clean target, but is it really necessary? Wouldn't it be faster to just do gradle uploadArchives as well? Also, what about the -DskipTests?
--
To view, visit http://gerrit.cloudera.org:8080/11576
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I50c3b9358896b264fd525de558b6be7ef77145e2
Gerrit-Change-Number: 11576
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 03 Oct 2018 20:01:49 +0000
Gerrit-HasComments: Yes