You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/08/08 11:04:12 UTC
Review Request 13424: CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding
VMWare Cluster to the Setup,
3.0.6 System VM Template for VMWare is downloaded instead of 4.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13424/
-----------------------------------------------------------
Review request for cloudstack and Kishan Kavala.
Bugs: CLOUDSTACK-4123
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding VMWare Cluster to the Setup, 3.0.6 System VM Template for VMWare is downloaded instead of 4.2
Updating the new system template URLs for the existing templates during upgrade to 4.2.
If new 4.2 system template is registered before upgrade then marking the old templates as removed during upgrade.
Diffs
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 0941408
Diff: https://reviews.apache.org/r/13424/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 13424: CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On
Adding VMWare Cluster to the Setup,
3.0.6 System VM Template for VMWare is downloaded instead of 4.2
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13424/#review24965
-----------------------------------------------------------
Commit 48c8e64ae9c872d339b0fb8a2fc7fa453862fada in branch refs/heads/4.2 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=48c8e64 ]
CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding VMWare Cluster to the Setup, 3.0.6 System VM Template for VMWare is downloaded instead of 4.2
Updating the new system template URLs for the existing templates during upgrade to 4.2.
If new 4.2 system template is registered before upgrade then marking the old templates as removed during upgrade.
- ASF Subversion and Git Services
On Aug. 10, 2013, 10:16 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13424/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2013, 10:16 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-4123 and CLOUDSTACK-4205
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding VMWare Cluster to the Setup, 3.0.6 System VM Template for VMWare is downloaded instead of 4.2
>
> Updating the new system template URLs for the existing templates during upgrade to 4.2.
> If new 4.2 system template is registered before upgrade then marking the old templates as removed during upgrade.
>
> CLOUDSTACK-4205: System VMs are not booting up with new templates after Upgrade from 3.0.6 to 4.2.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9243225
> engine/schema/src/com/cloud/upgrade/dao/Upgrade412to420.java d703cc3
> server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java a583954
> server/src/com/cloud/resource/ResourceManagerImpl.java e5441af
> server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 17cbf5c
>
> Diff: https://reviews.apache.org/r/13424/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 13424: CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On
Adding VMWare Cluster to the Setup,
3.0.6 System VM Template for VMWare is downloaded instead of 4.2
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13424/#review24967
-----------------------------------------------------------
Ship it!
commit 48c8e64ae9c872d339b0fb8a2fc7fa453862fada
- Kishan Kavala
On Aug. 10, 2013, 3:46 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13424/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2013, 3:46 p.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-4123 and CLOUDSTACK-4205
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding VMWare Cluster to the Setup, 3.0.6 System VM Template for VMWare is downloaded instead of 4.2
>
> Updating the new system template URLs for the existing templates during upgrade to 4.2.
> If new 4.2 system template is registered before upgrade then marking the old templates as removed during upgrade.
>
> CLOUDSTACK-4205: System VMs are not booting up with new templates after Upgrade from 3.0.6 to 4.2.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9243225
> engine/schema/src/com/cloud/upgrade/dao/Upgrade412to420.java d703cc3
> server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java a583954
> server/src/com/cloud/resource/ResourceManagerImpl.java e5441af
> server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 17cbf5c
>
> Diff: https://reviews.apache.org/r/13424/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 13424: CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On
Adding VMWare Cluster to the Setup,
3.0.6 System VM Template for VMWare is downloaded instead of 4.2
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13424/#review24966
-----------------------------------------------------------
Commit 5404bf606395fb4ff58252df9511341416eb160a in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5404bf6 ]
CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding VMWare Cluster to the Setup, 3.0.6 System VM Template for VMWare is downloaded instead of 4.2
Updating the new system template URLs for the existing templates during upgrade to 4.2.
If new 4.2 system template is registered before upgrade then marking the old templates as removed during upgrade.
- ASF Subversion and Git Services
On Aug. 10, 2013, 10:16 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13424/
> -----------------------------------------------------------
>
> (Updated Aug. 10, 2013, 10:16 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-4123 and CLOUDSTACK-4205
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding VMWare Cluster to the Setup, 3.0.6 System VM Template for VMWare is downloaded instead of 4.2
>
> Updating the new system template URLs for the existing templates during upgrade to 4.2.
> If new 4.2 system template is registered before upgrade then marking the old templates as removed during upgrade.
>
> CLOUDSTACK-4205: System VMs are not booting up with new templates after Upgrade from 3.0.6 to 4.2.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9243225
> engine/schema/src/com/cloud/upgrade/dao/Upgrade412to420.java d703cc3
> server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java a583954
> server/src/com/cloud/resource/ResourceManagerImpl.java e5441af
> server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 17cbf5c
>
> Diff: https://reviews.apache.org/r/13424/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 13424: CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On
Adding VMWare Cluster to the Setup,
3.0.6 System VM Template for VMWare is downloaded instead of 4.2
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13424/
-----------------------------------------------------------
(Updated Aug. 10, 2013, 10:16 a.m.)
Review request for cloudstack and Kishan Kavala.
Changes
-------
Updated patch after rebasing
Bugs: CLOUDSTACK-4123 and CLOUDSTACK-4205
Repository: cloudstack-git
Description
-------
CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding VMWare Cluster to the Setup, 3.0.6 System VM Template for VMWare is downloaded instead of 4.2
Updating the new system template URLs for the existing templates during upgrade to 4.2.
If new 4.2 system template is registered before upgrade then marking the old templates as removed during upgrade.
CLOUDSTACK-4205: System VMs are not booting up with new templates after Upgrade from 3.0.6 to 4.2.
Diffs (updated)
-----
engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9243225
engine/schema/src/com/cloud/upgrade/dao/Upgrade412to420.java d703cc3
server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java a583954
server/src/com/cloud/resource/ResourceManagerImpl.java e5441af
server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 17cbf5c
Diff: https://reviews.apache.org/r/13424/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 13424: CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On
Adding VMWare Cluster to the Setup,
3.0.6 System VM Template for VMWare is downloaded instead of 4.2
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13424/#review24964
-----------------------------------------------------------
Changes look good to me. But the upgrade path has changed to accommodate upgrades from 4.1.1 and 4.1.2. Patch doesn't apply on the latest code due to this change. Please submit the patch again.
- Kishan Kavala
On Aug. 9, 2013, 5:20 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13424/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 5:20 p.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Bugs: CLOUDSTACK-4123 and CLOUDSTACK-4205
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding VMWare Cluster to the Setup, 3.0.6 System VM Template for VMWare is downloaded instead of 4.2
>
> Updating the new system template URLs for the existing templates during upgrade to 4.2.
> If new 4.2 system template is registered before upgrade then marking the old templates as removed during upgrade.
>
> CLOUDSTACK-4205: System VMs are not booting up with new templates after Upgrade from 3.0.6 to 4.2.
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9243225
> engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 0941408
> server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java a583954
> server/src/com/cloud/resource/ResourceManagerImpl.java e5441af
> server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 17cbf5c
>
> Diff: https://reviews.apache.org/r/13424/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 13424: CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On
Adding VMWare Cluster to the Setup,
3.0.6 System VM Template for VMWare is downloaded instead of 4.2
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13424/
-----------------------------------------------------------
(Updated Aug. 9, 2013, 11:50 a.m.)
Review request for cloudstack and Kishan Kavala.
Bugs: CLOUDSTACK-4123 and CLOUDSTACK-4205
Repository: cloudstack-git
Description (updated)
-------
CLOUDSTACK-4123: 3.0.6 to ASF 4.2 Upgrade: On Adding VMWare Cluster to the Setup, 3.0.6 System VM Template for VMWare is downloaded instead of 4.2
Updating the new system template URLs for the existing templates during upgrade to 4.2.
If new 4.2 system template is registered before upgrade then marking the old templates as removed during upgrade.
CLOUDSTACK-4205: System VMs are not booting up with new templates after Upgrade from 3.0.6 to 4.2.
Diffs (updated)
-----
engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9243225
engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 0941408
server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java a583954
server/src/com/cloud/resource/ResourceManagerImpl.java e5441af
server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 17cbf5c
Diff: https://reviews.apache.org/r/13424/diff/
Testing
-------
Thanks,
Harikrishna Patnala