You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/05/02 02:13:56 UTC
[kudu-CR] [tests] fix flakiness in TableLocationsCacheMultiMasterTest
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17384
Change subject: [tests] fix flakiness in TableLocationsCacheMultiMasterTest
......................................................................
[tests] fix flakiness in TableLocationsCacheMultiMasterTest
The TableLocationsCacheMultiMasterTest.ResetCache scenario showed
signs of flakiness. It turned out that the root case of the issue
was the absence of Raft leader leases.
This patch fixes the issue. I ran the scenario using dist-test before
and after this patch (DEBUG build):
before: 4 out of 256 failed
http://dist-test.cloudera.org/job?job_id=aserbin.1619919271.11533
after : 0 out of 256 failed
http://dist-test.cloudera.org/job?job_id=aserbin.1619919744.16115
Change-Id: Id53f0c537bdf1ec65da7d4bbf695864011f3e2ae
---
M src/kudu/integration-tests/table_locations-itest.cc
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/17384/1
--
To view, visit http://gerrit.cloudera.org:8080/17384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id53f0c537bdf1ec65da7d4bbf695864011f3e2ae
Gerrit-Change-Number: 17384
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tests] fix flakiness in TableLocationsCacheMultiMasterTest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17384 )
Change subject: [tests] fix flakiness in TableLocationsCacheMultiMasterTest
......................................................................
[tests] fix flakiness in TableLocationsCacheMultiMasterTest
The TableLocationsCacheMultiMasterTest.ResetCache scenario showed
signs of flakiness. It turned out that the root case of the issue
was the absence of Raft leader leases.
This patch fixes the issue. I ran the scenario using dist-test before
and after this patch (DEBUG builds):
before: 4 out of 256 failed
http://dist-test.cloudera.org/job?job_id=aserbin.1619919271.11533
after : 0 out of 256 failed
http://dist-test.cloudera.org/job?job_id=aserbin.1619919744.16115
Change-Id: Id53f0c537bdf1ec65da7d4bbf695864011f3e2ae
Reviewed-on: http://gerrit.cloudera.org:8080/17384
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
---
M src/kudu/integration-tests/table_locations-itest.cc
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Alexey Serbin: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id53f0c537bdf1ec65da7d4bbf695864011f3e2ae
Gerrit-Change-Number: 17384
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tests] fix flakiness in TableLocationsCacheMultiMasterTest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17384
to look at the new patch set (#2).
Change subject: [tests] fix flakiness in TableLocationsCacheMultiMasterTest
......................................................................
[tests] fix flakiness in TableLocationsCacheMultiMasterTest
The TableLocationsCacheMultiMasterTest.ResetCache scenario showed
signs of flakiness. It turned out that the root case of the issue
was the absence of Raft leader leases.
This patch fixes the issue. I ran the scenario using dist-test before
and after this patch (DEBUG builds):
before: 4 out of 256 failed
http://dist-test.cloudera.org/job?job_id=aserbin.1619919271.11533
after : 0 out of 256 failed
http://dist-test.cloudera.org/job?job_id=aserbin.1619919744.16115
Change-Id: Id53f0c537bdf1ec65da7d4bbf695864011f3e2ae
---
M src/kudu/integration-tests/table_locations-itest.cc
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/17384/2
--
To view, visit http://gerrit.cloudera.org:8080/17384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id53f0c537bdf1ec65da7d4bbf695864011f3e2ae
Gerrit-Change-Number: 17384
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tests] fix flakiness in TableLocationsCacheMultiMasterTest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [tests] fix flakiness in TableLocationsCacheMultiMasterTest
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Id53f0c537bdf1ec65da7d4bbf695864011f3e2ae
Gerrit-Change-Number: 17384
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [tests] fix flakiness in TableLocationsCacheMultiMasterTest
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17384 )
Change subject: [tests] fix flakiness in TableLocationsCacheMultiMasterTest
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id53f0c537bdf1ec65da7d4bbf695864011f3e2ae
Gerrit-Change-Number: 17384
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 03 May 2021 02:48:58 +0000
Gerrit-HasComments: No
[kudu-CR] [tests] fix flakiness in TableLocationsCacheMultiMasterTest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17384 )
Change subject: [tests] fix flakiness in TableLocationsCacheMultiMasterTest
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17384
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id53f0c537bdf1ec65da7d4bbf695864011f3e2ae
Gerrit-Change-Number: 17384
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sun, 02 May 2021 06:23:23 +0000
Gerrit-HasComments: No