You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org> on 2008/03/31 14:10:24 UTC
[jira] Updated: (HADOOP-3023) [HOD] build file requires exact
python version
[ https://issues.apache.org/jira/browse/HADOOP-3023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vinod Kumar Vavilapalli updated HADOOP-3023:
--------------------------------------------
Attachment: HADOOP-3023
Attaching a patch. This removes the python version check from ant build.xml. This is moved to testing/main.py which is the entry point for running test cases.
ant test now runs the tests when it finds python of version 2.5.1 or greater specified through -Dpython.home. If it finds a lesser version, it fails with return code 1, and with proper message. In case of a particular test-case failing, testing/main.py returns an error code 2. It returns a 0 when all test-cases run successfully.
Also refactored code in testing/main.py
> [HOD] build file requires exact python version
> ----------------------------------------------
>
> Key: HADOOP-3023
> URL: https://issues.apache.org/jira/browse/HADOOP-3023
> Project: Hadoop Core
> Issue Type: Improvement
> Components: build
> Reporter: Nigel Daley
> Assignee: Vinod Kumar Vavilapalli
> Attachments: HADOOP-3023
>
>
> To run the HOD pyunit tests, the build file checks that an exact python version is present:
> + <condition property="python.versionmatched">
> + <!--- Currently check for only 2.5.1 -->
> + <equals arg1="${hodtest.pythonVersion}" arg2="Python 2.5.1" />
> + </condition>
> This is too restrictive (we have 2.5.2 on our Solaris build machine). I suggest that you don't check the python version and instead issue a warning message if the pyunit test fail stating that python 2.5.1 or great is required (and optionally showing them what version they tried to use).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.