[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6880: t3c will ensure config files are owned by ats

[GitBox <gi...@apache.org>]

ocket8888 commented on code in PR #6880:
URL: https://github.com/apache/trafficcontrol/pull/6880#discussion_r891850590


##########
cache-config/t3c-diff/README.md:
##########
@@ -58,12 +58,37 @@ If one file exists but the other doesn't, it will always be a diff.
 Note this means there may be no diff text printed to stdout but still exit 1 indicating a diff
 if the file being created or deleted is semantically empty.
 
+Mode is file permissions in octal format, default is 0644.
+Line comment is a character that signals the line is a comment, default is #
+
+Uid is the user id of the file's owner, default is running process's uid.
+Gid is the id of the group the file is a member of, default  running process's gid.`
+
 # OPTIONS
 
+-a, -\-file-a
+
+    Path to first diff file, can also be stdin.
+
+-b, -\-file-b
+    Path to second diff file, can also be stdin.
+
+-g, -\-file-gid
+    Group id the file being checked should have.

Review Comment:
   This is a fine description - why not put it in the help text?



##########
cache-config/t3c-diff/t3c-diff.go:
##########
@@ -49,6 +49,8 @@ func main() {
 	version := getopt.BoolLong("version", 'V', "Print version information and exit")
 	lineComment := getopt.StringLong("line_comment", 'l', "#", "Comment symbol")
 	mode := getopt.IntLong("file-mode", 'm', 0644, "file mode default is 644")
+	uid := getopt.IntLong("file-uid", 'u', 0, "file uid default is 0")
+	gid := getopt.IntLong("file-gid", 'g', 0, "file gid default is 0")

Review Comment:
   > default is 0
   
   is no longer accurate



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org