You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/07/20 14:57:19 UTC
[GitHub] [openwhisk-runtime-go] dgrove-oss opened a new pull request #149: add support for GoLang 1.16
dgrove-oss opened a new pull request #149:
URL: https://github.com/apache/openwhisk-runtime-go/pull/149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] dgrove-oss commented on pull request #149: add support for GoLang 1.16
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on pull request #149:
URL: https://github.com/apache/openwhisk-runtime-go/pull/149#issuecomment-884950826
@sciabarra -- I was planning on getting go 1.16 support in, then updating the CHANGELOG and kicking off the release process next week. That ok with you, or do you have mor changes to get in before we release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] rabbah commented on a change in pull request #149: add support for GoLang 1.16
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #149:
URL: https://github.com/apache/openwhisk-runtime-go/pull/149#discussion_r675261470
##########
File path: docs/ACTION.md
##########
@@ -127,7 +127,7 @@ done
Note here we are just interested in the payload, but in general you may also want to retrieve other fields.
-Note the `actionloop` image will accept any source and will try to run it (if it is possible), while the `action-golang-v1.15` will instead try to compile the sources assuming it is Golang instead.
+Note the `actionloop` image will accept any source and will try to run it (if it is possible), while the `action-golang-v1.N` will instead try to compile the sources assuming it is Golang instead.
Review comment:
I thought this was fine/obvious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] dgrove-oss commented on pull request #149: add support for GoLang 1.16
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on pull request #149:
URL: https://github.com/apache/openwhisk-runtime-go/pull/149#issuecomment-887541938
rebased to reconcile with #151. Can we make progress on this soon? I would like to get the VOTE going for an openwhisk-runtime-go release this week so I can then update all the action loop based runtimes and get them released next week. If we want to get an openwhisk core release out in August we need to keep things moving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] dgrove-oss edited a comment on pull request #149: add support for GoLang 1.16
Posted by GitBox <gi...@apache.org>.
dgrove-oss edited a comment on pull request #149:
URL: https://github.com/apache/openwhisk-runtime-go/pull/149#issuecomment-886703608
Yes. Tests ran just fine (both for me locally and in travis). You may need to update your local clone of core `openwhisk` and do a clean & reinstall of it first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] sciabarracom commented on pull request #149: add support for GoLang 1.16
Posted by GitBox <gi...@apache.org>.
sciabarracom commented on pull request #149:
URL: https://github.com/apache/openwhisk-runtime-go/pull/149#issuecomment-886570228
Uhm
```
java.lang.IllegalStateException: You are using version 2.6.12 of Akka, but it appears you (perhaps indirectly) also depend on older versions of related artifacts. You can solve this by adding an explicit dependency on version 2.6.12 of the [akka-cluster-metrics, akka-slf4j, akka-distributed-data, akka-testkit, akka-stream-testkit, akka-cluster-tools] artifacts to your project. See also: https://doc.akka.io/docs/akka/current/common/binary-compatibility-rules.html#mixed-versioning-is-not-allowed
```
Were you able to run the tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] dgrove-oss edited a comment on pull request #149: add support for GoLang 1.16
Posted by GitBox <gi...@apache.org>.
dgrove-oss edited a comment on pull request #149:
URL: https://github.com/apache/openwhisk-runtime-go/pull/149#issuecomment-884950826
@sciabarra -- I was planning on getting go 1.16 support in, then updating the CHANGELOG and kicking off the release process next week. That ok with you, or do you have more changes to get in before we release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] dgrove-oss merged pull request #149: add support for GoLang 1.16
Posted by GitBox <gi...@apache.org>.
dgrove-oss merged pull request #149:
URL: https://github.com/apache/openwhisk-runtime-go/pull/149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] sciabarracom commented on pull request #149: add support for GoLang 1.16
Posted by GitBox <gi...@apache.org>.
sciabarracom commented on pull request #149:
URL: https://github.com/apache/openwhisk-runtime-go/pull/149#issuecomment-885200582
Let me review the changes and test if and I will confirm the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] dgrove-oss commented on a change in pull request #149: add support for GoLang 1.16
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on a change in pull request #149:
URL: https://github.com/apache/openwhisk-runtime-go/pull/149#discussion_r675152930
##########
File path: common/gobuild.py
##########
@@ -62,7 +62,7 @@ def build(parent, source_dir, target):
if os.path.isdir("%s/main" % source_dir):
source_dir += "/main"
p = subprocess.Popen(
- ["go", "build", "-i", "-ldflags=-s -w", "-o", target],
Review comment:
the `-i` flag has been deprecated for a while; `go build 1.16` takes it a step further by removing it entirely
##########
File path: docs/ACTION.md
##########
@@ -127,7 +127,7 @@ done
Note here we are just interested in the payload, but in general you may also want to retrieve other fields.
-Note the `actionloop` image will accept any source and will try to run it (if it is possible), while the `action-golang-v1.15` will instead try to compile the sources assuming it is Golang instead.
+Note the `actionloop` image will accept any source and will try to run it (if it is possible), while the `action-golang-v1.N` will instead try to compile the sources assuming it is Golang instead.
Review comment:
got tired of bumping this number (and similar in docs). I think `v1.N` is clear, but I'm also ok with backing this bit of this change out if someone things it is unclear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] dgrove-oss commented on pull request #149: add support for GoLang 1.16
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on pull request #149:
URL: https://github.com/apache/openwhisk-runtime-go/pull/149#issuecomment-886703608
Yes. Tests ran just fine (both for me and in travis). You may need to update your local cloud of core `openwhisk` and do a clean & reinstall of it first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] mrutkows commented on pull request #149: add support for GoLang 1.16
Posted by GitBox <gi...@apache.org>.
mrutkows commented on pull request #149:
URL: https://github.com/apache/openwhisk-runtime-go/pull/149#issuecomment-886898370
@sciabarracom
> You may need to update your local clone of core `openwhisk` and do a clean & reinstall of it first.
You may want to wipe your GOPATH pkg folder...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] sciabarra commented on pull request #149: add support for GoLang 1.16
Posted by GitBox <gi...@apache.org>.
sciabarra commented on pull request #149:
URL: https://github.com/apache/openwhisk-runtime-go/pull/149#issuecomment-885564561
Some time ago I found an issue building with certain go libraries, will take the time to investigate this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] dgrove-oss commented on a change in pull request #149: add support for GoLang 1.16
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on a change in pull request #149:
URL: https://github.com/apache/openwhisk-runtime-go/pull/149#discussion_r675153654
##########
File path: docs/ACTION.md
##########
@@ -127,7 +127,7 @@ done
Note here we are just interested in the payload, but in general you may also want to retrieve other fields.
-Note the `actionloop` image will accept any source and will try to run it (if it is possible), while the `action-golang-v1.15` will instead try to compile the sources assuming it is Golang instead.
+Note the `actionloop` image will accept any source and will try to run it (if it is possible), while the `action-golang-v1.N` will instead try to compile the sources assuming it is Golang instead.
Review comment:
got tired of bumping this number (and similar in docs). I think `v1.N` is clear, but I'm also ok with backing this bit of this change out if someone thinks it is unclear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-runtime-go] sciabarracom commented on pull request #149: add support for GoLang 1.16
Posted by GitBox <gi...@apache.org>.
sciabarracom commented on pull request #149:
URL: https://github.com/apache/openwhisk-runtime-go/pull/149#issuecomment-885199925
I added support for symlinks because it was needed to support virtualenvs built by the image itself. I do not plan other changes. I am only worried if my change broke "something". Before, permissions were set to a default value (0644) now they are set by the value in the zip file, so if someone has an action with broken permissions in the zip... the action could break. Maybe. Except in the runtime the proxy is run as a root so probably it does not matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org