You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Felix Meschberger (JIRA)" <ji...@apache.org> on 2007/10/16 09:07:52 UTC
[jira] Created: (SLING-54) Drop RequestFilter interface for the
real servlet Filter interface
Drop RequestFilter interface for the real servlet Filter interface
------------------------------------------------------------------
Key: SLING-54
URL: https://issues.apache.org/jira/browse/SLING-54
Project: Sling
Issue Type: Improvement
Components: microsling
Reporter: Felix Meschberger
Fix For: 2.0.0
Currently microsling has a RequestFilter interface initially though for a simple quick/hack implementation. I suggest that this interface is dropped in favor of the real servlet Filter interface. This would also allow for proper injection of request/response wrappers at will by the filters and would prevent bloating the ServletRequestContext with data from filters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (SLING-54) Drop RequestFilter interface for the
real servlet Filter interface
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger reassigned SLING-54:
--------------------------------------
Assignee: Felix Meschberger
> Drop RequestFilter interface for the real servlet Filter interface
> ------------------------------------------------------------------
>
> Key: SLING-54
> URL: https://issues.apache.org/jira/browse/SLING-54
> Project: Sling
> Issue Type: Improvement
> Components: microsling
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: 2.0.0
>
>
> Currently microsling has a RequestFilter interface initially though for a simple quick/hack implementation. I suggest that this interface is dropped in favor of the real servlet Filter interface. This would also allow for proper injection of request/response wrappers at will by the filters and would prevent bloating the ServletRequestContext with data from filters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SLING-54) Drop RequestFilter interface for the
real servlet Filter interface
Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12535174 ]
Bertrand Delacretaz commented on SLING-54:
------------------------------------------
Agreed, let's use the standard interface for this.
The idea in having our own interfaces was to have better separation between request and response filters, but the advantages of using the standard probably outweigh this.
> Drop RequestFilter interface for the real servlet Filter interface
> ------------------------------------------------------------------
>
> Key: SLING-54
> URL: https://issues.apache.org/jira/browse/SLING-54
> Project: Sling
> Issue Type: Improvement
> Components: microsling
> Reporter: Felix Meschberger
> Fix For: 2.0.0
>
>
> Currently microsling has a RequestFilter interface initially though for a simple quick/hack implementation. I suggest that this interface is dropped in favor of the real servlet Filter interface. This would also allow for proper injection of request/response wrappers at will by the filters and would prevent bloating the ServletRequestContext with data from filters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (SLING-54) Drop RequestFilter interface for the real
servlet Filter interface
Posted by "Felix Meschberger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-54?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Felix Meschberger closed SLING-54.
----------------------------------
Resolution: Fixed
Replaced RequestFilter by standard Servlet Filter and added AbstractFilter simplifying filtering a bit in Rev. 585088.
I also added a MicroSlingFilterHelper class, which manages the filter list and also creates a filter chain for the request processing on behalf of the MicroSlingServlet.
> Drop RequestFilter interface for the real servlet Filter interface
> ------------------------------------------------------------------
>
> Key: SLING-54
> URL: https://issues.apache.org/jira/browse/SLING-54
> Project: Sling
> Issue Type: Improvement
> Components: microsling
> Reporter: Felix Meschberger
> Assignee: Felix Meschberger
> Fix For: 2.0.0
>
>
> Currently microsling has a RequestFilter interface initially though for a simple quick/hack implementation. I suggest that this interface is dropped in favor of the real servlet Filter interface. This would also allow for proper injection of request/response wrappers at will by the filters and would prevent bloating the ServletRequestContext with data from filters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.