You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/29 09:50:17 UTC

[GitHub] [inlong] dockerzhang opened a new issue, #6668: [Improve][Sort] Unify the constants in `inlong-common` and `sort-connectors`

dockerzhang opened a new issue, #6668:
URL: https://github.com/apache/inlong/issues/6668

   ### Description
   
   many constants defined in both, it's redundant, it's better to unify them, for example `metrics.audit.proxy.hosts`:
   
   - `sort-connectors`
   ![image](https://user-images.githubusercontent.com/18047329/204496013-f2b8f39a-74c7-47a2-8704-60a8d55bfbdc.png)
   
   - `inlong-common`
   ![image](https://user-images.githubusercontent.com/18047329/204496140-3d44cd80-c72d-4f69-b602-55fda12c0aaf.png)
   
   
   
   
   
   
   
   ### InLong Component
   
   InLong Sort
   
   ### Are you willing to submit PR?
   
   - [ ] Yes, I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@inlong.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] seedscoder commented on issue #6668: [Improve][Sort] Unify the constants in `inlong-common` and `sort-connectors`

Posted by GitBox <gi...@apache.org>.
seedscoder commented on issue #6668:
URL: https://github.com/apache/inlong/issues/6668#issuecomment-1343984069

   Only extract the same key between the two modules? If these two modules have the same key as other modules,  need to handle it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] seedscoder commented on issue #6668: [Improve][Sort] Unify the constants in `inlong-common` and `sort-connectors`

Posted by GitBox <gi...@apache.org>.
seedscoder commented on issue #6668:
URL: https://github.com/apache/inlong/issues/6668#issuecomment-1331477594

   If others don't start, please assign it to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] dockerzhang commented on issue #6668: [Improve][Sort] Unify the constants in `inlong-common` and `sort-connectors`

Posted by GitBox <gi...@apache.org>.
dockerzhang commented on issue #6668:
URL: https://github.com/apache/inlong/issues/6668#issuecomment-1346080132

   @seedscoder it's better to think about it together.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] jackpan123 commented on issue #6668: [Improve][Sort] Unify the constants in `inlong-common` and `sort-connectors`

Posted by "jackpan123 (via GitHub)" <gi...@apache.org>.
jackpan123 commented on issue #6668:
URL: https://github.com/apache/inlong/issues/6668#issuecomment-1471589669

   @dockerzhang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] bibhu107 commented on issue #6668: [Improve][Sort] Unify the constants in `inlong-common` and `sort-connectors`

Posted by "bibhu107 (via GitHub)" <gi...@apache.org>.
bibhu107 commented on issue #6668:
URL: https://github.com/apache/inlong/issues/6668#issuecomment-1510228471

   Can I please take this issue @dockerzhang? Please assign it to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] dockerzhang commented on issue #6668: [Improve][Sort] Unify the constants in `inlong-common` and `sort-connectors`

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on issue #6668:
URL: https://github.com/apache/inlong/issues/6668#issuecomment-1410033788

   @seedscoder do you start to solve this issue?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] dockerzhang closed issue #6668: [Improve][Sort] Unify the constants in `inlong-common` and `sort-connectors`

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang closed issue #6668: [Improve][Sort] Unify the constants in `inlong-common`  and `sort-connectors`
URL: https://github.com/apache/inlong/issues/6668


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [inlong] jackpan123 commented on issue #6668: [Improve][Sort] Unify the constants in `inlong-common` and `sort-connectors`

Posted by "jackpan123 (via GitHub)" <gi...@apache.org>.
jackpan123 commented on issue #6668:
URL: https://github.com/apache/inlong/issues/6668#issuecomment-1471563862

   Could you assign it to me? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org