[jira] [Commented] (AIRFLOW-6088) Pass correct value (timedelta or milliseconds) to Stats.timing ()

["Martijn Pieters (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186521#comment-17186521 ] 

Martijn Pieters commented on AIRFLOW-6088:
------------------------------------------

This is an issue with more timers in the code, these all record seconds, rather than milliseconds or a timedelta (some start from a timedelta but then convert to seconds, in some places incorrectly):
 * {{dag.loading-duration.*}} (in {{models/dagbag.py}})
 * {{dag.<dag_id>.<task_id>.duration}} (in {{models/taskinstance.py}})
 * {{dag_processing.last_duration.<filename>}} (in {{utils/dag_processing.py}}) and it's deprecated alias {{dag_processing.last_runtime.*}}

Should I open a separate ticket or just reference this one when I make my pull request?

> Pass correct value (timedelta or milliseconds) to Stats.timing ()
> -----------------------------------------------------------------
>
>                 Key: AIRFLOW-6088
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6088
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: scheduler
>    Affects Versions: 1.10.6
>            Reporter: Christoph Hösler
>            Assignee: Christoph Hösler
>            Priority: Minor
>             Fix For: 2.0.0
>
>
> DAG processing runtime metrics dag_processing.last_* are passed as a float value of seconds to the metrics client:
> [https://github.com/apache/airflow/blob/73bf718358c01cc41e5f23b914a8824a2665a28c/airflow/utils/dag_processing.py#L984]
>  
> The statsd client, however, expects either a duration object or milliseconds:
> [https://github.com/jsocol/pystatsd/blob/100046bcd349013d6d78922585621159a33d1ebb/statsd/client/base.py#L22]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)