You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Etienne Gagnon <eg...@sablevm.org> on 2006/04/02 01:21:31 UTC
Patches to fix java.lang [Was: Fixing java.lang]
Hi Geir,
So, it's time for me to learn, slowly, the customs of the Harmony
project. I'm ready to contribute the following 4 very modest patches.
FYI, I seeked the SerialVersionUIDs in Sun's public API:
http://java.sun.com/j2se/1.5.0/docs/api/serialized-form.html
What's the usual procedure? [both in the legal sense and the technical one]
Thanks for your patience helping a newbie,
Etienne
PS: I can make it into one patch. I am just trying to figure out the
desired granularity for contributions.
Magnusson, Geir wrote:
> Thanks for volunteering..... :)
--
Etienne M. Gagnon, Ph.D. http://www.info2.uqam.ca/~egagnon/
SableVM: http://www.sablevm.org/
SableCC: http://www.sablecc.org/
Re: Patches to fix java.lang [Was: Fixing java.lang]
Posted by Etienne Gagnon <eg...@sablevm.org>.
Thanks for the pointers and the guidance. Working on it. :-)
Etienne
Paulex Yang wrote:
> There are some helper classes on serialization test, which may make
> serialization testcases easier to create. hmmm..., in fact, *some* here
> means two, which come with contributions of different components from
> different ones, and people here haven't decided how to merge them:-(.
> One[1] is a abstract test case, which can be extended to create
> customized serialization test, the other[2] provides some util methods.
> IMO, both are handy, and you can choose any of them, and maybe provide
> some good suggestions on the merge issue.
>
> [1]
> http://svn.apache.org/viewcvs.cgi/incubator/harmony/enhanced/classlib/trunk/modules/security/test/common/unit/org/apache/harmony/security/test/SerializationTest.java?rev=378448&view=markup
>
> [2]
> http://svn.apache.org/viewcvs.cgi/incubator/harmony/enhanced/classlib/trunk/support/src/test/java/tests/util/SerializationTester.java?rev=386058&view=markup
>
> Tim Ellison wrote:
>>
>> It would be helpful if you could also include a regression test case to
>> ensure that the serialized form is the same as the reference
>> implementation. We do that by storing the serialized form of an object
>> as written using the reference implementation.
--
Etienne M. Gagnon, Ph.D. http://www.info2.uqam.ca/~egagnon/
SableVM: http://www.sablevm.org/
SableCC: http://www.sablecc.org/
Re: Patches to fix java.lang [Was: Fixing java.lang]
Posted by Paulex Yang <pa...@gmail.com>.
Etienne,
FYI,
There are some helper classes on serialization test, which may make
serialization testcases easier to create. hmmm..., in fact, *some* here
means two, which come with contributions of different components from
different ones, and people here haven't decided how to merge them:-(.
One[1] is a abstract test case, which can be extended to create
customized serialization test, the other[2] provides some util methods.
IMO, both are handy, and you can choose any of them, and maybe provide
some good suggestions on the merge issue.
[1]
http://svn.apache.org/viewcvs.cgi/incubator/harmony/enhanced/classlib/trunk/modules/security/test/common/unit/org/apache/harmony/security/test/SerializationTest.java?rev=378448&view=markup
[2]
http://svn.apache.org/viewcvs.cgi/incubator/harmony/enhanced/classlib/trunk/support/src/test/java/tests/util/SerializationTester.java?rev=386058&view=markup
Tim Ellison wrote:
> Etienne,
>
> It would be helpful if you could also include a regression test case to
> ensure that the serialized form is the same as the reference
> implementation. We do that by storing the serialized form of an object
> as written using the reference implementation.
>
> Regards,
> Tim
>
> Etienne Gagnon wrote:
>
>> Hi Geir,
>>
>> So, it's time for me to learn, slowly, the customs of the Harmony
>> project. I'm ready to contribute the following 4 very modest patches.
>>
>> FYI, I seeked the SerialVersionUIDs in Sun's public API:
>> http://java.sun.com/j2se/1.5.0/docs/api/serialized-form.html
>>
>> What's the usual procedure? [both in the legal sense and the technical one]
>>
>> Thanks for your patience helping a newbie,
>>
>> Etienne
>>
>> PS: I can make it into one patch. I am just trying to figure out the
>> desired granularity for contributions.
>>
>> Magnusson, Geir wrote:
>>
>>> Thanks for volunteering..... :)
>>>
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> Index: modules/luni/src/main/java/java/lang/IllegalArgumentException.java
>> ===================================================================
>> --- modules/luni/src/main/java/java/lang/IllegalArgumentException.java (revision 390759)
>> +++ modules/luni/src/main/java/java/lang/IllegalArgumentException.java (working copy)
>> @@ -22,6 +22,8 @@
>> */
>> public class IllegalArgumentException extends RuntimeException {
>>
>> + private static final long serialVersionUID = -5365630128856068164L;
>> +
>> /**
>> * Constructs a new instance of this class with its walkback filled in.
>> */
>>
>>
>> ------------------------------------------------------------------------
>>
>> Index: modules/luni/src/main/java/java/lang/IllegalStateException.java
>> ===================================================================
>> --- modules/luni/src/main/java/java/lang/IllegalStateException.java (revision 390759)
>> +++ modules/luni/src/main/java/java/lang/IllegalStateException.java (working copy)
>> @@ -22,6 +22,8 @@
>> */
>> public class IllegalStateException extends RuntimeException {
>>
>> + private static final long serialVersionUID = -1848914673093119416L;
>> +
>> /**
>> * Constructs a new instance of this class with its walkback filled in.
>> */
>>
>>
>> ------------------------------------------------------------------------
>>
>> Index: modules/luni/src/main/java/java/lang/SecurityException.java
>> ===================================================================
>> --- modules/luni/src/main/java/java/lang/SecurityException.java (revision 390759)
>> +++ modules/luni/src/main/java/java/lang/SecurityException.java (working copy)
>> @@ -21,6 +21,8 @@
>> */
>> public class SecurityException extends java.lang.RuntimeException {
>>
>> + private static final long serialVersionUID = 6878364983674394167L;
>> +
>> /**
>> * Constructs a new instance of this class with its walkback filled in.
>> */
>>
>>
>> ------------------------------------------------------------------------
>>
>> Index: modules/luni/src/main/java/java/lang/UnsupportedOperationException.java
>> ===================================================================
>> --- modules/luni/src/main/java/java/lang/UnsupportedOperationException.java (revision 390759)
>> +++ modules/luni/src/main/java/java/lang/UnsupportedOperationException.java (working copy)
>> @@ -21,6 +21,8 @@
>> */
>> public class UnsupportedOperationException extends RuntimeException {
>>
>> + private static final long serialVersionUID = -1242599979055084673L;
>> +
>> /**
>> * Constructs a new instance of this class with its walkback filled in.
>> */
>>
>
>
--
Paulex Yang
China Software Development Lab
IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: Patches to fix java.lang [Was: Fixing java.lang]
Posted by Tim Ellison <t....@gmail.com>.
Etienne,
It would be helpful if you could also include a regression test case to
ensure that the serialized form is the same as the reference
implementation. We do that by storing the serialized form of an object
as written using the reference implementation.
Regards,
Tim
Etienne Gagnon wrote:
> Hi Geir,
>
> So, it's time for me to learn, slowly, the customs of the Harmony
> project. I'm ready to contribute the following 4 very modest patches.
>
> FYI, I seeked the SerialVersionUIDs in Sun's public API:
> http://java.sun.com/j2se/1.5.0/docs/api/serialized-form.html
>
> What's the usual procedure? [both in the legal sense and the technical one]
>
> Thanks for your patience helping a newbie,
>
> Etienne
>
> PS: I can make it into one patch. I am just trying to figure out the
> desired granularity for contributions.
>
> Magnusson, Geir wrote:
>> Thanks for volunteering..... :)
>
>
>
> ------------------------------------------------------------------------
>
> Index: modules/luni/src/main/java/java/lang/IllegalArgumentException.java
> ===================================================================
> --- modules/luni/src/main/java/java/lang/IllegalArgumentException.java (revision 390759)
> +++ modules/luni/src/main/java/java/lang/IllegalArgumentException.java (working copy)
> @@ -22,6 +22,8 @@
> */
> public class IllegalArgumentException extends RuntimeException {
>
> + private static final long serialVersionUID = -5365630128856068164L;
> +
> /**
> * Constructs a new instance of this class with its walkback filled in.
> */
>
>
> ------------------------------------------------------------------------
>
> Index: modules/luni/src/main/java/java/lang/IllegalStateException.java
> ===================================================================
> --- modules/luni/src/main/java/java/lang/IllegalStateException.java (revision 390759)
> +++ modules/luni/src/main/java/java/lang/IllegalStateException.java (working copy)
> @@ -22,6 +22,8 @@
> */
> public class IllegalStateException extends RuntimeException {
>
> + private static final long serialVersionUID = -1848914673093119416L;
> +
> /**
> * Constructs a new instance of this class with its walkback filled in.
> */
>
>
> ------------------------------------------------------------------------
>
> Index: modules/luni/src/main/java/java/lang/SecurityException.java
> ===================================================================
> --- modules/luni/src/main/java/java/lang/SecurityException.java (revision 390759)
> +++ modules/luni/src/main/java/java/lang/SecurityException.java (working copy)
> @@ -21,6 +21,8 @@
> */
> public class SecurityException extends java.lang.RuntimeException {
>
> + private static final long serialVersionUID = 6878364983674394167L;
> +
> /**
> * Constructs a new instance of this class with its walkback filled in.
> */
>
>
> ------------------------------------------------------------------------
>
> Index: modules/luni/src/main/java/java/lang/UnsupportedOperationException.java
> ===================================================================
> --- modules/luni/src/main/java/java/lang/UnsupportedOperationException.java (revision 390759)
> +++ modules/luni/src/main/java/java/lang/UnsupportedOperationException.java (working copy)
> @@ -21,6 +21,8 @@
> */
> public class UnsupportedOperationException extends RuntimeException {
>
> + private static final long serialVersionUID = -1242599979055084673L;
> +
> /**
> * Constructs a new instance of this class with its walkback filled in.
> */
--
Tim Ellison (t.p.ellison@gmail.com)
IBM Java technology centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
Re: Patches to fix java.lang [Was: Fixing java.lang]
Posted by Etienne Gagnon <eg...@sablevm.org>.
Thanks, Nathan.
I've opened HARMONY-290 in the bug database. :-)
Etienne
Nathan Beyer wrote:
> Here's what I do for patch submissions:
>...
--
Etienne M. Gagnon, Ph.D. http://www.info2.uqam.ca/~egagnon/
SableVM: http://www.sablevm.org/
SableCC: http://www.sablecc.org/
RE: Patches to fix java.lang [Was: Fixing java.lang]
Posted by Nathan Beyer <nb...@kc.rr.com>.
Here's what I do for patch submissions:
* Create a JIRA issue for the Harmony project at [1].
* Attach the patch file to the issue; make sure to select the "Grant ASF..."
radio button.
* Wait for a committer to take assignment of the issue, verify it (run
tests, etc) and check it in.
* Once checked in, check out the code and make sure it looks good.
As for the actual patch file, I try to keep them to a single file, unless
there are completely new files.
[1] https://issues.apache.org/jira/browse/HARMONY
-----Original Message-----
From: Etienne Gagnon [mailto:egagnon@sablevm.org]
Sent: Saturday, April 01, 2006 5:22 PM
To: harmony-dev@incubator.apache.org
Subject: Patches to fix java.lang [Was: Fixing java.lang]
Hi Geir,
So, it's time for me to learn, slowly, the customs of the Harmony
project. I'm ready to contribute the following 4 very modest patches.
FYI, I seeked the SerialVersionUIDs in Sun's public API:
http://java.sun.com/j2se/1.5.0/docs/api/serialized-form.html
What's the usual procedure? [both in the legal sense and the technical one]
Thanks for your patience helping a newbie,
Etienne
PS: I can make it into one patch. I am just trying to figure out the
desired granularity for contributions.
Magnusson, Geir wrote:
> Thanks for volunteering..... :)
--
Etienne M. Gagnon, Ph.D. http://www.info2.uqam.ca/~egagnon/
SableVM: http://www.sablevm.org/
SableCC: http://www.sablecc.org/
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org