You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/02/06 01:48:43 UTC
[GitHub] [cassandra] ptbannister commented on a change in pull request #438:
CASSANDRA-10190: Python 2/3 compatibility for cqlsh
ptbannister commented on a change in pull request #438: CASSANDRA-10190: Python 2/3 compatibility for cqlsh
URL: https://github.com/apache/cassandra/pull/438#discussion_r375603889
##########
File path: bin/cqlsh.py
##########
@@ -140,10 +139,17 @@ def find_zip(libprefix):
if lib_zip:
sys.path.insert(0, lib_zip)
+import six
+
+from six.moves import configparser
+from six import StringIO
+from six.moves import input
+from six import ensure_text, ensure_str
Review comment:
These imports could be condensed:
```from six import StringIO, ensure_str, ensure_text
from six.moves import configparser, input```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org