You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/25 10:20:32 UTC
[GitHub] [pulsar] aahmed-se opened a new pull request #9719: [WIP] Make pulsar-function dependencies optional components
aahmed-se opened a new pull request #9719:
URL: https://github.com/apache/pulsar/pull/9719
* Currently the pulsar client install all packages for functions even if he user does want to use functions.
* We now make the function dependencies optional components.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se commented on a change in pull request #9719: Make pular python client dependencies optional components
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on a change in pull request #9719:
URL: https://github.com/apache/pulsar/pull/9719#discussion_r583928616
##########
File path: site2/docs/client-libraries-python.md
##########
@@ -22,12 +22,25 @@ To install the `pulsar-client` library as a pre-built package using the [pip](ht
$ pip install pulsar-client=={{pulsar:version_number}}
```
+### Optioanl dependencies
+
+To support aspects like pulsar functions and avro serialization additional optiopnal components can be installed alongside the `pulsar-client` library
+
+```shell
+# avro serialization
+$ pip install pulsar-client=='{{pulsar:version_number}}[avro]'
+# functions runtime
+$ pip install pulsar-client=='{{pulsar:version_number}}[functions]'
+# all optional components
Review comment:
fixed
##########
File path: site2/docs/client-libraries-python.md
##########
@@ -22,12 +22,25 @@ To install the `pulsar-client` library as a pre-built package using the [pip](ht
$ pip install pulsar-client=={{pulsar:version_number}}
```
+### Optioanl dependencies
+
+To support aspects like pulsar functions and avro serialization additional optiopnal components can be installed alongside the `pulsar-client` library
Review comment:
fixed
##########
File path: site2/docs/client-libraries-python.md
##########
@@ -22,12 +22,25 @@ To install the `pulsar-client` library as a pre-built package using the [pip](ht
$ pip install pulsar-client=={{pulsar:version_number}}
```
+### Optioanl dependencies
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se commented on a change in pull request #9719: Make pular python client dependencies optional components
Posted by GitBox <gi...@apache.org>.
aahmed-se commented on a change in pull request #9719:
URL: https://github.com/apache/pulsar/pull/9719#discussion_r583933409
##########
File path: site2/docs/client-libraries-python.md
##########
@@ -22,12 +22,25 @@ To install the `pulsar-client` library as a pre-built package using the [pip](ht
$ pip install pulsar-client=={{pulsar:version_number}}
```
+### Optioanl dependencies
+
+To support aspects like pulsar functions and avro serialization additional optiopnal components can be installed alongside the `pulsar-client` library
+
+```shell
+# avro serialization
+$ pip install pulsar-client=='{{pulsar:version_number}}[avro]'
+# functions runtime
+$ pip install pulsar-client=='{{pulsar:version_number}}[functions]'
+# all optional components
Review comment:
fixed
##########
File path: site2/docs/client-libraries-python.md
##########
@@ -22,12 +22,25 @@ To install the `pulsar-client` library as a pre-built package using the [pip](ht
$ pip install pulsar-client=={{pulsar:version_number}}
```
+### Optioanl dependencies
+
+To support aspects like pulsar functions and avro serialization additional optiopnal components can be installed alongside the `pulsar-client` library
Review comment:
fixed
##########
File path: site2/docs/client-libraries-python.md
##########
@@ -22,12 +22,25 @@ To install the `pulsar-client` library as a pre-built package using the [pip](ht
$ pip install pulsar-client=={{pulsar:version_number}}
```
+### Optioanl dependencies
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #9719: [WIP] Make pulsar-function dependencies optional components
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #9719:
URL: https://github.com/apache/pulsar/pull/9719#discussion_r582998921
##########
File path: pulsar-client-cpp/python/setup.py
##########
@@ -73,18 +73,24 @@ def build_extension(self, ext):
dependencies = [
'fastavro==0.24.0',
Review comment:
Avro also is not a lightweight dep and it's only needed if someone wants to use Avro schema. It could be moved to its own extra section
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #9719: [WIP] Make pulsar-function dependencies optional components
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #9719:
URL: https://github.com/apache/pulsar/pull/9719#discussion_r582998155
##########
File path: pulsar-client-cpp/python/setup.py
##########
@@ -73,18 +73,24 @@ def build_extension(self, ext):
dependencies = [
'fastavro==0.24.0',
- 'grpcio<1.28,>=1.8.2',
'protobuf>=3.6.1',
Review comment:
Protobuf should also only be needed by functions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #9719: Make pular python client dependencies optional components
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #9719:
URL: https://github.com/apache/pulsar/pull/9719#discussion_r583924438
##########
File path: site2/docs/client-libraries-python.md
##########
@@ -22,12 +22,25 @@ To install the `pulsar-client` library as a pre-built package using the [pip](ht
$ pip install pulsar-client=={{pulsar:version_number}}
```
+### Optioanl dependencies
+
+To support aspects like pulsar functions and avro serialization additional optiopnal components can be installed alongside the `pulsar-client` library
Review comment:
```suggestion
To support aspects like Pulsar functions or Avro serialization, additional optional components can be installed alongside the `pulsar-client` library
```
##########
File path: site2/docs/client-libraries-python.md
##########
@@ -22,12 +22,25 @@ To install the `pulsar-client` library as a pre-built package using the [pip](ht
$ pip install pulsar-client=={{pulsar:version_number}}
```
+### Optioanl dependencies
Review comment:
```suggestion
### Optional dependencies
```
##########
File path: site2/docs/client-libraries-python.md
##########
@@ -22,12 +22,25 @@ To install the `pulsar-client` library as a pre-built package using the [pip](ht
$ pip install pulsar-client=={{pulsar:version_number}}
```
+### Optioanl dependencies
+
+To support aspects like pulsar functions and avro serialization additional optiopnal components can be installed alongside the `pulsar-client` library
+
+```shell
+# avro serialization
+$ pip install pulsar-client=='{{pulsar:version_number}}[avro]'
+# functions runtime
+$ pip install pulsar-client=='{{pulsar:version_number}}[functions]'
+# all optional components
Review comment:
```suggestion
# functions runtime
$ pip install pulsar-client=='{{pulsar:version_number}}[functions]'
# all optional components
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] aahmed-se merged pull request #9719: Make pular python client dependencies optional components
Posted by GitBox <gi...@apache.org>.
aahmed-se merged pull request #9719:
URL: https://github.com/apache/pulsar/pull/9719
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on pull request #9719: Make pular python client dependencies optional components
Posted by GitBox <gi...@apache.org>.
merlimat commented on pull request #9719:
URL: https://github.com/apache/pulsar/pull/9719#issuecomment-787017003
cc/ @eolivelli
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org