You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/01/12 18:38:00 UTC

[GitHub] [netbeans] DevCharly opened a new pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style

DevCharly opened a new pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style
URL: https://github.com/apache/netbeans/pull/1865
 
 
   This PR implements FlatLaf style tabs for Multi-Tabs.
   
   Multi-Tabs are used in main window for editors when at least one of the marked options in the below screenshot are enabled. Otherwise another tab control is used, which was implemented in PR #1771
   
   ![image](https://user-images.githubusercontent.com/5604048/72222672-bd2d7d00-3567-11ea-8d83-2f3e777222e3.png)
   
   Multi-Tabs internally use a `JTable` for tab rendering and therefore do not support UI delegates.
   So it was necessary to extend Multi-Tabs for basic customizing. 
   
   Everything changed by this PR is controlled thru new values in UI defaults (`UIManager.get(...)`. Those UI defaults are not set in other LAFs. So other LAFs work as before.
   
   Each tab is painted as a simple filled rectangle and a "underline" bar. The "underline" bar placement depends on the tab placement. See screenshots below. There are separator lines between tabs if tab placement is "top" or "bottom". Hover effect is not supported by multi-tabs and can be implemented later.
   
   Thru UI values it is possible to change all colors, tab insets, and height of "underline" bar. By setting underline height to zero it can be hidden.
   
   Tab placement "top" and "multi-row tabs" enabled:
   ![image](https://user-images.githubusercontent.com/5604048/72222992-dd127000-356a-11ea-906a-2da3cc1a6b2c.png)
   
   Tab placement "top" and "show parent folder name" enabled:
   ![image](https://user-images.githubusercontent.com/5604048/72223001-ea2f5f00-356a-11ea-872d-b84436320ec9.png)
   
   Tab placement "bottom":
   ![image](https://user-images.githubusercontent.com/5604048/72223027-31b5eb00-356b-11ea-9089-69a73a73b302.png)
   
   Tab placement "left":
   ![image](https://user-images.githubusercontent.com/5604048/72223031-37abcc00-356b-11ea-9294-1aeb15a2d582.png)
   
   Tab placement "right":
   ![image](https://user-images.githubusercontent.com/5604048/72223023-29f64680-356b-11ea-95c4-7759ba9b4f7f.png)
   
   The "slight blue tint" of the tabs area indicates that this tab group is active. If a view is active/focused, then the editor tabs became gray and the view group tabs get a "slight blue tint". This makes it easier to see the active/focused editor/view.
   ![image](https://user-images.githubusercontent.com/5604048/72223375-5364a180-356e-11ea-9442-9e0bdf2b38b9.png)
   
   Same happens when editor area is split:
   ![image](https://user-images.githubusercontent.com/5604048/72223384-68d9cb80-356e-11ea-8cc6-87fd8ccd8a61.png)
   
   Light version with "same background color for files from same project" option enabled:
   ![image](https://user-images.githubusercontent.com/5604048/72223510-e3efb180-356f-11ea-9667-e78b6a227aee.png)
   
   Some "before" screenshots for comparison:
   
   ![image](https://user-images.githubusercontent.com/5604048/72223615-2239a080-3571-11ea-90fd-f185af00575b.png)
   
   ![image](https://user-images.githubusercontent.com/5604048/72223646-6b89f000-3571-11ea-841c-4b0011f03d3e.png)
   
   ![image](https://user-images.githubusercontent.com/5604048/72223599-e7376d00-3570-11ea-8244-d2492568458f.png)
   
   This screenshot shows a problem of basic Multi-Tabs: Which editor is the active one?
   ![image](https://user-images.githubusercontent.com/5604048/72223711-3c27b300-3572-11ea-881d-285cf7eb0429.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] eirikbakke commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style
URL: https://github.com/apache/netbeans/pull/1865#discussion_r365630432
 
 

 ##########
 File path: platform/core.multitabs/src/org/netbeans/core/multitabs/impl/ProjectColorTabDecorator.java
 ##########
 @@ -63,15 +62,27 @@ public void stateChanged(ChangeEvent e) {
 
     static {
         backGroundColors = new ArrayList<Color>( 10 );
-        backGroundColors.add( new Color( 216, 255, 237 ) );
-        backGroundColors.add( new Color( 255, 221, 221 ) );
-        backGroundColors.add( new Color( 255, 247, 214 ) );
-        backGroundColors.add( new Color( 216, 239, 255 ) );
-        backGroundColors.add( new Color( 241, 255, 209 ) );
-        backGroundColors.add( new Color( 255, 225, 209 ) );
-        backGroundColors.add( new Color( 228, 255, 216 ) );
-        backGroundColors.add( new Color( 227, 255, 158 ) );
-        backGroundColors.add( new Color( 238, 209, 255 ) );
+
+        // load background colors from UI defaults if available
+        if (UIManager.getColor("nb.multitabs.project.1.background") != null) {
+            for (int i = 1; i <= 100; i++) {
+                Color color = UIManager.getColor("nb.multitabs.project." + i + ".background");
 
 Review comment:
   Is this a gradient of some sort? Better to specify start and end colors, and interpolate, than have up to 100 properties. That will look better on HiDPI displays too (since you can actually get a smooth gradient rather than N hard steps).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] eirikbakke commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style
URL: https://github.com/apache/netbeans/pull/1865#discussion_r365630955
 
 

 ##########
 File path: platform/core.multitabs/src/org/netbeans/core/multitabs/impl/ProjectColorTabDecorator.java
 ##########
 @@ -63,15 +62,27 @@ public void stateChanged(ChangeEvent e) {
 
     static {
         backGroundColors = new ArrayList<Color>( 10 );
-        backGroundColors.add( new Color( 216, 255, 237 ) );
-        backGroundColors.add( new Color( 255, 221, 221 ) );
-        backGroundColors.add( new Color( 255, 247, 214 ) );
-        backGroundColors.add( new Color( 216, 239, 255 ) );
-        backGroundColors.add( new Color( 241, 255, 209 ) );
-        backGroundColors.add( new Color( 255, 225, 209 ) );
-        backGroundColors.add( new Color( 228, 255, 216 ) );
-        backGroundColors.add( new Color( 227, 255, 158 ) );
-        backGroundColors.add( new Color( 238, 209, 255 ) );
+
+        // load background colors from UI defaults if available
+        if (UIManager.getColor("nb.multitabs.project.1.background") != null) {
+            for (int i = 1; i <= 100; i++) {
+                Color color = UIManager.getColor("nb.multitabs.project." + i + ".background");
 
 Review comment:
   And you probably don't need to do the interpolation yourself... there's Graphics2D.setPaint(new GradientPaint(...))

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] eirikbakke commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style
URL: https://github.com/apache/netbeans/pull/1865#discussion_r365630302
 
 

 ##########
 File path: platform/core.multitabs/src/org/netbeans/core/multitabs/impl/ControlsToolbar.java
 ##########
 @@ -58,6 +58,7 @@ public void updateUI() {
     private void configure() {
         setFloatable( false );
         setFocusable( false );
+        setOpaque( false );
 
 Review comment:
   Did you check to make sure this did not cause problems in other LAFs?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] DevCharly commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style

Posted by GitBox <gi...@apache.org>.
DevCharly commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style
URL: https://github.com/apache/netbeans/pull/1865#discussion_r367996329
 
 

 ##########
 File path: platform/core.multitabs/src/org/netbeans/core/multitabs/impl/ControlsToolbar.java
 ##########
 @@ -58,6 +58,7 @@ public void updateUI() {
     private void configure() {
         setFloatable( false );
         setFocusable( false );
+        setOpaque( false );
 
 Review comment:
   Yes, tested with Window, Mac, Nimbus and Metal LaFs. `ControlsToolbar` is a package private class and only used in in `AbstractTabDisplayer`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] lkishalmi merged pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style

Posted by GitBox <gi...@apache.org>.
lkishalmi merged pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style
URL: https://github.com/apache/netbeans/pull/1865
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] lkishalmi commented on issue #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on issue #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style
URL: https://github.com/apache/netbeans/pull/1865#issuecomment-573504338
 
 
   I like the blue tint of the entire tab group. With that, I find it easier to locate the focused component. That might be really subjective, however, when I discovered, I had that feeling. Maybe I'm getting older and my eye is not as pixel sharp as it used to be...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] DevCharly commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style

Posted by GitBox <gi...@apache.org>.
DevCharly commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style
URL: https://github.com/apache/netbeans/pull/1865#discussion_r367996423
 
 

 ##########
 File path: platform/core.multitabs/src/org/netbeans/core/multitabs/impl/TabDataRenderer.java
 ##########
 @@ -48,6 +53,12 @@
  */
 public class TabDataRenderer implements TableCellRenderer {
 
+    private static final Insets tabInsets = UIManager.getInsets("nb.multitabs.tabInsets"); // NOI18N
+    private static final int underlineHeight = UIManager.getInt("nb.multitabs.underlineHeight"); // NOI18N
+    private static final Color underlineColor = UIManager.getColor("nb.multitabs.underlineColor"); // NOI18N
+    private static final Color inactiveUnderlineColor = UIManager.getColor("nb.multitabs.inactiveUnderlineColor"); // NOI18N
+    private static final Color activeBackground = UIManager.getColor("nb.multitabs.activeBackground"); // NOI18N
 
 Review comment:
   Yes, I've searched in the multitabs modules for other keys, which mostly use "nb.multitabs." as prefix. So I used the same prefix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] eirikbakke commented on issue #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style
URL: https://github.com/apache/netbeans/pull/1865#issuecomment-573509021
 
 
   If the entire focused tab was made blue, it would be easier to spot. This screenshot looks great to me: https://user-images.githubusercontent.com/5604048/72223615-2239a080-3571-11ea-90fd-f185af00575b.png (except for the lack of tab borders in the "Projects"/"Files" and "Navigator" groups)
   
   If you can see which _tab_ is active, then you obviously know which tab group is active.
   
   Also, I suspect most people have just one editor tab group open--so there will just be a constant blueish rectangle on the screen all the time.
   
   But of course, the people who do the work get to make the final call :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] eirikbakke commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style
URL: https://github.com/apache/netbeans/pull/1865#discussion_r368006792
 
 

 ##########
 File path: platform/core.multitabs/src/org/netbeans/core/multitabs/impl/TabDataRenderer.java
 ##########
 @@ -48,6 +53,12 @@
  */
 public class TabDataRenderer implements TableCellRenderer {
 
+    private static final Insets tabInsets = UIManager.getInsets("nb.multitabs.tabInsets"); // NOI18N
+    private static final int underlineHeight = UIManager.getInt("nb.multitabs.underlineHeight"); // NOI18N
+    private static final Color underlineColor = UIManager.getColor("nb.multitabs.underlineColor"); // NOI18N
+    private static final Color inactiveUnderlineColor = UIManager.getColor("nb.multitabs.inactiveUnderlineColor"); // NOI18N
+    private static final Color activeBackground = UIManager.getColor("nb.multitabs.activeBackground"); // NOI18N
 
 Review comment:
   Good.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] DevCharly commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style

Posted by GitBox <gi...@apache.org>.
DevCharly commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style
URL: https://github.com/apache/netbeans/pull/1865#discussion_r368000474
 
 

 ##########
 File path: platform/core.multitabs/src/org/netbeans/core/multitabs/impl/ProjectColorTabDecorator.java
 ##########
 @@ -63,15 +62,27 @@ public void stateChanged(ChangeEvent e) {
 
     static {
         backGroundColors = new ArrayList<Color>( 10 );
-        backGroundColors.add( new Color( 216, 255, 237 ) );
-        backGroundColors.add( new Color( 255, 221, 221 ) );
-        backGroundColors.add( new Color( 255, 247, 214 ) );
-        backGroundColors.add( new Color( 216, 239, 255 ) );
-        backGroundColors.add( new Color( 241, 255, 209 ) );
-        backGroundColors.add( new Color( 255, 225, 209 ) );
-        backGroundColors.add( new Color( 228, 255, 216 ) );
-        backGroundColors.add( new Color( 227, 255, 158 ) );
-        backGroundColors.add( new Color( 238, 209, 255 ) );
+
+        // load background colors from UI defaults if available
+        if (UIManager.getColor("nb.multitabs.project.1.background") != null) {
+            for (int i = 1; i <= 100; i++) {
+                Color color = UIManager.getColor("nb.multitabs.project." + i + ".background");
 
 Review comment:
   > Is this a gradient of some sort?
   
   No, NetBeans has an option "same background color for files from same project" that paints tabs in different colors. Each open project gets its own color. The used colors are hardcoded into `ProjectColorTabDecorator` and work good with light LAFs, but not with dark LAFs. So I've added a way to get those colors from [UI defaults](https://github.com/DevCharly/netbeans/blob/d3c9d24efe5b8e48b19c91795c19e99354d8c9bd/platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/FlatDarkLaf.properties#L68-L76).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] eirikbakke commented on issue #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on issue #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style
URL: https://github.com/apache/netbeans/pull/1865#issuecomment-573484942
 
 
   Great, more flatLAF!
   
   > The "slight blue tint" of the tabs area indicates that this tab group is active. If a view is active/focused, then the editor tabs became gray and the view group tabs get a "slight blue tint". This makes it easier to see the active/focused editor/view.
   > This screenshot shows a problem of basic Multi-Tabs: Which editor is the active one?
   
   Why does the entire tab group need to get a different color, and not just the focused tab? In the non-multi-tab case, both the Aqua and Windows 8 LAFs simply give the focused tab a different color. See screenshot:
   
   ![which_tab_group_is_selected_indication](https://user-images.githubusercontent.com/886243/72229634-1a342d80-357e-11ea-9c6d-17e17c27e6b9.png)
   
   Is there something about the multi-tabs setting that makes this infeasible?
   
   I also prefer the more compact tabs shown in https://user-images.githubusercontent.com/5604048/72223615-2239a080-3571-11ea-90fd-f185af00575b.png .
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] eirikbakke commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style
URL: https://github.com/apache/netbeans/pull/1865#discussion_r368006672
 
 

 ##########
 File path: platform/core.multitabs/src/org/netbeans/core/multitabs/impl/ProjectColorTabDecorator.java
 ##########
 @@ -63,15 +62,27 @@ public void stateChanged(ChangeEvent e) {
 
     static {
         backGroundColors = new ArrayList<Color>( 10 );
-        backGroundColors.add( new Color( 216, 255, 237 ) );
-        backGroundColors.add( new Color( 255, 221, 221 ) );
-        backGroundColors.add( new Color( 255, 247, 214 ) );
-        backGroundColors.add( new Color( 216, 239, 255 ) );
-        backGroundColors.add( new Color( 241, 255, 209 ) );
-        backGroundColors.add( new Color( 255, 225, 209 ) );
-        backGroundColors.add( new Color( 228, 255, 216 ) );
-        backGroundColors.add( new Color( 227, 255, 158 ) );
-        backGroundColors.add( new Color( 238, 209, 255 ) );
+
+        // load background colors from UI defaults if available
+        if (UIManager.getColor("nb.multitabs.project.1.background") != null) {
+            for (int i = 1; i <= 100; i++) {
+                Color color = UIManager.getColor("nb.multitabs.project." + i + ".background");
 
 Review comment:
   Ah, makes sense.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] eirikbakke commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style

Posted by GitBox <gi...@apache.org>.
eirikbakke commented on a change in pull request #1865: [NETBEANS-3428] FlatLaf: multi-tabs in FlatLaf style
URL: https://github.com/apache/netbeans/pull/1865#discussion_r365630617
 
 

 ##########
 File path: platform/core.multitabs/src/org/netbeans/core/multitabs/impl/TabDataRenderer.java
 ##########
 @@ -48,6 +53,12 @@
  */
 public class TabDataRenderer implements TableCellRenderer {
 
+    private static final Insets tabInsets = UIManager.getInsets("nb.multitabs.tabInsets"); // NOI18N
+    private static final int underlineHeight = UIManager.getInt("nb.multitabs.underlineHeight"); // NOI18N
+    private static final Color underlineColor = UIManager.getColor("nb.multitabs.underlineColor"); // NOI18N
+    private static final Color inactiveUnderlineColor = UIManager.getColor("nb.multitabs.inactiveUnderlineColor"); // NOI18N
+    private static final Color activeBackground = UIManager.getColor("nb.multitabs.activeBackground"); // NOI18N
 
 Review comment:
   As before, when adding UIManager keys, I assume that you feel confident that they new keys are needed, and that you've figured out what the naming convention is for them...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists