[jira] Issue Comment Edited: (HADOOP-2796) For script option hod should exit with distinguishable exit codes for script code and hod exit code.

["Vinod Kumar Vavilapalli (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581051#action_12581051 ] 

vinodkv edited comment on HADOOP-2796 at 3/21/08 3:46 AM:
--------------------------------------------------------------------------

+1 for the proposal.

However, there is one problem with a corner case. If we do the following:
   * first run a script which returns with an error(and so the script.exitcode file exists once "hod script" command finishes),
   * and then run another "hod script" with the same cluster directory, but with invalid options (say --hod.nodecount=abc),
the script.exitcode file will still be around, and hod returns a non-zero exit code; implying(incorrectly) that the script ran and returned with an error, which in actuality is not the case.

Other than that, tested the rest of the cases successfully.

Barring the corner case, +1 for the fix in general.

      was (Author: vinodkv):
    +1 for the proposal.

However, there is one problem with a corner case. If we do the following:
   * first run a which returns an error(and so the script.exitcode file exists once "hod script" command finishes),
   * and then run another "hod script" with the same cluster directory, but with invalid options (say --hod.nodecount=abc),
the script.exitcode file will still be around, and hod returns a nonzero exit code; implying(incorrectly) that the script ran and returned an error, which in actuality is not the case.

Other than that, tested the rest of the cases successfully.

Barring the corner case, +1 for the fix in general.
  
> For script option hod should exit with distinguishable exit codes for script code and hod exit code.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-2796
>                 URL: https://issues.apache.org/jira/browse/HADOOP-2796
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hod
>    Affects Versions: 0.16.0
>            Reporter: Karam Singh
>            Assignee: Hemanth Yamijala
>             Fix For: 0.17.0
>
>         Attachments: 2796.patch
>
>
> For hod script option, the exit code should distinguishable between hod exit code and script exit code.
> e.g.
> If script command contains the streaming command at end and that fails due to input path not found, its value exit cod will 5 which overlaps with hod exit code 5 which means "job execution failure"
> It would hod throws some distinguishable exit codes 
> e.g
> For above examples 64 +5 =69 and we should this to get exact exit code of hod script command user should subtract 64 from exit code 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.