You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by ru...@apache.org on 2019/08/01 17:49:14 UTC

[whimsy] branch master updated: add nonpmcs with member lists

This is an automated email from the ASF dual-hosted git repository.

rubys pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 1970e48  add nonpmcs with member lists
1970e48 is described below

commit 1970e485c8f418da4236f9803d917d7482854722
Author: Sam Ruby <ru...@intertwingly.net>
AuthorDate: Thu Aug 1 13:48:50 2019 -0400

    add nonpmcs with member lists
---
 www/officers/acreq.cgi | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/www/officers/acreq.cgi b/www/officers/acreq.cgi
index eb356bb..7c379f0 100755
--- a/www/officers/acreq.cgi
+++ b/www/officers/acreq.cgi
@@ -33,12 +33,16 @@ iclas_txt = `#{SVN} cat #{OFFICERS}/iclas.txt`.force_encoding('utf-8')
 # grab the current list of PMCs from ldap
 pmcs = ASF::Committee.pmcs.map(&:name).sort
 
+# grab the current list of nonPMCs with member lists from ldap
+nonpmcs = ASF::Committee.nonpmcs.map(&:name).
+  select {|name| not ASF::Project.find(name).members.empty?}
+
 # grab the list of active podlings
 podlings = ASF::Podling.list.select {|podling| podling.status == 'current'}.
   map(&:name).sort
 
 # combined list of pmcs and projects
-projects = (pmcs + podlings).uniq.sort
+projects = (pmcs + podlings + nonpmcs).uniq.sort
 
 # grab the list of iclas that have no ids assigned
 query = CGI::parse ENV['QUERY_STRING']


Re: [whimsy] branch master updated: add nonpmcs with member lists

Posted by sebb <se...@gmail.com>.
On Thu, 1 Aug 2019 at 18:49, <ru...@apache.org> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> rubys pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/whimsy.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>      new 1970e48  add nonpmcs with member lists
> 1970e48 is described below
>
> commit 1970e485c8f418da4236f9803d917d7482854722
> Author: Sam Ruby <ru...@intertwingly.net>
> AuthorDate: Thu Aug 1 13:48:50 2019 -0400
>
>     add nonpmcs with member lists
> ---
>  www/officers/acreq.cgi | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/www/officers/acreq.cgi b/www/officers/acreq.cgi
> index eb356bb..7c379f0 100755
> --- a/www/officers/acreq.cgi
> +++ b/www/officers/acreq.cgi
> @@ -33,12 +33,16 @@ iclas_txt = `#{SVN} cat #{OFFICERS}/iclas.txt`.force_encoding('utf-8')
>  # grab the current list of PMCs from ldap
>  pmcs = ASF::Committee.pmcs.map(&:name).sort
>
> +# grab the current list of nonPMCs with member lists from ldap
> +nonpmcs = ASF::Committee.nonpmcs.map(&:name).
> +  select {|name| not ASF::Project.find(name).members.empty?}

Might be better to use

 select {|name| ASF::Project.find(name).hasLDAP?}

as that does not rely on the members never being empty for a valid LDAP entity.

[or at least avoid the negative condition by using: reject {|name|
ASF::Project.find(name).members.empty?}]



> +
>  # grab the list of active podlings
>  podlings = ASF::Podling.list.select {|podling| podling.status == 'current'}.
>    map(&:name).sort
>
>  # combined list of pmcs and projects
> -projects = (pmcs + podlings).uniq.sort
> +projects = (pmcs + podlings + nonpmcs).uniq.sort
>
>  # grab the list of iclas that have no ids assigned
>  query = CGI::parse ENV['QUERY_STRING']
>