[jira] [Comment Edited] (HBASE-21666) Break up the TestExportSnapshot UTs; they can timeout

["Tak Lon (Stephen) Wu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-21666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752515#comment-16752515 ] 

Tak Lon (Stephen) Wu edited comment on HBASE-21666 at 1/25/19 6:49 PM:
-----------------------------------------------------------------------

I'd like to give a try because I saw similar issue before.
{code:java}
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.snapshot.TestExportSnapshot


[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 783.052 s <<< FAILURE! - in org.apache.hadoop.hbase.snapshot.TestExportSnapshot
[ERROR] org.apache.hadoop.hbase.snapshot.TestExportSnapshot  Time elapsed: 729.295 s  <<< ERROR!
org.junit.runners.model.TestTimedOutException: test timed out after 780 seconds
	at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:230)
	at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:202)
	at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:195)
	at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportWithTargetName(TestExportSnapshot.java:190)
{code}
So just want to confirm the few items:
 * I tested it on master branch, do you guys see this is also a problem in branch-2?
 * I'm wondered if you have any concern if I break them in to separate classes per test and refactor the common part into a base class? e.g. {{testExportWithTargetName}} -> {{TestExportSnapshotWithTargetName}} ?
 ** Updates: AFA my tests, {{TestExportSnapshot#testExportFileSystemState}} which calls {{run(conf, new ExportSnapshot(), opts.toArray(new String[opts.size()]));}} seems to be the root of the slowness, still investigating.

 

Please let me know if you have any concerns.


was (Author: taklwu):
I'd like to give a try because I saw similar issue before.
{code:java}
[INFO] -------------------------------------------------------
[INFO] Running org.apache.hadoop.hbase.snapshot.TestExportSnapshot


[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 783.052 s <<< FAILURE! - in org.apache.hadoop.hbase.snapshot.TestExportSnapshot
[ERROR] org.apache.hadoop.hbase.snapshot.TestExportSnapshot  Time elapsed: 729.295 s  <<< ERROR!
org.junit.runners.model.TestTimedOutException: test timed out after 780 seconds
	at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:230)
	at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:202)
	at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportFileSystemState(TestExportSnapshot.java:195)
	at org.apache.hadoop.hbase.snapshot.TestExportSnapshot.testExportWithTargetName(TestExportSnapshot.java:190)
{code}
So just want to confirm the few items:
 1. I tested it on master branch, do you guys see this is also a problem in branch-2?
 2. I'm wondered if you have any concern if I break them in to separate classes per test and refactor the common part into a base class? e.g. {{testExportWithTargetName}} -> {{TestExportSnapshotWithTargetName}} ?

Please let me know if you have any concerns.

> Break up the TestExportSnapshot UTs; they can timeout
> -----------------------------------------------------
>
>                 Key: HBASE-21666
>                 URL: https://issues.apache.org/jira/browse/HBASE-21666
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: stack
>            Assignee: Tak Lon (Stephen) Wu
>            Priority: Major
>              Labels: beginner
>
> These timed out for [~Apache9] when he ran with the -PrunAllTests. Suggests breaking them up into smaller tests so less likely they'll timeout.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)