You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Bernardo Gomez Palacio <be...@gmail.com> on 2014/05/05 20:36:59 UTC
Re: Review Request 21083: [MESOS-1259:MESOS-1294]:Enrich the Java Docs in
the src/java files. -- State.java
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21083/
-----------------------------------------------------------
(Updated May 5, 2014, 6:36 p.m.)
Review request for mesos and Mesos ReviewBot.
Changes
-------
Added as a subtask of MESOS-1259
Summary (updated)
-----------------
[MESOS-1259:MESOS-1294]:Enrich the Java Docs in the src/java files. -- State.java
Bugs: MESOS-1294
https://issues.apache.org/jira/browse/MESOS-1294
Repository: mesos-git
Description
-------
[MESOS-1259]:Enrich the Java Docs in the src/java files. -- State.java
Diffs
-----
src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
Diff: https://reviews.apache.org/r/21083/diff/
Testing
-------
1. ./bootstrap && mkdir build && cd build && ../configure && make
2. cd src/java/target/apidocs
3. Open index.html in your browser. i.e. open index.html
4. Verify the Executor API.
Thanks,
Bernardo Gomez Palacio
Re: Review Request 21083: [MESOS-1259:MESOS-1294]:Enrich the Java Docs in
the src/java files. -- State.java
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21083/#review42432
-----------------------------------------------------------
Patch looks great!
Reviews applied: [21083]
All tests passed.
- Mesos ReviewBot
On May 5, 2014, 6:36 p.m., Bernardo Gomez Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21083/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 6:36 p.m.)
>
>
> Review request for mesos and Mesos ReviewBot.
>
>
> Bugs: MESOS-1294
> https://issues.apache.org/jira/browse/MESOS-1294
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [MESOS-1259]:Enrich the Java Docs in the src/java files. -- State.java
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
>
> Diff: https://reviews.apache.org/r/21083/diff/
>
>
> Testing
> -------
>
> 1. ./bootstrap && mkdir build && cd build && ../configure && make
> 2. cd src/java/target/apidocs
> 3. Open index.html in your browser. i.e. open index.html
> 4. Verify the Executor API.
>
>
> Thanks,
>
> Bernardo Gomez Palacio
>
>
Re: Review Request 21083: [MESOS-1259:MESOS-1294]:Enrich the Java Docs in
the src/java files. -- State.java
Posted by Bernardo Gomez Palacio <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21083/
-----------------------------------------------------------
(Updated May 15, 2014, 8:57 p.m.)
Review request for mesos and Mesos ReviewBot.
Bugs: MESOS-1294
https://issues.apache.org/jira/browse/MESOS-1294
Repository: mesos-git
Description
-------
[MESOS-1259]:Enrich the Java Docs in the src/java files. -- State.java
Diffs (updated)
-----
src/java/src/org/apache/mesos/Executor.java cacb4e912cd44c5f6feb4a9920f4506e2399dcb7
src/java/src/org/apache/mesos/ExecutorDriver.java 56345dfb531492b32e032611e6fb8e68b234c5cc
src/java/src/org/apache/mesos/Log.java d27e4f9e226f1aa5588cf75cb8c0a117dbf3015d
src/java/src/org/apache/mesos/MesosExecutorDriver.java ce146cdb33b3c80ea43866d304b3f1ff1a3e7c00
src/java/src/org/apache/mesos/MesosSchedulerDriver.java 3fd1eb55468765cd9e9dceec53a653f6455000a3
src/java/src/org/apache/mesos/Scheduler.java 3043f60f408e11f5dae4d1c01b51840d4d289ba3
src/java/src/org/apache/mesos/SchedulerDriver.java ae2d915d9afb3d35d42a24b56115a386ea960154
src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
src/java/src/org/apache/mesos/state/Variable.java 8e1ca69e673cedab8f05c53a376d6d421d09078b
Diff: https://reviews.apache.org/r/21083/diff/
Testing
-------
1. ./bootstrap && mkdir build && cd build && ../configure && make
2. cd src/java/target/apidocs
3. Open index.html in your browser. i.e. open index.html
4. Verify the Executor API.
Thanks,
Bernardo Gomez Palacio
Re: Review Request 21083: [MESOS-1259:MESOS-1294]:Enrich the Java Docs in
the src/java files. -- State.java
Posted by Niklas Nielsen <ni...@qni.dk>.
> On May 7, 2014, 1:18 p.m., Niklas Nielsen wrote:
> > src/java/src/org/apache/mesos/state/State.java, lines 55-57
> > <https://reviews.apache.org/r/21083/diff/1/?file=574751#file574751line55>
> >
> > Don't you want to align the @return and @param description here (and the two other comment blocks) like in http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html? :)
>
> Bernardo Gomez Palacio wrote:
> Agree, but are we all ok if I apply the same to all @return statements?
Sounds great! :) Thanks
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21083/#review42426
-----------------------------------------------------------
On May 5, 2014, 11:36 a.m., Bernardo Gomez Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21083/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 11:36 a.m.)
>
>
> Review request for mesos and Mesos ReviewBot.
>
>
> Bugs: MESOS-1294
> https://issues.apache.org/jira/browse/MESOS-1294
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [MESOS-1259]:Enrich the Java Docs in the src/java files. -- State.java
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
>
> Diff: https://reviews.apache.org/r/21083/diff/
>
>
> Testing
> -------
>
> 1. ./bootstrap && mkdir build && cd build && ../configure && make
> 2. cd src/java/target/apidocs
> 3. Open index.html in your browser. i.e. open index.html
> 4. Verify the Executor API.
>
>
> Thanks,
>
> Bernardo Gomez Palacio
>
>
Re: Review Request 21083: [MESOS-1259:MESOS-1294]:Enrich the Java Docs in
the src/java files. -- State.java
Posted by Bernardo Gomez Palacio <be...@gmail.com>.
> On May 7, 2014, 8:18 p.m., Niklas Nielsen wrote:
> > src/java/src/org/apache/mesos/state/State.java, lines 55-57
> > <https://reviews.apache.org/r/21083/diff/1/?file=574751#file574751line55>
> >
> > Don't you want to align the @return and @param description here (and the two other comment blocks) like in http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html? :)
Agree, but are we all ok if I apply the same to all @return statements?
- Bernardo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21083/#review42426
-----------------------------------------------------------
On May 5, 2014, 6:36 p.m., Bernardo Gomez Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21083/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 6:36 p.m.)
>
>
> Review request for mesos and Mesos ReviewBot.
>
>
> Bugs: MESOS-1294
> https://issues.apache.org/jira/browse/MESOS-1294
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [MESOS-1259]:Enrich the Java Docs in the src/java files. -- State.java
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
>
> Diff: https://reviews.apache.org/r/21083/diff/
>
>
> Testing
> -------
>
> 1. ./bootstrap && mkdir build && cd build && ../configure && make
> 2. cd src/java/target/apidocs
> 3. Open index.html in your browser. i.e. open index.html
> 4. Verify the Executor API.
>
>
> Thanks,
>
> Bernardo Gomez Palacio
>
>
Re: Review Request 21083: [MESOS-1259:MESOS-1294]:Enrich the Java
Docs in the src/java files. -- State.java
Posted by Niklas Nielsen <ni...@qni.dk>.
Hey Ben and Bernardo,
I'll get to it during this week. It's pretty crazy here too :-) Maybe Tobi
and Connor can chime in on the java doc style.
Cheers,
Niklas
On Mon, May 12, 2014 at 12:27 PM, Benjamin Mahler <benjamin.mahler@gmail.com
> wrote:
> Hey Niklas,
>
> Would you be able to help get all Bernardo's great Javadoc improvements
> reviewed and submitted? I'm pretty swamped as of late with 0.19.0 related
> things.
>
>
> On Wed, May 7, 2014 at 1:18 PM, Niklas Nielsen <ni...@qni.dk> wrote:
>
>>
>> -----------------------------------------------------------
>>
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/21083/#review42426
>> -----------------------------------------------------------
>>
>>
>>
>> src/java/src/org/apache/mesos/state/State.java
>> <https://reviews.apache.org/r/21083/#comment76189>
>>
>>
>> Don't you want to align the @return and @param description here (and
>> the two other comment blocks) like in
>> http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html?
>> :)
>>
>>
>> - Niklas Nielsen
>>
>>
>> On May 5, 2014, 11:36 a.m., Bernardo Gomez Palacio wrote:
>> >
>> > -----------------------------------------------------------
>> > This is an automatically generated e-mail. To reply, visit:
>> > https://reviews.apache.org/r/21083/
>> > -----------------------------------------------------------
>> >
>> > (Updated May 5, 2014, 11:36 a.m.)
>>
>> >
>> >
>> > Review request for mesos and Mesos ReviewBot.
>> >
>> >
>> > Bugs: MESOS-1294
>> > https://issues.apache.org/jira/browse/MESOS-1294
>> >
>> >
>> > Repository: mesos-git
>> >
>> >
>> > Description
>> > -------
>> >
>> > [MESOS-1259]:Enrich the Java Docs in the src/java files. -- State.java
>> >
>> >
>> > Diffs
>> > -----
>> >
>> > src/java/src/org/apache/mesos/state/State.java
>> d14d79b4850f677588c928803aba921030571fb8
>> >
>> > Diff: https://reviews.apache.org/r/21083/diff/
>> >
>> >
>> > Testing
>> > -------
>> >
>> > 1. ./bootstrap && mkdir build && cd build && ../configure && make
>> > 2. cd src/java/target/apidocs
>> > 3. Open index.html in your browser. i.e. open index.html
>> > 4. Verify the Executor API.
>> >
>> >
>> > Thanks,
>> >
>> > Bernardo Gomez Palacio
>> >
>> >
>>
>>
>
--
Niklas
Re: Review Request 21083: [MESOS-1259:MESOS-1294]:Enrich the Java
Docs in the src/java files. -- State.java
Posted by Benjamin Mahler <be...@gmail.com>.
Hey Niklas,
Would you be able to help get all Bernardo's great Javadoc improvements
reviewed and submitted? I'm pretty swamped as of late with 0.19.0 related
things.
On Wed, May 7, 2014 at 1:18 PM, Niklas Nielsen <ni...@qni.dk> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21083/#review42426
> -----------------------------------------------------------
>
>
>
> src/java/src/org/apache/mesos/state/State.java
> <https://reviews.apache.org/r/21083/#comment76189>
>
> Don't you want to align the @return and @param description here (and
> the two other comment blocks) like in
> http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html?
> :)
>
>
> - Niklas Nielsen
>
>
> On May 5, 2014, 11:36 a.m., Bernardo Gomez Palacio wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/21083/
> > -----------------------------------------------------------
> >
> > (Updated May 5, 2014, 11:36 a.m.)
> >
> >
> > Review request for mesos and Mesos ReviewBot.
> >
> >
> > Bugs: MESOS-1294
> > https://issues.apache.org/jira/browse/MESOS-1294
> >
> >
> > Repository: mesos-git
> >
> >
> > Description
> > -------
> >
> > [MESOS-1259]:Enrich the Java Docs in the src/java files. -- State.java
> >
> >
> > Diffs
> > -----
> >
> > src/java/src/org/apache/mesos/state/State.java
> d14d79b4850f677588c928803aba921030571fb8
> >
> > Diff: https://reviews.apache.org/r/21083/diff/
> >
> >
> > Testing
> > -------
> >
> > 1. ./bootstrap && mkdir build && cd build && ../configure && make
> > 2. cd src/java/target/apidocs
> > 3. Open index.html in your browser. i.e. open index.html
> > 4. Verify the Executor API.
> >
> >
> > Thanks,
> >
> > Bernardo Gomez Palacio
> >
> >
>
>
Re: Review Request 21083: [MESOS-1259:MESOS-1294]:Enrich the Java Docs in
the src/java files. -- State.java
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21083/#review42426
-----------------------------------------------------------
src/java/src/org/apache/mesos/state/State.java
<https://reviews.apache.org/r/21083/#comment76189>
Don't you want to align the @return and @param description here (and the two other comment blocks) like in http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html? :)
- Niklas Nielsen
On May 5, 2014, 11:36 a.m., Bernardo Gomez Palacio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21083/
> -----------------------------------------------------------
>
> (Updated May 5, 2014, 11:36 a.m.)
>
>
> Review request for mesos and Mesos ReviewBot.
>
>
> Bugs: MESOS-1294
> https://issues.apache.org/jira/browse/MESOS-1294
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> [MESOS-1259]:Enrich the Java Docs in the src/java files. -- State.java
>
>
> Diffs
> -----
>
> src/java/src/org/apache/mesos/state/State.java d14d79b4850f677588c928803aba921030571fb8
>
> Diff: https://reviews.apache.org/r/21083/diff/
>
>
> Testing
> -------
>
> 1. ./bootstrap && mkdir build && cd build && ../configure && make
> 2. cd src/java/target/apidocs
> 3. Open index.html in your browser. i.e. open index.html
> 4. Verify the Executor API.
>
>
> Thanks,
>
> Bernardo Gomez Palacio
>
>