You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (JIRA)" <ji...@apache.org> on 2012/09/11 19:16:07 UTC
[jira] [Created] (CASSANDRA-4647) Rename NodeId to CounterId
Sylvain Lebresne created CASSANDRA-4647:
-------------------------------------------
Summary: Rename NodeId to CounterId
Key: CASSANDRA-4647
URL: https://issues.apache.org/jira/browse/CASSANDRA-4647
Project: Cassandra
Issue Type: Improvement
Reporter: Sylvain Lebresne
Assignee: Sylvain Lebresne
Priority: Minor
Fix For: 1.2.0 beta 1
NodeId is pretty close to the hostId introduced by vnodes, so let's rename NodeId to CounterId to avoid any potential confusion. It's probably a better name anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4647) Rename NodeId to CounterId
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453207#comment-13453207 ]
Jonathan Ellis commented on CASSANDRA-4647:
-------------------------------------------
+1
> Rename NodeId to CounterId
> --------------------------
>
> Key: CASSANDRA-4647
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4647
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.2.0 beta 1
>
> Attachments: 4647.txt
>
>
> NodeId is pretty close to the hostId introduced by vnodes, so let's rename NodeId to CounterId to avoid any potential confusion. It's probably a better name anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4647) Rename NodeId to CounterId
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-4647:
----------------------------------------
Attachment: 4647.txt
Patch attached that does the renaming pretty much everywhere. I even edited the comments (at least for those returned by a simple grep). The only thing that still has NodeId is the system table NodeIdInfo, since changing the name would require migrating it's data.
> Rename NodeId to CounterId
> --------------------------
>
> Key: CASSANDRA-4647
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4647
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 1.2.0 beta 1
>
> Attachments: 4647.txt
>
>
> NodeId is pretty close to the hostId introduced by vnodes, so let's rename NodeId to CounterId to avoid any potential confusion. It's probably a better name anyway.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira