You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/06/30 15:27:12 UTC

[GitHub] zeppelin pull request #1110: [ZEPPELIN-1091] Disable ace editor's showSettin...

GitHub user astroshim opened a pull request:

    https://github.com/apache/zeppelin/pull/1110

    [ZEPPELIN-1091] Disable ace editor's showSettingsMenu in paragraph.

    ### What is this PR for?
    This PR prevent to show the ace editor's showSettingMenu screen.
    
    
    ### What type of PR is it?
    Bug Fix
    
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1091
    
    
    ### How should this be tested?
    Type "Ctrl+," on your paragraph.
    
    ### Screenshots (if appropriate)
      - before
    ![image](https://cloud.githubusercontent.com/assets/3348133/16493924/57e25ef0-3f22-11e6-8956-1a81bcbc8abb.png)
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/astroshim/zeppelin ZEPPELIN-1091

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1110.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1110
    
----
commit c736db09e1b18cfcfbae2b9b15cd6c7aec95f0ce
Author: astroshim <hs...@nflabs.com>
Date:   2016-06-30T15:22:35Z

    disable showSettingsMenu

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1110: [ZEPPELIN-1091] Disable ace editor's showSettingsMenu ...

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1110
  
    Merging if there is no more discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1110: [ZEPPELIN-1091] Disable ace editor's showSettingsMenu ...

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1110
  
    @astroshim Can you rebase it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1110: [ZEPPELIN-1091] Disable ace editor's showSettingsMenu ...

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1110
  
    On Mac OSx the shortcut is CMD+,
    Tested LGTM



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1110: [ZEPPELIN-1091] Disable ace editor's showSettingsMenu ...

Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:

    https://github.com/apache/zeppelin/pull/1110
  
    Is this PR going to be merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1110: [ZEPPELIN-1091] Disable ace editor's showSettin...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1110


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1110: [ZEPPELIN-1091] Disable ace editor's showSettingsMenu ...

Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:

    https://github.com/apache/zeppelin/pull/1110
  
    @corneadoug I just rebased. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---