You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "hanahmily (via GitHub)" <gi...@apache.org> on 2023/08/28 22:11:00 UTC

[GitHub] [skywalking-banyandb] hanahmily commented on a diff in pull request #320: Implement the remote queue to spreading data to data nodes

hanahmily commented on code in PR #320:
URL: https://github.com/apache/skywalking-banyandb/pull/320#discussion_r1308008553


##########
banyand/liaison/grpc/stream.go:
##########
@@ -101,7 +101,7 @@ func (s *streamService) Write(stream streamv1.StreamService_WriteServer) error {
 		if s.log.Debug().Enabled() {
 			iwr.EntityValues = tagValues.Encode()
 		}
-		message := bus.NewMessage(bus.MessageID(time.Now().UnixNano()), iwr)
+		message := bus.NewMessageWithNode(bus.MessageID(time.Now().UnixNano()), "TODO", iwr)

Review Comment:
   @lujiajing1126 The result of shard allocation will be passed with the message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org