[GitHub] [flink] twalthr commented on a change in pull request #11959: [FLINK-16997][table-common] Add new factory interfaces and discovery utilities

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #11959:
URL: https://github.com/apache/flink/pull/11959#discussion_r419892167



##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogBaseTable.java
##########
@@ -28,13 +29,24 @@
  * key-value pairs defining the properties of the table.
  */
 public interface CatalogBaseTable {
+
 	/**
-	 * Get the properties of the table.
-	 *
-	 * @return property map of the table/view
+	 * @deprecated Use {@link #getOptions()}.
 	 */
+	@Deprecated
 	Map<String, String> getProperties();
 
+	/**
+	 * Returns a map of string-based options.
+	 *
+	 * <p>In case of {@link CatalogTable}, these options may determine the kind of connector and its

Review comment:
       `may` because if the Catalog provides its own factory it might not be used




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org