You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Duru Can Celasun (Jira)" <ji...@apache.org> on 2020/05/12 06:35:00 UTC
[jira] [Commented] (THRIFT-5205) Tag prior releases with "v" prefix
for compatibility with go.mod
[ https://issues.apache.org/jira/browse/THRIFT-5205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105132#comment-17105132 ]
Duru Can Celasun commented on THRIFT-5205:
------------------------------------------
v0.12.0 is already [tagged|https://github.com/apache/thrift/tree/v0.12.0] with the "v" prefix.
If you need to use older version, you can simply use "go get" with a specific commit hash. For example 0.11.0 was tagged on [this commit|https://github.com/apache/thrift/commit/327ebb6c2b6df8bf075da02ef45a2a034e9b79ba] and you can simply run:
{code}
$ go get github.com/apache/thrift@327ebb6c2b6df8bf075da02ef45a2a034e9b79ba
{code}
and your go.mod file will look like this:
{code}
module github.com/example/project
go 1.14
require github.com/apache/thrift v0.0.0-20171203172758-327ebb6c2b6d // indirect
{code}
> Tag prior releases with "v" prefix for compatibility with go.mod
> ----------------------------------------------------------------
>
> Key: THRIFT-5205
> URL: https://issues.apache.org/jira/browse/THRIFT-5205
> Project: Thrift
> Issue Type: Task
> Components: Go - Library
> Affects Versions: 0.10.0, 0.11.0, 0.12.0
> Reporter: Prashant V
> Priority: Blocker
>
> Thrift 0.13.0 uses the tag "v0.13.0", while prior releases do not have the "v" prefix. Is it possible to add an additional tag "v0.10.0", "v0.11.0", etc for older releases so that Go modules works correctly with them, see [https://github.com/golang/go/issues/32945]
>
> We have some projects that use older versions and can't update due to the breaking changes where ctx was added as a parameter, so need to use old versions, but would still like to use go.mod.
>
> Adding additional tags (the old ones should still be valid) would help unblock usage of Go modules.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)