[jira] [Updated] (FELIX-4695) Normalize os.version system property in framework properties

["Felix Meschberger (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FELIX-4695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Felix Meschberger updated FELIX-4695:
-------------------------------------
    Attachment: FELIX-4695-Felix.patch
                FELIX-4695-ExtensionManager.patch

Two mutually "exclusive" patches:

One against the Felix class causing the org.osgi.framework.os.version property to be a valid Version value string. This would be in line of my reading section 4.2.2, Launching Propertes, of OSGi Core R6:

bq. The version of the operating system as used in the native code clause. If not set, then the framework must provide a default value. If the operating system reported version does not fit the standard version syntax (e.g. 2.4.32-kwt), then the launcher should define this launching property with a valid version value.

The other patch is against the ExtensionManager building the native capabilities. This would ensure the native capability property is a valid version.

Looking at cited section 4.2.2, I would probably prefer the patch against the Felix class to ensure the framework properties contain a valid OSGi Version string.

WDYT ?

> Normalize os.version system property in framework properties
> ------------------------------------------------------------
>
>                 Key: FELIX-4695
>                 URL: https://issues.apache.org/jira/browse/FELIX-4695
>             Project: Felix
>          Issue Type: Bug
>          Components: Framework
>    Affects Versions: framework-4.4.1
>            Reporter: Felix Meschberger
>            Assignee: Felix Meschberger
>             Fix For: framework-4.6.0
>
>         Attachments: FELIX-4695-ExtensionManager.patch, FELIX-4695-Felix.patch
>
>
> The Felix class currently normalizes the processor name and os name system property before putting it into the framework properties.
> Likewise the os version system property should be normalized as well.
> Symptom of not normalizing the os version is the ExtensionManager.buildNativeCapabilites method failing to create the os version.
> Alternatively, the ExtensionManager.buildNativeCapabilites method could itself normalize the os.version framework property. This would prevent the method from failing and would still allow the R4LibraryClause to match an os version capability (R4LlibraryClause does normalize the os version in the clause of the bundle before matching).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)