You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "David Jencks (JIRA)" <de...@geronimo.apache.org> on 2006/07/27 17:29:14 UTC
[jira] Commented: (GERONIMO-2227) ENC Lookup Fix (include parent
modules)
[ http://issues.apache.org/jira/browse/GERONIMO-2227?page=comments#action_12423859 ]
David Jencks commented on GERONIMO-2227:
----------------------------------------
Maybe I'm missing something, but you patch appears to assign null to an already null variable. It also doesn't address the issue of looking in parents. I also don't understand where the line
- //moduleURI = linkName.substring(0, pos);
you are proposing to remove came from and think that it would be correct. The idea is that is you specify
j2ee-module#admin-object-name
we will only look in that particular j2ee module, not some other that might have a similarly named admin object.
Do you have an sample to show the problem you are trying to solve?
> ENC Lookup Fix (include parent modules)
> ---------------------------------------
>
> Key: GERONIMO-2227
> URL: http://issues.apache.org/jira/browse/GERONIMO-2227
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Affects Versions: 1.1
> Reporter: Aaron Mulder
> Assigned To: David Jencks
> Fix For: 1.1.1
>
> Attachments: 2227-enc-include-parents.patch
>
>
> I ran across this while working on plugins that use resource-ref-like features to identify a database connection pool, JMS destination, etc.
> The problem was that some naming searches were restricted to the current module only when I felt all parents should be searched too.
> I would like David J to review this before I commit it, as my understanding of the code in question is not terribly thorough.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira