You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/09 16:18:02 UTC

[GitHub] [spark] ivoson opened a new pull request #35466: Use error classes in the execution errors of pivoting

ivoson opened a new pull request #35466:
URL: https://github.com/apache/spark/pull/35466


   ### What changes were proposed in this pull request?
   Migrate the following errors in QueryExecutionErrors onto use error classes:
   1. repeatedPivotsUnsupportedError => UNSUPPORTED_FEATURE
   2. pivotNotAfterGroupByUnsupportedError => UNSUPPORTED_FEATURE
   
   ### Why are the changes needed?
   Porting pivot execute errors to new error framework.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   UT added.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #35466: [SPARK-38113][SQL] Use error classes in the execution errors of pivoting

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #35466:
URL: https://github.com/apache/spark/pull/35466#issuecomment-1034672784


   +1, LGTM. Merging to master.
   Thank you, @ivoson .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk closed pull request #35466: [SPARK-38113][SQL] Use error classes in the execution errors of pivoting

Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #35466:
URL: https://github.com/apache/spark/pull/35466


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #35466: [SPARK-38113][SQL]Use error classes in the execution errors of pivoting

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35466:
URL: https://github.com/apache/spark/pull/35466#issuecomment-1034512564


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] ivoson commented on pull request #35466: [SPARK-38113][SQL]Use error classes in the execution errors of pivoting

Posted by GitBox <gi...@apache.org>.
ivoson commented on pull request #35466:
URL: https://github.com/apache/spark/pull/35466#issuecomment-1034421119


   cc @MaxGekk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] ivoson commented on pull request #35466: [SPARK-38113][SQL]Use error classes in the execution errors of pivoting

Posted by GitBox <gi...@apache.org>.
ivoson commented on pull request #35466:
URL: https://github.com/apache/spark/pull/35466#issuecomment-1034420777


   > Thanks @ivoson. Do you mind linking the JIRA ticket to the PR title? See also https://spark.apache.org/contributing.html
   
   Thanks @HyukjinKwon . Done.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #35466: Use error classes in the execution errors of pivoting

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35466:
URL: https://github.com/apache/spark/pull/35466#issuecomment-1034360957


   Thanks @ivoson. Do you mind linking the JIRA ticket to the PR title? See also https://spark.apache.org/contributing.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org