You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/02/24 01:35:56 UTC

[GitHub] timifasubaa commented on a change in pull request #4469: Make access request redirect to dashboard if user already has access

timifasubaa commented on a change in pull request #4469: Make access request redirect to dashboard if user already has access
URL: https://github.com/apache/incubator-superset/pull/4469#discussion_r170405298
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -842,6 +842,13 @@ def request_access(self):
                 .one()
             )
             datasources.add(datasource)
+
+        has_access = True
+        for datasource in datasources:
+            has_access &= (datasource and self.datasource_access(datasource))
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services