You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Venkat Mahadevan <ve...@mitre.org> on 2013/05/09 15:14:22 UTC
Review Request: SHINDIG-1916: Application Data to handle Objects instead of
Strings
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11024/
-----------------------------------------------------------
Review request for shindig.
Description
-------
Currently the AppData is handling only a Map<String, String>. Need the ability to handle values other than String, something like Map<String, Object> so that we can have, for eg., boolean value as well.
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AppDataHandler.java 1479991
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/AppDataService.java 1479991
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1479991
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/AppDataHandlerTest.java 1479991
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1479991
Diff: https://reviews.apache.org/r/11024/diff/
Testing
-------
Thanks,
Venkat Mahadevan
Re: Review Request: SHINDIG-1916: Application Data to handle Objects instead
of Strings
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11024/#review20419
-----------------------------------------------------------
Ship it!
Ship It!
- Ryan Baxter
On May 9, 2013, 1:14 p.m., Venkat Mahadevan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11024/
> -----------------------------------------------------------
>
> (Updated May 9, 2013, 1:14 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Currently the AppData is handling only a Map<String, String>. Need the ability to handle values other than String, something like Map<String, Object> so that we can have, for eg., boolean value as well.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AppDataHandler.java 1479991
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/AppDataService.java 1479991
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1479991
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/AppDataHandlerTest.java 1479991
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1479991
>
> Diff: https://reviews.apache.org/r/11024/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkat Mahadevan
>
>
Re: Review Request: SHINDIG-1916: Application Data to handle Objects instead
of Strings
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11024/#review20417
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/AppDataHandlerTest.java
<https://reviews.apache.org/r/11024/#comment42072>
Can you please make sure that you're using the eclipse style config files so that your editor doesn't do this kind of cleanup?
- Dan Dumont
On May 9, 2013, 1:14 p.m., Venkat Mahadevan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11024/
> -----------------------------------------------------------
>
> (Updated May 9, 2013, 1:14 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Currently the AppData is handling only a Map<String, String>. Need the ability to handle values other than String, something like Map<String, Object> so that we can have, for eg., boolean value as well.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AppDataHandler.java 1479991
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/AppDataService.java 1479991
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1479991
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/AppDataHandlerTest.java 1479991
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1479991
>
> Diff: https://reviews.apache.org/r/11024/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkat Mahadevan
>
>
Re: Review Request: SHINDIG-1916: Application Data to handle Objects instead
of Strings
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11024/#review21507
-----------------------------------------------------------
Ship it!
Committed revision 1490108
- Ryan Baxter
On May 21, 2013, 4:12 p.m., Venkat Mahadevan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11024/
> -----------------------------------------------------------
>
> (Updated May 21, 2013, 4:12 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Currently the AppData is handling only a Map<String, String>. Need the ability to handle values other than String, something like Map<String, Object> so that we can have, for eg., boolean value as well.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AppDataHandler.java 1484816
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/AppDataService.java 1484816
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1484816
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/AppDataHandlerTest.java 1484816
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1484816
>
> Diff: https://reviews.apache.org/r/11024/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkat Mahadevan
>
>
Re: Review Request: SHINDIG-1916: Application Data to handle Objects instead
of Strings
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11024/#review20851
-----------------------------------------------------------
Great that patch worked but I see another problem. Since you updated the AppDataService interface you need to also update AppDataServiceDb or else you get compile errors when you build shindig-samples. Henry should be removing this project soon so if it is going to take you more than a minute to fix it I would just wait until that happens.
- Ryan Baxter
On May 21, 2013, 4:12 p.m., Venkat Mahadevan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11024/
> -----------------------------------------------------------
>
> (Updated May 21, 2013, 4:12 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Currently the AppData is handling only a Map<String, String>. Need the ability to handle values other than String, something like Map<String, Object> so that we can have, for eg., boolean value as well.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AppDataHandler.java 1484816
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/AppDataService.java 1484816
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1484816
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/AppDataHandlerTest.java 1484816
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1484816
>
> Diff: https://reviews.apache.org/r/11024/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkat Mahadevan
>
>
Re: Review Request: SHINDIG-1916: Application Data to handle Objects instead
of Strings
Posted by Venkat Mahadevan <ve...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11024/
-----------------------------------------------------------
(Updated May 21, 2013, 4:12 p.m.)
Review request for shindig.
Changes
-------
Ryan, can you pls try this one.
Description
-------
Currently the AppData is handling only a Map<String, String>. Need the ability to handle values other than String, something like Map<String, Object> so that we can have, for eg., boolean value as well.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AppDataHandler.java 1484816
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/AppDataService.java 1484816
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1484816
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/AppDataHandlerTest.java 1484816
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1484816
Diff: https://reviews.apache.org/r/11024/diff/
Testing
-------
Thanks,
Venkat Mahadevan
Re: Review Request: SHINDIG-1916: Application Data to handle Objects instead
of Strings
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11024/#review20841
-----------------------------------------------------------
I tried applying the patch to trunk but I am getting errors applying it. Can you double check that the patch is generated from trunk?
- Ryan Baxter
On May 21, 2013, 12:48 p.m., Venkat Mahadevan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11024/
> -----------------------------------------------------------
>
> (Updated May 21, 2013, 12:48 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Currently the AppData is handling only a Map<String, String>. Need the ability to handle values other than String, something like Map<String, Object> so that we can have, for eg., boolean value as well.
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AppDataHandler.java 1481074
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/AppDataService.java 1481074
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1481074
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/AppDataHandlerTest.java 1481074
> http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1481074
>
> Diff: https://reviews.apache.org/r/11024/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Venkat Mahadevan
>
>
Re: Review Request: SHINDIG-1916: Application Data to handle Objects instead
of Strings
Posted by Venkat Mahadevan <ve...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11024/
-----------------------------------------------------------
(Updated May 21, 2013, 12:48 p.m.)
Review request for shindig.
Changes
-------
Updated the code to use eclipse style config.
Description
-------
Currently the AppData is handling only a Map<String, String>. Need the ability to handle values other than String, something like Map<String, Object> so that we can have, for eg., boolean value as well.
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/AppDataHandler.java 1481074
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/AppDataService.java 1481074
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1481074
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/AppDataHandlerTest.java 1481074
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1481074
Diff: https://reviews.apache.org/r/11024/diff/
Testing
-------
Thanks,
Venkat Mahadevan