[jira] [Commented] (THRIFT-4453) Go generator flag to turn off Context parameter

["Can Celasun (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733097#comment-16733097 ] 

Can Celasun commented on THRIFT-4453:
-------------------------------------

-1 on this. context has been in the Go standard library for 2 years now. Additionally, the compile time breakage introduced by this in 0.11 is trivially easy to fix: just add "ctx context.Context" as first parameter to all RPC handler functions, which shouldn't take more than a few minutes.

> Go generator flag to turn off Context parameter
> -----------------------------------------------
>
>                 Key: THRIFT-4453
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4453
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Compiler
>    Affects Versions: 0.11.0
>            Reporter: Renan DelValle
>            Priority: Minor
>
> It would be worthwhile to be able to pass a argument to the code generator for Go that allows to disable the addition of the Context parameter to each function signature that was included with the 0.11.0 release. This is to avoid backwards incompatible code generation in cases where developers don't require context.
> This flag could be as simple as `-disable-context`



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)