You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "CurtHagenlocher (via GitHub)" <gi...@apache.org> on 2025/02/01 17:23:54 UTC
[PR] Add support for Decimal32 and Decimal64 [arrow-rs]
CurtHagenlocher opened a new pull request, #7061:
URL: https://github.com/apache/arrow-rs/pull/7061
# Which issue does this PR close?
Closes #6661.
# Rationale for this change
Decimal32 and Decimal64 were added to Arrow recently; this implements support in arrow-rs.
# What changes are included in this PR?
Code and tests for the new types are included.
# Are there any user-facing changes?
New types `Decimal32Array`, `Decimal64Array`, `Decimal32Type`, and `Decimal64Type` are added. New values `Decimal32` and `Decimal64` have been added to the `DataType` enum. Consumers may need to update their `match`es accordingly.
32-bit and 64-bit decimal values from Parquet files are still being returned as `Decimal128` by default unless the consumer specifically asks for the narrower type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for Decimal32 and Decimal64 [arrow-rs]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher closed pull request #7061: Add support for Decimal32 and Decimal64
URL: https://github.com/apache/arrow-rs/pull/7061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for Decimal32 and Decimal64 [arrow-rs]
Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on PR #7061:
URL: https://github.com/apache/arrow-rs/pull/7061#issuecomment-2629036282
This change is rather large. It would in principle be possible to first submit a separate PR with a small number of refactoring changes before the PR that adds the new types. I think the context for the refactoring changes is useful, but would be willing to do the split if there's demand for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add support for Decimal32 and Decimal64 [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #7061:
URL: https://github.com/apache/arrow-rs/pull/7061#issuecomment-2629052846
> would be willing to do the split if there's demand for it
I think it will be necessary to break this into smaller incremental pieces to get this in. Not just the refactoring, but also the functionality itself - the addition to DataType for example could be its own PR.
I appreciate this is more effort on your end, but we're very review constrained, and a 3000 line diff is simply not tractable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org